Skip to content

chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448

Merged
wobsoriano merged 3 commits into
mainfrom
rob/port-7445-and-7431
Dec 13, 2025
Merged

chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom
rob/port-7445-and-7431

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 12, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).

This PR includes:

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of Request instances across environments to avoid mis-detection

  • Refactor

    • Metadata header formatting converted to async

  • Tests

    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await

  • Chores

    • Removed an unused dependency
    • Added a placeholder changeset file

✏️ Tip: You can customize this high-level summary in your review settings.

@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot

changeset-botBot commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c8275d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm

@coderabbitai

coderabbitaiBot commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.

Changes

Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts,
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts,
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).

Poem

🐰 I sniffed the code and gave a hop,

Replaced a check that always stopped,
Headers now promise to arrive,
And unused deps take a dive,
A tidy patch—now onward I hop! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/port-7445-and-7431

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0

@wobsorianowobsoriano changed the title chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano changed the title chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano merged commit 395a4ca into mainDec 13, 2025
563 of 585 checks passed
@wobsoriano
wobsoriano deleted the rob/port-7445-and-7431 branch December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees

No one assigned

Labels

backendcore-3integrationnextjs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers by wobsoriano · Pull Request #7448 · clerk/javascript · GitHub
Skip to content
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers - #7448
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Dec 13, 2025
Merged
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headers#7448
wobsoriano merged 3 commits into
mainfrom 
rob/port-7445-and-7431
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 12, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Cherry-picked from PR #7431 and PR #7445 (branched off release/core-2).
This PR includes:
Summary by CodeRabbit
Summary by CodeRabbit
  • Bug Fixes
    • Improved handling of Request instances across environments to avoid mis-detection
  • Refactor
    • Metadata header formatting converted to async
  • Tests
    • Added tests covering request instance detection and reuse
    • Updated metadata header tests to async/await
  • Chores
    • Removed an unused dependency
    • Added a placeholder changeset file
✏️ Tip: You can customize this high-level summary in your review settings.
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@changeset-bot
changeset-botBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: c8275d0
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 12, 2025 8:08pm
@coderabbitai
coderabbitaiBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
Replaces an instanceof check with duck-typing for ClerkRequest detection, converts formatMetadataHeaders to return Promise (tests updated), and removes the srvx dependency from a template package.json.
Changes
Cohort / File(s)Change Summary
Dependency cleanup
integration/templates/tanstack-react-start/package.json		Removed the srvx dependency (0.8.15) from the template's dependencies.
ClerkRequest duck-typing refactor
packages/backend/src/tokens/clerkRequest.ts, 
packages/backend/src/tokens/__tests__/clerkRequest.test.ts		Replaced instanceof detection with duck-typing (checks for clerkUrl and cookies) when creating/identifying ClerkRequest; added tests for regular Request, existing ClerkRequest, and bundler-scoped (subclassed) Request cases.
Keyless custom headers async conversion
packages/nextjs/src/server/keyless-custom-headers.ts, 
packages/nextjs/src/__tests__/keyless-custom-headers.test.ts		Made formatMetadataHeaders(metadata) asynchronous (Promise<Headers>); updated tests to use async/await. Implementation of header construction unchanged.
Changeset
.changeset/dull-forks-agree.md		Added an empty/placeholder changeset file containing YAML separators.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
  • Inspect clerkRequest.ts duck-typing heuristic for completeness and potential false positives.
  • Verify all callers of formatMetadataHeaders are updated to await the new Promise-returning API.
  • Review added tests for correctness and coverage (edge cases around subclassed Request objects).
Poem
🐰 I sniffed the code and gave a hop,
Replaced a check that always stopped,

Headers now promise to arrive,

And unused deps take a dive,

A tidy patch—now onward I hop! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check✅ PassedThe title accurately summarizes the main changes: fixing ClerkRequest instance checking and making keyless custom headers async, matching the core objectives of the PR.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/port-7445-and-7431
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 12, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7448

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7448

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7448

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7448

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7448

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7448

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7448

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7448

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7448

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7448

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7448

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7448

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7448

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7448

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7448

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7448

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7448

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7448

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7448

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7448

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7448

commit: c8275d0
@wobsorianowobsoriano
changed the title
chore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headerschore(backend): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsorianowobsoriano
changed the title
chore(backend): Fix ClerkRequest instance check and keyless custom headerschore(backend,nextjs): Fix ClerkRequest instance check and keyless custom headersDec 13, 2025
@wobsoriano
wobsoriano
merged commit 395a4ca
into
mainDec 13, 2025

563 of 585 checks passed

@wobsoriano
wobsoriano
deleted the

rob/port-7445-and-7431

branch
December 13, 2025 23:11
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

backendcore-3integrationnextjs

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski