Skip to content

chore(backend): Fix ClerkRequest helper instance check - #7431

Merged
wobsoriano merged 3 commits into
release/core-2from
rob/fix-clerk-request
Dec 10, 2025
Merged

chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from
rob/fix-clerk-request

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 10, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Description

Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.

This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.

Builds on top of #7421

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Dec 10, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 82a182b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 10, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm

@coderabbitai

coderabbitaiBot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/fix-clerk-request

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano changed the title chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new

pkg-pr-newBot commented Dec 10, 2025•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b

jacekradko
jacekradko approved these changes Dec 10, 2025
View reviewed changes

@jacekradkojacekradko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@wobsoriano
wobsoriano enabled auto-merge (squash) December 10, 2025 20:47
@wobsoriano
wobsoriano merged commit 43d3c3e into release/core-2Dec 10, 2025
76 of 77 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-clerk-request branch December 10, 2025 20:51
@clerk-cookieclerk-cookie mentioned this pull request Dec 10, 2025
Merged
@wobsorianowobsoriano mentioned this pull request Dec 10, 2025
Closed
4 tasks
wobsoriano added a commit that referenced this pull request Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano mentioned this pull request Dec 12, 2025
Merged
@thiskevinwangthiskevinwang mentioned this pull request Feb 17, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backendcore-2integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
chore(backend): Fix ClerkRequest helper instance check by wobsoriano · Pull Request #7431 · clerk/javascript · GitHub
Skip to content
chore(backend): Fix ClerkRequest helper instance check - #7431
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Dec 10, 2025
Merged
chore(backend): Fix ClerkRequest helper instance check#7431
wobsoriano merged 3 commits into
release/core-2from 
rob/fix-clerk-request
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Description
Replace instanceof check with duck typing to fix issue where bundlers create multiple Request class instances, causing instanceof ClerkRequest to incorrectly return true for regular Request objects.
This fixes the issue in TanStack React Start (#6996) and other environments where polyfilled or scoped Request classes break instanceof checks.
Builds on top of #7421
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@wobsoriano@chris-kreidl
chore(backend): fix createClerkRequest instanceof check in bundled en…
d679696
…vironments
Replace instanceof check with duck typing to fix issue where bundlers
create multiple Request class instances, causing instanceof ClerkRequest
to incorrectly return true for regular Request objects.
This fixes the issue in TanStack Start and other environments where
polyfilled or scoped Request classes break instanceof checks.
Co-authored-by: chris-kreidl <chris-kreidl@users.noreply.github.com>
@changeset-bot
changeset-botBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 82a182b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentPreviewCommentsUpdated (UTC)
clerk-js-sandboxReadyReadyPreviewCommentDec 10, 2025 8:13pm
@coderabbitai
coderabbitaiBot
commented
Dec 10, 2025

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/fix-clerk-request
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
chore(backend): fix ClerkRequest helper instance checkchore(backend): Fix ClerkRequest helper instance checkDec 10, 2025
@pkg-pr-new
pkg-pr-newBot
commented
Dec 10, 2025•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7431

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7431

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7431

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7431

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7431

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7431

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7431

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7431

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7431

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7431

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7431

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7431

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7431

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7431

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7431

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7431

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7431

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7431

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7431

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7431

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7431

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7431

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7431

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7431

commit: 82a182b
jacekradko
jacekradko
approved these changes
Dec 10, 2025
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
@wobsoriano
wobsoriano
enabled auto-merge (squash)
December 10, 2025 20:47
@wobsoriano
wobsoriano
merged commit 43d3c3e
into
release/core-2Dec 10, 2025

76 of 77 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-clerk-request

branch
December 10, 2025 20:51
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 10, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 10, 2025

Closed

4 tasks
wobsoriano added a commit
that referenced
this pull request
Dec 12, 2025
@wobsoriano
chore(backend,nextjs): Fix ClerkRequest instance check and keyless cu…
8343a87
…stom headers
Cherry-picked from PR #7431 and PR #7445:
- Fix ClerkRequest helper instance check using duck typing instead of instanceof
- Make formatMetadataHeaders async to comply with Server Actions
- Remove srvx dependency from tanstack-react-start integration template
@wobsorianowobsoriano
mentioned this pull request
Dec 12, 2025
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

backendcore-2integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko