Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7508 · clerk/javascript · GitHub
Skip to content

feat(localizations): Add waitlist translations - #7508

Merged
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations
Dec 18, 2025
Merged

feat(localizations): Add waitlist translations#7508
wobsoriano merged 2 commits into
mainfrom
rob/port-waitlist-translations

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 18, 2025

Copy link
Copy Markdown
Member

Description

Porting #7483 to Core 3

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Localization
    • Added waitlist flow text translations for 17 languages including Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-botBot commented Dec 18, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a9e1988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 18, 2025 5:23pm

@coderabbitai

coderabbitaiBot commented Dec 18, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds a changeset metadata file and populates previously undefined localization strings across 17 language files. Specifically, the waitlist.start section (actionLink, actionText, formButton, subtitle, title) and waitlist.success section (message, subtitle, title) receive concrete translated strings in Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese. No exported API signatures are modified—only localization content values are updated.

Pre-merge checks

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding waitlist translations across multiple localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5d166e5 and a9e1988.

📒 Files selected for processing (18)
  • .changeset/mean-windows-jam.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/*

⚙️ CodeRabbit configuration file

If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.

**/*: Only comment on issues that would block merging, ignore minor or stylistic concerns.
Restrict feedback to errors, security risks, or functionality-breaking problems.
Do not post comments on code style, formatting, or non-critical improvements.
Keep reviews short: flag only issues that make the PR unsafe to merge.
Group similar issues into a single comment instead of posting multiple notes.
Skip repetition: if a pattern repeats, mention it once at a summary level only.
Do not add general suggestions, focus strictly on merge-blocking concerns.
If there are no critical problems, respond with minimal approval (e.g., 'Looks good'). Do not add additional review.
Avoid line-by-line commentary unless it highlights a critical bug or security hole.
Highlight only issues that could cause runtime errors, data loss, or severe maintainability issues.
Ignore minor optimization opportunities, focus solely on correctness and safety.
Provide a top-level summary of critical blockers rather than detailed per-line notes.
Comment only when the issue must be resolved before merge, otherwise remain silent.
When in doubt, err on the side of fewer comments, brevity and blocking issues only.
Avoid posting any refactoring issues.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
**/localizations/**/*.ts

⚙️ CodeRabbit configuration file

**/localizations/**/*.ts: Review the changes to localization files with the following guidelines:

  • Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
  • Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
  • Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
  • Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
  • Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
  • Ensure that all keys are unique and that there are no duplicate or conflicting entries.
  • If you notice missing translations for new keys, flag them for completion.

Files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/da-DK.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/it-IT.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (**)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7508

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7508

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7508

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7508

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7508

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7508

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7508

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7508

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7508

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7508

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7508

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7508

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7508

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7508

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7508

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7508

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7508

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7508

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7508

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7508

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7508

commit: a9e1988

@wobsoriano
wobsoriano enabled auto-merge (squash) December 18, 2025 17:30
@wobsoriano
wobsoriano merged commit c8c5086 into mainDec 18, 2025
44 checks passed
@wobsoriano
wobsoriano deleted the rob/port-waitlist-translations branch December 18, 2025 17:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter