Skip to content

feat(localizations): Add waitlist translations - #7483

Merged
wobsoriano merged 3 commits into
release/core-2from
rob/waitlist-localization
Dec 16, 2025
Merged

feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from
rob/waitlist-localization

Conversation

@wobsoriano

@wobsorianowobsoriano commented Dec 16, 2025•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Follow up to #7470, adding waitlist translations

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

wobsorianoand others added 2 commits December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot

changeset-botBot commented Dec 16, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6df1ff2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Dec 16, 2025•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm

@coderabbitai

coderabbitaiBot commented Dec 16, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.

Changes

Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy

Poem

🐰 Across seventeen tongues, we hop with glee,
Waitlist words now set translators free!
From Arabic to Mandarin so bright,
No more undefined—each string's just right! 📝✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/waitlist-localization
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.

📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)

1352-1361: Waitlist strings added with correct shape and semantics

waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.

packages/localizations/src/sv-SE.ts (1)

1356-1365: Consistent Swedish waitlist translations

The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.

packages/localizations/src/fi-FI.ts (1)

1356-1365: Finnish waitlist block matches shared schema

The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.

packages/localizations/src/zh-CN.ts (1)

1320-1329: Simplified Chinese waitlist text correctly wired

The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.

packages/localizations/src/zh-TW.ts (1)

1318-1327: Traditional Chinese waitlist entries align with locale pattern

The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.

packages/localizations/src/is-IS.ts (1)

1358-1371: Waitlist block matches expected shape and reads consistently

waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.

packages/localizations/src/mn-MN.ts (1)

1354-1367: Mongolian waitlist translations are structurally correct

The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.

packages/localizations/src/ca-ES.ts (1)

1359-1372: Catalan waitlist strings align with the shared key contract

All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.

packages/localizations/src/ar-SA.ts (1)

1343-1356: Arabic waitlist localization is complete and consistent

waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.

packages/localizations/src/ko-KR.ts (1)

1336-1349: Korean waitlist block correctly fills all expected keys

The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.

packages/localizations/src/it-IT.ts (1)

1365-1369: Waitlist strings are complete and consistent with the locale

Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.

Also applies to: 1372-1374

packages/localizations/src/sr-RS.ts (1)

1352-1356: Serbian waitlist translations align with schema and tone

Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.

Also applies to: 1359-1361

packages/localizations/src/da-DK.ts (1)

1352-1356: Danish waitlist copy looks correct and consistent

New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.

Also applies to: 1359-1361

packages/localizations/src/hu-HU.ts (1)

1357-1361: Hungarian waitlist translations integrate cleanly

Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.

Also applies to: 1364-1366

packages/localizations/src/hr-HR.ts (1)

1360-1364: Croatian waitlist strings are well-formed and on-brand

The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.

Also applies to: 1367-1369

packages/localizations/src/nb-NO.ts (1)

1352-1365: LGTM! Waitlist translations added correctly.

The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.

packages/localizations/src/el-GR.ts (1)

1362-1376: LGTM! Greek waitlist translations added correctly.

The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.

.changeset/hungry-icons-compete.md (1)

1-5: LGTM! Changeset properly documents the translation additions.

The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano mentioned this pull request Dec 16, 2025
Closed
6 tasks
@wobsoriano

wobsoriano commented Dec 16, 2025

Copy link
Copy Markdown
MemberAuthor

@coderabbitai review

@coderabbitai

coderabbitaiBot commented Dec 16, 2025

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@pkg-pr-new

pkg-pr-newBot commented Dec 16, 2025

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2

@wobsoriano
wobsoriano merged commit 54cd476 into release/core-2Dec 16, 2025
77 of 79 checks passed
@wobsoriano
wobsoriano deleted the rob/waitlist-localization branch December 16, 2025 21:01
@clerk-cookieclerk-cookie mentioned this pull request Dec 16, 2025
Merged
@wobsorianowobsoriano mentioned this pull request Dec 18, 2025
Merged
9 tasks
@thiskevinwangthiskevinwang mentioned this pull request Feb 17, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees

No one assigned

Labels

core-2localizations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(localizations): Add waitlist translations by wobsoriano · Pull Request #7483 · clerk/javascript · GitHub
Skip to content
feat(localizations): Add waitlist translations - #7483
Merged
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Dec 16, 2025
Merged
feat(localizations): Add waitlist translations#7483
wobsoriano merged 3 commits into
release/core-2from 
rob/waitlist-localization
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Dec 16, 2025•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Follow up to #7470, adding waitlist translations
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.
✏️ Tip: You can customize this high-level summary in your review settings.
wobsorianoand others
added 2 commits
December 16, 2025 11:19
@wobsoriano@valentinogagliardi
feat(localizations): Add waitlist translations
23624c2
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@wobsoriano
remove unused changeset
5dd5b40
@changeset-bot
changeset-botBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 6df1ff2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 4 packages
NameType
@clerk/localizationsPatch
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/clerk-expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentDec 16, 2025 7:23pm
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Walkthrough
This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.
Changes
Cohort / File(s)Summary
Changeset
.changeset/hungry-icons-compete.md		Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}		Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy
Poem
🐰 Across seventeen tongues, we hop with glee,

Waitlist words now set translators free!

From Arabic to Mandarin so bright,

No more undefined—each string's just right! 📝✨
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  •  📝 Generate docstrings
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Post copyable unit tests in a comment
  •  Commit unit tests in branch rob/waitlist-localization
📜 Recent review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
  • Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📥 Commits
Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.
📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
All code must pass ESLint checks with the project's configuration
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Follow established naming conventions (PascalCase for components, camelCase for variables)
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs

Use tree-shaking friendly exports

Validate all inputs and sanitize outputs

All public APIs must be documented with JSDoc

Use dynamic imports for optional features

Provide meaningful error messages to developers

Include error recovery suggestions where applicable

Log errors appropriately for debugging

Lazy load components and features when possible

Implement proper caching strategies

Use efficient data structures and algorithms

Implement proper logging with different levels
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs

Use proper type annotations for variables and parameters where inference isn't clear

Avoid any type - prefer unknown when type is uncertain, then narrow with type guards

Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type

Use interface for object shapes that might be extended

Use type for unions, primitives, and computed types

Prefer readonly properties for immutable data structures

Use private for internal implementation details in classes

Use protected for inheritance hierarchies

Use public explicitly for clarity in public APIs

Use mixins for shared behavior across unrelated classes in TypeScript

Use generic constraints with bounded type parameters like <T extends { id: string }>

Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction

Use discriminated unions instead of boolean flags for state management and API responses

Use mapped types for transforming object types

Use conditional types for type-level logic

Leverage template literal types for string manipulation at the type level

Use ES6 imports/exports consistently

Use default exports sparingly, prefer named exports

Document functions with JSDoc comments including @PARAM, @returns, @throws, and @example tags

Create custom error classes that extend Error for specific error types

Use the Result pattern for error handling instead of throwing exceptions

Use optional chaining (?.) and nullish coalescing (??) operators for safe property access

Let TypeScript infer obvious types to reduce verbosity

Use const assertions with as const for literal types

Use satisfies operator for type checking without widening types

Declare readonly arrays and objects for immutable data structures

Use spread operator and array spread for immutable updates instead of mutations

Use lazy loading for large types...
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use ESLint with custom configurations tailored for different package types
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Use Prettier for code formatting across all packages
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support
Files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:
  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)
1352-1361: Waitlist strings added with correct shape and semantics
waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.
packages/localizations/src/sv-SE.ts (1)
1356-1365: Consistent Swedish waitlist translations
The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.
packages/localizations/src/fi-FI.ts (1)
1356-1365: Finnish waitlist block matches shared schema
The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.
packages/localizations/src/zh-CN.ts (1)
1320-1329: Simplified Chinese waitlist text correctly wired
The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.
packages/localizations/src/zh-TW.ts (1)
1318-1327: Traditional Chinese waitlist entries align with locale pattern
The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.
packages/localizations/src/is-IS.ts (1)
1358-1371: Waitlist block matches expected shape and reads consistently
waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.
packages/localizations/src/mn-MN.ts (1)
1354-1367: Mongolian waitlist translations are structurally correct
The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.
packages/localizations/src/ca-ES.ts (1)
1359-1372: Catalan waitlist strings align with the shared key contract
All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.
packages/localizations/src/ar-SA.ts (1)
1343-1356: Arabic waitlist localization is complete and consistent
waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.
packages/localizations/src/ko-KR.ts (1)
1336-1349: Korean waitlist block correctly fills all expected keys
The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.
packages/localizations/src/it-IT.ts (1)
1365-1369: Waitlist strings are complete and consistent with the locale
Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.
Also applies to: 1372-1374
packages/localizations/src/sr-RS.ts (1)
1352-1356: Serbian waitlist translations align with schema and tone
Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.
Also applies to: 1359-1361
packages/localizations/src/da-DK.ts (1)
1352-1356: Danish waitlist copy looks correct and consistent
New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.
Also applies to: 1359-1361
packages/localizations/src/hu-HU.ts (1)
1357-1361: Hungarian waitlist translations integrate cleanly
Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.
Also applies to: 1364-1366
packages/localizations/src/hr-HR.ts (1)
1360-1364: Croatian waitlist strings are well-formed and on-brand
The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.
Also applies to: 1367-1369
packages/localizations/src/nb-NO.ts (1)
1352-1365: LGTM! Waitlist translations added correctly.
The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.
packages/localizations/src/el-GR.ts (1)
1362-1376: LGTM! Greek waitlist translations added correctly.
The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.
.changeset/hungry-icons-compete.md (1)
1-5: LGTM! Changeset properly documents the translation additions.
The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
mentioned this pull request
Dec 16, 2025
 Closed

6 tasks
@wobsoriano
wobsoriano
commented
Dec 16, 2025

Copy link


Copy Markdown

MemberAuthor
@coderabbitai review
@coderabbitai
coderabbitaiBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Contributor
✅ Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@pkg-pr-new
pkg-pr-newBot
commented
Dec 16, 2025

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2
@wobsoriano
wobsoriano
merged commit 54cd476
into
release/core-2Dec 16, 2025

77 of 79 checks passed

@wobsoriano
wobsoriano
deleted the

rob/waitlist-localization

branch
December 16, 2025 21:01
@clerk-cookieclerk-cookie
mentioned this pull request
Dec 16, 2025
 Merged

@wobsorianowobsoriano
mentioned this pull request
Dec 18, 2025
 Merged

9 tasks
@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

core-2localizations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@tmilewski