Skip to content

fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589

Merged
tmilewski merged 1 commit into
release/core-2from
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged

fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

Conversation

@tmilewski

@tmilewskitmilewski commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)

Problem

When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.

Solution

Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.

Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.

Changes

  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewskitmilewski self-assigned this Jan 13, 2026
@changeset-bot

changeset-botBot commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 33f82e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm

@coderabbitai

coderabbitaiBot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@tmilewskitmilewski changed the title fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski changed the title fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new

pkg-pr-newBot commented Jan 13, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4

@tmilewski
tmilewski enabled auto-merge (squash) January 13, 2026 21:17
@tmilewski
tmilewski disabled auto-merge January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed the tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2 branch from 32f5ca6 to 33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski enabled auto-merge (squash) January 13, 2026 21:18
@tmilewski
tmilewski merged commit 57ff2fb into release/core-2Jan 13, 2026
44 checks passed
@tmilewski
tmilewski deleted the tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2 branch January 13, 2026 21:21
@clerk-cookieclerk-cookie mentioned this pull request Jan 13, 2026
Merged
@thiskevinwangthiskevinwang mentioned this pull request Feb 17, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton by tmilewski · Pull Request #7589 · clerk/javascript · GitHub
Skip to content
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton - #7589
Merged
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Jan 13, 2026
Merged
fix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButton#7589
tmilewski merged 1 commit into
release/core-2from 
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Fix: Prevent Clerk-specific props from leaking to child elements in button components (Core 2 port of #7588)
Problem
When passing unsafeMetadata or appearance props to SignUpButton (or appearance to SignInButton) with a custom child element, these props were incorrectly passed down to the child DOM element via the rest spread. This caused React warnings about invalid HTML attributes since these are Clerk-specific props that should not be applied to DOM elements.
Solution
Destructured appearance and unsafeMetadata (for SignUpButton) and appearance (for SignInButton) directly in the props destructuring statement. By extracting these props before the ...rest spread, they are automatically excluded from the props passed to child elements.
Added @ts-expect-error comments to handle TypeScript union type limitations, as these props only exist when mode === 'modal' according to the SignUpButtonProps and SignInButtonProps type definitions.
Changes
  • SignUpButton.tsx: Destructure appearance and unsafeMetadata from props to prevent them from being passed to child elements
  • SignInButton.tsx: Destructure appearance from props to prevent it from being passed to child elements
  • Tests: Added test cases to verify these props are not leaked to child DOM elements
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@tmilewskitmilewski
self-assigned this
Jan 13, 2026
@changeset-bot
changeset-botBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 33f82e4
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
NameType
@clerk/clerk-reactPatch
@clerk/chrome-extensionPatch
@clerk/elementsPatch
@clerk/clerk-expoPatch
@clerk/nextjsPatch
@clerk/react-routerPatch
@clerk/remixPatch
@clerk/tanstack-react-startPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 13, 2026 9:19pm
@coderabbitai
coderabbitaiBot
commented
Jan 13, 2026

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Comment @coderabbitai help to get the list of available commands and usage tips.
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButton (Core 2)fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@tmilewskitmilewski
changed the title
fix(react): Prevent props from leaking to child elements in SignUpButton & SignInButtonfix(clerk-react): Prevent props from leaking to child elements in SignUpButton & SignInButtonJan 13, 2026
@pkg-pr-new
pkg-pr-newBot
commented
Jan 13, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7589

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7589

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7589

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7589

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7589

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7589

@clerk/elements
npm i https://pkg.pr.new/@clerk/elements@7589

@clerk/clerk-expo
npm i https://pkg.pr.new/@clerk/clerk-expo@7589

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7589

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7589

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7589

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7589

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7589

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7589

@clerk/clerk-react
npm i https://pkg.pr.new/@clerk/clerk-react@7589

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7589

@clerk/remix
npm i https://pkg.pr.new/@clerk/remix@7589

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7589

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7589

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7589

@clerk/themes
npm i https://pkg.pr.new/@clerk/themes@7589

@clerk/types
npm i https://pkg.pr.new/@clerk/types@7589

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7589

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7589

commit: 33f82e4
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:17
@tmilewski
tmilewski
disabled auto-merge
January 13, 2026 21:17
@tmilewski
tmilewskiforce-pushed
the
tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2
branch
from
32f5ca6 to
33f82e4CompareJanuary 13, 2026 21:18
@tmilewski
tmilewski
enabled auto-merge (squash)
January 13, 2026 21:18
@tmilewski
tmilewski
merged commit 57ff2fb
into
release/core-2Jan 13, 2026

44 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4263-passing-unsafemetadata-to-signupbutton-and-including-a-child-core-2

branch
January 13, 2026 21:21
@clerk-cookieclerk-cookie
mentioned this pull request
Jan 13, 2026
 Merged

@thiskevinwangthiskevinwang
mentioned this pull request
Feb 17, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@alexcarpenteralexcarpenterAwaiting requested review from alexcarpenter

Assignees

@tmilewskitmilewski

Labels

core-2react

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@wobsoriano