Uh oh!
There was an error while loading. Please reload this page.
fix(expo): migrate useSSO to core-3 and fix browser dismissal for OAuth/SSO flows - #8140
fix(expo): migrate useSSO to core-3 and fix browser dismissal for OAuth/SSO flows#8140chriscanin wants to merge 5 commits into
Conversation
…th/SSO flows - Replace legacy useSignIn/useSignUp imports with core-3 useClerk/useSignIn - Use clerk.client.signIn.reload() with nonce + clerk.setActive() instead of legacy setActive - Add dismissBrowser() in finally block for both useSSO and useOAuth to prevent browser lingering - Handle session_exists errors by clearing stale JWT from SecureStore and retrying - Simplify return type: hook handles session activation internally, callers no longer need setActive
🦋 Changeset detectedLatest commit: 924e1dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/expo/src/hooks/useSSO.ts`:
- Around line 70-85: Replace the incorrect post-call error-checking of
signIn.create (which uses createResult.error) with a try/catch around the await
signIn.create(createParams) call: call signIn.create inside try, and in catch
inspect the thrown error (using isClerkAPIResponseError(error) and checking
error.errors.some(e => e.code === 'session_exists') or
error.message?.includes('already signed in')); if it's a session_exists /
already-signed-in case, call SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY)
and retry signIn.create(createParams), otherwise rethrow the error; if the retry
fails, rethrow that error as well. Ensure you update any references to
createResult to work with the try/catch flow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f7ab895d-0578-4bb7-92d4-aa44d8e84c89
📒 Files selected for processing (2)
packages/expo/src/hooks/useOAuth.tspackages/expo/src/hooks/useSSO.ts
Uh oh!
There was an error while loading. Please reload this page.
chriscanin
commented
Mar 31, 2026
!snapshot |
chriscanin
commented
Mar 31, 2026
!snapshot |
Hey @chriscanin - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/agent-toolkit@0.3.8-snapshot.v20260331162920 --save-exact
npm i @clerk/astro@3.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/backend@3.2.4-snapshot.v20260331162920 --save-exact
npm i @clerk/chrome-extension@3.1.6-snapshot.v20260331162920 --save-exact
npm i @clerk/clerk-js@6.4.0-snapshot.v20260331162920 --save-exact
npm i @clerk/dev-cli@0.1.1-snapshot.v20260331162920 --save-exact
npm i @clerk/expo@3.1.6-snapshot.v20260331162920 --save-exact
npm i @clerk/expo-passkeys@1.0.7-snapshot.v20260331162920 --save-exact
npm i @clerk/express@2.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/fastify@3.1.6-snapshot.v20260331162920 --save-exact
npm i @clerk/hono@0.1.6-snapshot.v20260331162920 --save-exact
npm i @clerk/localizations@4.3.0-snapshot.v20260331162920 --save-exact
npm i @clerk/msw@0.0.7-snapshot.v20260331162920 --save-exact
npm i @clerk/nextjs@7.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/nuxt@2.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/react@6.1.4-snapshot.v20260331162920 --save-exact
npm i @clerk/react-router@3.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/shared@4.4.0-snapshot.v20260331162920 --save-exact
npm i @clerk/tanstack-react-start@1.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/testing@2.0.8-snapshot.v20260331162920 --save-exact
npm i @clerk/ui@1.3.0-snapshot.v20260331162920 --save-exact
npm i @clerk/upgrade@2.0.3-snapshot.v20260331162920 --save-exact
npm i @clerk/vue@2.0.8-snapshot.v20260331162920 --save-exact |
Summary
Fixes the SSO/OAuth flow in
useSSOanduseOAuthfor Expo:useSSOfrom legacy to core-3 API — replacesuseSignIn/useSignUpfrom@clerk/react/legacywithuseClerk/useSignInfrom@clerk/reactopenAuthSessionAsyncin try/finally withawait dismissBrowser()to prevent the in-app browser from lingering in the background after auth completes, which caused subsequent SSO attempts to fail or appear frozen (reported by community user Erwin)session_exists/ "already signed in" errors fromsignIn.create()by clearing the stale JWT from SecureStore and retrying, so users don't get stuck after sign-out → sign-in cyclesclerk.setActive(), callers no longer need to callsetActivethemselvesBefore (app code)
After (app code)
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit