Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-expo-sso-core3.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/expo': patch
---

Migrate `useSSO` hook from legacy to core-3 API and fix browser dismissal for OAuth/SSO flows. The hook now handles session activation internally, so callers no longer need to call `setActive`. Also handles stale session recovery by clearing JWT from SecureStore when `session_exists` errors occur, and dismisses the in-app browser after auth to prevent it from lingering in the background on subsequent sign-in attempts.
21 changes: 15 additions & 6 deletions packages/expo/src/hooks/useOAuth.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,8 @@
return errorThrower.throw('Missing oauth strategy');
}

const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();

Check warning on line 35 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignIn" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();

Check warning on line 36 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

React Hook "useSignUp" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?

async function startOAuthFlow(startOAuthFlowParams?: StartOAuthFlowParams): Promise<StartOAuthFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
Expand DownExpand Up@@ -77,13 +77,22 @@

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
// @ts-ignore

Check warning on line 83 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Include a description after the "@ts-ignore" directive to explain why the @ts-ignore is necessary. The description must be 3 characters or longer
externalVerificationRedirectURL.toString(),
oauthRedirectUrl,
);
} finally {
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 89 in packages/expo/src/hooks/useOAuth.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed
}
}

// @ts-expect-error
// @ts-expect-error - url exists on success result type
const { type, url } = authSessionResult || {};

// TODO: Check all the possible AuthSession results
Expand Down
112 changes: 64 additions & 48 deletions packages/expo/src/hooks/useSSO.ts
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
import { useSignIn, useSignUp } from '@clerk/react/legacy';
import type {
EnterpriseSSOStrategy,
OAuthStrategy,
SetActive,
SignInResource,
SignUpResource,
} from '@clerk/shared/types';
import { useClerk, useSignIn } from '@clerk/react';

Check failure on line 1 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Run autofix to sort these imports!
import { isClerkAPIResponseError } from '@clerk/shared/error';
import type { OAuthStrategy, EnterpriseSSOStrategy } from '@clerk/shared/types';
import * as SecureStore from 'expo-secure-store';
import type * as WebBrowser from 'expo-web-browser';

import { CLERK_CLIENT_JWT_KEY } from '../constants';
import { errorThrower } from '../utils/errors';

export type StartSSOFlowParams = {
Expand All@@ -27,27 +24,20 @@
export type StartSSOFlowReturnType = {
createdSessionId: string | null;
authSessionResult: WebBrowser.WebBrowserAuthSessionResult | null;
setActive?: SetActive;
signIn?: SignInResource;
signUp?: SignUpResource;
};

export function useSSO() {
const { signIn, setActive, isLoaded: isSignInLoaded } = useSignIn();
const { signUp, isLoaded: isSignUpLoaded } = useSignUp();
const clerk = useClerk();
const { signIn } = useSignIn();

async function startSSOFlow(startSSOFlowParams: StartSSOFlowParams): Promise<StartSSOFlowReturnType> {
if (!isSignInLoaded || !isSignUpLoaded) {
if (!signIn || !clerk.client) {
return {
createdSessionId: null,
authSessionResult: null,
signIn,
signUp,
setActive,
};
}

// Dynamically import expo-auth-session and expo-web-browser only when needed
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
let AuthSession: typeof import('expo-auth-session');
// eslint-disable-next-line @typescript-eslint/consistent-type-imports -- dynamic import of optional dependency
Expand All@@ -61,63 +51,89 @@
);
}

const { strategy, unsafeMetadata, authSessionOptions } = startSSOFlowParams ?? {};
const { strategy, authSessionOptions } = startSSOFlowParams ?? {};

/**
* Creates a redirect URL based on the application platform
* It must be whitelisted, either via Clerk Dashboard, or BAPI, in order
* to include the `rotating_token_nonce` on SSO callback
* @ref https://clerk.com/docs/reference/backend-api/tag/Redirect-URLs#operation/CreateRedirectURL
*/
const redirectUrl =
startSSOFlowParams.redirectUrl ??
AuthSession.makeRedirectUri({
path: 'sso-callback',
});

await signIn.create({
const createParams = {
strategy,
redirectUrl,
...(startSSOFlowParams.strategy === 'enterprise_sso' ? { identifier: startSSOFlowParams.identifier } : {}),
});
};

// Create the sign-in attempt. If a stale session exists (e.g. JWT persisted
// in SecureStore after an incomplete sign-out), clear the token and retry.
// The error can surface as either a thrown exception (client-side "already signed in"
// guard) or a returned { error } (FAPI "session_exists" response).
try {
const createResult = await signIn.create(createParams);
if (createResult.error) {
throw createResult.error;
}
} catch (err) {
const isSessionExists = isClerkAPIResponseError(err) && err.errors.some(e => e.code === 'session_exists');
const isAlreadySignedIn = err instanceof Error && err.message?.includes('already signed in');

if (isSessionExists || isAlreadySignedIn) {
await SecureStore.deleteItemAsync(CLERK_CLIENT_JWT_KEY);
const retryResult = await signIn.create(createParams);
if (retryResult.error) {
throw retryResult.error;
}
} else {
throw err;
}
}

const { externalVerificationRedirectURL } = signIn.firstFactorVerification;
if (!externalVerificationRedirectURL) {
return errorThrower.throw('Missing external verification redirect URL for SSO flow');
}

const authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
// Open the in-app browser for the OAuth/SSO provider.
let authSessionResult: WebBrowser.WebBrowserAuthSessionResult;
try {
authSessionResult = await WebBrowserModule.openAuthSessionAsync(
externalVerificationRedirectURL.toString(),
redirectUrl,
authSessionOptions,
);
} finally {
// Dismiss the browser to prevent it from lingering in the background,
// which can cause subsequent SSO attempts to fail or appear frozen.
try {
await WebBrowserModule.dismissBrowser();

Check warning on line 109 in packages/expo/src/hooks/useSSO.ts

View workflow job for this annotation

GitHub Actions/ Static analysis

Unexpected `await` of a non-Promise (non-"Thenable") value
} catch {
// Already dismissed (e.g. iOS ASWebAuthenticationSession auto-dismisses on success)
}
}

if (authSessionResult.type !== 'success' || !authSessionResult.url) {
return {
createdSessionId: null,
setActive,
signIn,
signUp,
authSessionResult,
};
}

const params = new URL(authSessionResult.url).searchParams;
const rotatingTokenNonce = params.get('rotating_token_nonce') ?? '';
await signIn.reload({ rotatingTokenNonce });
const callbackParams = new URL(authSessionResult.url).searchParams;
const createdSessionId = callbackParams.get('created_session_id');
const rotatingTokenNonce = callbackParams.get('rotating_token_nonce') ?? '';

const userNeedsToBeCreated = signIn.firstFactorVerification.status === 'transferable';
if (userNeedsToBeCreated) {
await signUp.create({
transfer: true,
unsafeMetadata,
});
// Pass the nonce to FAPI to verify the OAuth callback and update the client
// with the newly created session. The FAPI response populates the client's
// session list as a side effect, which is required for setActive to work.
await clerk.client.signIn.reload({ rotatingTokenNonce });

if (createdSessionId) {
await clerk.setActive({ session: createdSessionId });
}

return {
createdSessionId: signUp.createdSessionId ?? signIn.createdSessionId,
setActive,
signIn,
signUp,
createdSessionId,
authSessionResult,
};
}
Expand Down
Loading