fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378

Merged
wobsoriano merged 4 commits into
mainfrom
rob/fix-rspack-versions
Apr 22, 2026
Merged

fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom
rob/fix-rspack-versions

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 22, 2026

Copy link
Copy Markdown
Member

Description

Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.

This PR:

  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm

Request Review

@changeset-bot

changeset-botBot commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 615940c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f

📥 Commits

Reviewing files that changed from the base of the PR and between b043164 and 615940c.

📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough

Walkthrough

Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano changed the title fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot reviewed Apr 22, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049

📥 Commits

Reviewing files that changed from the base of the PR and between 93855c2 and b043164.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml

Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new

pkg-pr-newBot commented Apr 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c

@wobsoriano
wobsoriano merged commit 7a423d6 into mainApr 22, 2026
44 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-rspack-versions branch April 22, 2026 16:59
@jacekradkojacekradko mentioned this pull request Apr 22, 2026
Merged
@jacekradkojacekradko mentioned this pull request Apr 30, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
+1 more reviewer
@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clerk-jsui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation - #8378
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Apr 22, 2026
Merged
fix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilation#8378
wobsoriano merged 4 commits into
mainfrom 
rob/fix-rspack-versions
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026

Copy link


Copy Markdown

Member
Description
Rspack 1.7 enabled lazy compilation by default and move out of experimental phase (ref) that caused two issues in the sandbox dev environment.
This PR:
  • Disables lazyCompilation for both clerk-js and ui packages
  • Pins rspack versions to v1 via a new rspack catalog in workspace
  • Adds @rspack/plugin-react-refresh as an explicit dep in clerk-js (previously a phantom dep borrowed from @clerk/ui)
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 22, 2026 4:47pm
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 615940c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: d7753bf7-620e-419d-967d-57a8b3c66f1f
📥 Commits
Reviewing files that changed from the base of the PR and between b043164 and 615940c.
📒 Files selected for processing (1)
  • .changeset/rare-baboons-attack.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-baboons-attack.md
📝 Walkthrough
Walkthrough
Updated rspack dependency management and minor build settings: added a rspack catalog to pnpm-workspace.yaml pinning @rspack/cli@1.7.11, @rspack/core@1.7.11, and @rspack/plugin-react-refresh@1.6.2; replaced inline @rspack version specs in packages/clerk-js/package.json and packages/ui/package.json with catalog:rspack; added @rspack/plugin-react-refresh to packages/clerk-js; set lazyCompilation: false in packages/clerk-js/rspack.config.js and packages/ui/rspack.config.js; added a new empty changeset file.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main changes: pinning rspack to 1.7.x and disabling lazy compilation in both packages.
Description check✅ PassedThe description is clearly related to the changeset, explaining the rationale for the rspack version pinning and lazy compilation changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@wobsorianowobsoriano
changed the title
fix(clerk-js,ui): Pin rspack to 1.7.11 and disable lazy compilationfix(clerk-js,ui): Pin rspack to 1.7.x and disable lazy compilationApr 22, 2026
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/clerk-js/rspack.config.js`:
- Line 472: Add a unit/regression test that loads the Rspack dev config from the
exported config in rspack.config.js and asserts (or snapshots) that the
resulting config contains lazyCompilation: false for the dev runtime;
specifically import the module that exports the dev config, call the function or
require the config used for development, and add an
expect(config.lazyCompilation).toBe(false) or a snapshot asserting
lazyCompilation: false so future Rspack upgrades cannot revert this override.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 5506fb0a-3a1c-46fa-8509-60f9bfa8b049
📥 Commits
Reviewing files that changed from the base of the PR and between 93855c2 and b043164.
⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • packages/clerk-js/package.json
  • packages/clerk-js/rspack.config.js
  • packages/ui/package.json
  • packages/ui/rspack.config.js
  • pnpm-workspace.yaml
Comment threadpackages/clerk-js/rspack.config.js
@pkg-pr-new
pkg-pr-newBot
commented
Apr 22, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8378

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8378

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8378

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8378

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8378

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8378

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8378

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8378

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8378

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8378

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8378

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8378

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8378

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8378

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8378

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8378

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8378

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8378

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8378

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8378

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8378

commit: 615940c
@wobsoriano
wobsoriano
merged commit 7a423d6
into
mainApr 22, 2026

44 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-rspack-versions

branch
April 22, 2026 16:59
@jacekradkojacekradko
mentioned this pull request
Apr 22, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko