Uh oh!
There was an error while loading. Please reload this page.
experiment: revert rspack 1.7.x pin to test e2e impact - #8425
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis change migrates rspack dependency management from a centralized pnpm workspace catalog to explicit semver version ranges in individual package.json files. The Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 2/5 reviews remaining, refill in 24 minutes and 40 seconds. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/package.json (1)
104-116:⚠️ Potential issue | 🔴 CriticalRestore
@rspack/plugin-react-refreshin devDependencies.
packages/clerk-js/rspack.config.jsdirectly requires@rspack/plugin-react-refresh, but it's not declared in this package'sdevDependencies. This will cause build failures when the dependency resolution changes. Add it to match the pattern inpackages/ui/package.json, which correctly declares it as"@rspack/plugin-react-refresh": "^1.6.2".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/clerk-js/package.json` around lines 104 - 116, The package is missing the devDependency referenced by rspack.config.js: add "@rspack/plugin-react-refresh" to the "devDependencies" object in this package.json (matching the pattern used in packages/ui) with version "^1.6.2" so require('@rspack/plugin-react-refresh') resolves; update the devDependencies entry and reinstall dev deps (npm/yarn/pnpm install) to prevent build failures when dependency resolution changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/package.json`:
- Around line 104-116: The package is missing the devDependency referenced by
rspack.config.js: add "@rspack/plugin-react-refresh" to the "devDependencies"
object in this package.json (matching the pattern used in packages/ui) with
version "^1.6.2" so require('@rspack/plugin-react-refresh') resolves; update the
devDependencies entry and reinstall dev deps (npm/yarn/pnpm install) to prevent
build failures when dependency resolution changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: e7cc7f7e-8f98-4691-aa2b-7e3df82f6170
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
packages/clerk-js/package.jsonpackages/clerk-js/rspack.config.jspackages/ui/package.jsonpackages/ui/rspack.config.jspnpm-workspace.yaml
💤 Files with no reviewable changes (3)
- packages/ui/rspack.config.js
- packages/clerk-js/rspack.config.js
- pnpm-workspace.yaml
jacekradko
commented
Apr 30, 2026
Closing — user clarified that #8378 (pin rspack 1.7.x + disable lazy compilation) was a fix for an earlier rspack regression, not the current one. Will test Rspack 2 upgrade instead in a new experiment. |
Do not merge. Sandbox to verify whether reverting #8378 (pin rspack to 1.7.x and disable lazy compilation) flips the consistently-failing express / hono / generic / nextjs / billing / machine integration suites back to green.
Hypothesis: `disable lazy compilation` + the older rspack pin may produce a chunk graph that takes longer to deliver under heavy CI parallelism, contributing to the userButton mount-timeout failures.
Sibling experiments: #8423 (revert PR 8035 auto-proxy), #8424 (revert PR 8351 Node 24).
Related: #8422 (the actual fix PR currently open).
Will be closed regardless of outcome.