chore(clerk-js,ui): Make OAuthConsent component public - #8381

Merged
wobsoriano merged 19 commits into
mainfrom
rob/oauth-consent-ga
May 1, 2026
Merged

chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom
rob/oauth-consent-ga

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.

Older published SDKs still call:

  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent

When clerk-js is loaded from the CDN, users can end up with:

  • older framework SDK versions
  • newer clerk-js runtime assets

If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.

To avoid that, this PR:

  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility

Follow-up plan

  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am

Request Review

@changeset-bot

changeset-botBot commented Apr 22, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fe96c4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed the rob/oauth-consent-ga branch from b7eb222 to 2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano changed the title chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed the rob/oauth-consent-ga branch from 694e79b to 39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano marked this pull request as ready for review April 29, 2026 16:09
@coderabbitai

coderabbitaiBot commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a

coderabbitai[bot]
coderabbitaiBot reviewed Apr 29, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)

1352-1392: ⚠️ Potential issue | 🟠 Major

Add explicit return type annotations for the new OAuthConsent public API methods.

Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).

Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863

📥 Commits

Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.

📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts

wobsoriano
wobsoriano commented Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos

wobsoriano
wobsoriano commented Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377

alexcarpenter
alexcarpenter reviewed Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue Outdated
Comment on lines +12 to +13
:mount="clerk?.__internal_mountOAuthConsent"
:unmount="clerk?.__internal_unmountOAuthConsent"

@alexcarpenteralexcarpenterApr 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?

@wobsorianowobsorianoApr 30, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄

@wobsorianowobsorianoApr 30, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@wobsoriano
wobsoriano enabled auto-merge (squash) May 1, 2026 02:42
@wobsoriano
wobsoriano merged commit 244920d into mainMay 1, 2026
73 of 74 checks passed
@wobsoriano
wobsoriano deleted the rob/oauth-consent-ga branch May 1, 2026 02:45
@clerk-cookieclerk-cookie mentioned this pull request May 1, 2026
Merged
@wobsorianowobsoriano mentioned this pull request May 20, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees

No one assigned

Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(clerk-js,ui): Make OAuthConsent component public - #8381
Merged
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
May 1, 2026
Merged
chore(clerk-js,ui): Make OAuthConsent component public#8381
wobsoriano merged 19 commits into
mainfrom 
rob/oauth-consent-ga
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
This PR makes OAuthConsent publicly available across SDKs and keeps the legacy __internal_*OAuthConsent runtime methods in place for compatibility.
Older published SDKs still call:
  • clerk.__internal_mountOAuthConsent
  • clerk.__internal_unmountOAuthConsent
When clerk-js is loaded from the CDN, users can end up with:
  • older framework SDK versions
  • newer clerk-js runtime assets
If we remove the legacy runtime methods now, those mixed-version deployments break at runtime with ... is not a function.
To avoid that, this PR:
  • keeps mountOAuthConsent / unmountOAuthConsent as the canonical API
  • preserves __internal_mountOAuthConsent / __internal_unmountOAuthConsent as deprecated aliases
  • updates SDKs as needed while maintaining backward compatibility
Follow-up plan
  • SDKs can continue migrating to mountOAuthConsent / unmountOAuthConsent
  • __internal_*OAuthConsent can be removed in a later major once we intentionally drop compatibility with older published wrappers
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
@vercel
vercelBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxSkippedSkippedMay 1, 2026 2:29am
Request Review
@changeset-bot
changeset-botBot
commented
Apr 22, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: fe96c4a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/nuxtMinor
@clerk/vueMinor
@clerk/astroMinor
@clerk/clerk-jsMinor
@clerk/nextjsMinor
@clerk/reactMinor
@clerk/react-routerMinor
@clerk/sharedMinor
@clerk/tanstack-react-startMinor
@clerk/uiMinor
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@wobsoriano
feat: promote OAuthConsent to public API across all SDKs
2c33684
- Rename __internal_OAuthConsentProps to OAuthConsentProps in @clerk/shared
- Rename __internal_mountOAuthConsent / __internal_unmountOAuthConsent to
mountOAuthConsent / unmountOAuthConsent on the Clerk interface and clerk-js
- Add OAuthConsent and useOAuthConsent to the public exports of @clerk/react,
@clerk/nextjs, @clerk/vue, @clerk/nuxt, and @clerk/astro
- Add @deprecated JSDoc to the existing /internal re-exports in @clerk/react
and @clerk/nextjs pointing consumers to the public paths
- Update @clerk/ui type references to the renamed public types
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
b7eb222 to
2c33684CompareApril 22, 2026 18:06
@wobsorianowobsoriano
changed the title
chore(clerk-js,ui): Move OAuthConsent component to public exportchore(clerk-js,ui): Make OAuthConsent component publicApr 22, 2026
@wobsoriano
wobsorianoforce-pushed
the
rob/oauth-consent-ga
branch
from
694e79b to
39afe25CompareApril 22, 2026 18:28
@wobsoriano
wobsoriano
marked this pull request as ready for review
April 29, 2026 16:09
@coderabbitai
coderabbitaiBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new OAuthConsent UI component and useOAuthConsent hook as public APIs across multiple SDKs (Astro, React, Next.js, Nuxt, Vue, React Router, TanStack React Start). Introduces framework-specific wrapper components, updates export barrels and re-exports, expands InternalUIComponentId/type unions to include 'oauth-consent', and promotes internal mount/unmount methods to public mountOAuthConsent/unmountOAuthConsent while retaining deprecated internal wrappers.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: making the OAuthConsent component public across SDKs, which is the primary objective of the PR.
Description check✅ PassedThe description is clearly related to the changeset, detailing the rationale for maintaining backward compatibility with legacy runtime methods while exposing OAuthConsent as a public API.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8381

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8381

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8381

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8381

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8381

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8381

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8381

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8381

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8381

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8381

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8381

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8381

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8381

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8381

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8381

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8381

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8381

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8381

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8381

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8381

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8381

commit: fe96c4a
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 29, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/clerk-js/src/core/clerk.ts (1)
1352-1392: ⚠️ Potential issue | 🟠 Major
Add explicit return type annotations for the new OAuthConsent public API methods.
Lines 1352, 1376, 1383, and 1390 define public methods without explicit return types. Public APIs in this repository must include explicit return type annotations (: void in this case).
Suggested fix
- public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps) => {+ public mountOAuthConsent = (node: HTMLDivElement, props?: OAuthConsentProps): void => {
@@
- public unmountOAuthConsent = (node: HTMLDivElement) => {+ public unmountOAuthConsent = (node: HTMLDivElement): void => {
@@
- public __internal_mountOAuthConsent = (node: HTMLDivElement, props?: __internal_OAuthConsentProps) => {+ public __internal_mountOAuthConsent = (+ node: HTMLDivElement,+ props?: __internal_OAuthConsentProps,+ ): void => {
@@
- public __internal_unmountOAuthConsent = (node: HTMLDivElement) => {+ public __internal_unmountOAuthConsent = (node: HTMLDivElement): void => {
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/clerk-js/src/core/clerk.ts` around lines 1352 - 1392, The four
public methods mountOAuthConsent, unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent lack explicit
return type annotations; update their function signatures to include an explicit
": void" return type (e.g., change "public mountOAuthConsent = (node:
HTMLDivElement, props?: OAuthConsentProps)" to "public mountOAuthConsent =
(node: HTMLDivElement, props?: OAuthConsentProps): void"), and do the same for
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent so the public API has explicit void return types.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/clerk-js/src/core/clerk.ts`:
- Around line 1352-1392: The four public methods mountOAuthConsent,
unmountOAuthConsent, __internal_mountOAuthConsent, and
__internal_unmountOAuthConsent lack explicit return type annotations; update
their function signatures to include an explicit ": void" return type (e.g.,
change "public mountOAuthConsent = (node: HTMLDivElement, props?:
OAuthConsentProps)" to "public mountOAuthConsent = (node: HTMLDivElement,
props?: OAuthConsentProps): void"), and do the same for unmountOAuthConsent,
__internal_mountOAuthConsent, and __internal_unmountOAuthConsent so the public
API has explicit void return types.

ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7fec644c-ae08-448a-a0e5-df62849dd863
📥 Commits
Reviewing files that changed from the base of the PR and between 5adabce and 0f340a8.
📒 Files selected for processing (6)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/clerk-js/src/core/clerk.ts
  • packages/shared/src/types/clerk.ts
  • packages/vue/src/components/ui-components/OAuthConsent.vue
✅ Files skipped from review due to trivial changes (2)
  • packages/astro/src/astro-components/interactive/OAuthConsent.astro
  • packages/vue/src/components/ui-components/OAuthConsent.vue
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/astro/src/internal/mount-clerk-astro-js-components.ts
  • packages/astro/src/react/uiComponents.tsx
  • packages/shared/src/types/clerk.ts
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/tanstack-react-start/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's safe just to remove this /internal export that was added just for OAuthConsent. Never used in any of our repos
wobsoriano
wobsoriano
commented
Apr 29, 2026
View reviewed changes
Comment threadpackages/react-router/src/internal.ts
Outdated

@wobsorianowobsorianoApr 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/8381/changes#r3164755377
alexcarpenter
alexcarpenter
reviewed
Apr 30, 2026
View reviewed changes
Comment threadpackages/vue/src/components/ui-components/OAuthConsent.vue
Outdated


Comment on lines

+12
 to 
+13

 :mount="clerk?.__internal_mountOAuthConsent"
 :unmount="clerk?.__internal_unmountOAuthConsent"
@alexcarpenteralexcarpenterApr 30, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any of these new components should likely be using the mountOAuthConsent or unmountOAuthConsent vs deprecated __internal methods right?
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch 😄
@wobsorianowobsorianoApr 30, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!
@wobsoriano
wobsoriano
enabled auto-merge (squash)
May 1, 2026 02:42
@wobsoriano
wobsoriano
merged commit 244920d
into
mainMay 1, 2026

73 of 74 checks passed

@wobsoriano
wobsoriano
deleted the

rob/oauth-consent-ga

branch
May 1, 2026 02:45
@clerk-cookieclerk-cookie
mentioned this pull request
May 1, 2026
 Merged

@wobsorianowobsoriano
mentioned this pull request
May 20, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

astroclerk-jsnextjsnuxtreactreact-routertanstackuivue

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@alexcarpenter@jacekradko