Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 469
chore(clerk-js,ui): Make OAuthConsent component public#8381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
69dac722c33684c7c79fa39afe255adabce0f340a8b660e283b8d7bf24a419fbf70ca27dd33d6d0245bf23cdb6954475bd82c74ac058b4747f6f1deb4030c7fe96c4aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| "@clerk/nuxt": minor | ||
| "@clerk/vue": minor | ||
| --- | ||
| Expose `OAuthConsent` as a public component export for Vue and Nuxt. | ||
| Example: | ||
| ```vue | ||
| <script setup lang="ts"> | ||
| import { OAuthConsent } from '@clerk/vue'; | ||
| </script> | ||
| <template> | ||
| <OAuthConsent /> | ||
| </template> | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| "@clerk/astro": minor | ||
| --- | ||
| Expose `OAuthConsent` as a public component export for Astro. | ||
| Example: | ||
| ```astro | ||
| --- | ||
| import { OAuthConsent } from '@clerk/astro/components'; | ||
| --- | ||
| <OAuthConsent /> | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| "@clerk/clerk-js": minor | ||
| "@clerk/nextjs": minor | ||
| "@clerk/react": minor | ||
| "@clerk/react-router": minor | ||
| "@clerk/shared": minor | ||
| "@clerk/tanstack-react-start": minor | ||
| "@clerk/ui": minor | ||
| --- | ||
| Expose `OAuthConsent` as a public component export across React-based SDKs. | ||
| Example: | ||
| ```tsx | ||
| import { OAuthConsent } from '@clerk/react'; | ||
| export default function Page() { | ||
| return <OAuthConsent />; | ||
| } | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| import type { OAuthConsentProps } from '@clerk/shared/types'; | ||
| type Props = OAuthConsentProps; | ||
| import InternalUIComponentRenderer from './InternalUIComponentRenderer.astro'; | ||
| --- | ||
| <InternalUIComponentRenderer | ||
| {...Astro.props} | ||
| component='oauth-consent' | ||
| /> |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: clerk/javascript
Length of output: 403
Add explicit return type annotations to the new public OAuth consent methods.
Lines 1302 and 1306 introduce public API methods without explicit return type annotations. Declare
: voidto match existing methods in the same file (mountAPIKeys,unmountAPIKeys) and comply with the guideline requiring explicit return types for public APIs.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents