Skip to content

test(expo): Stabilize native client sync echo tests - #9033

Merged
wobsoriano merged 2 commits into
mainfrom
rob/expo-flaky-test
Jun 29, 2026
Merged

test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom
rob/expo-flaky-test

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 29, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013

Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.

This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.

@changeset-bot

changeset-botBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e0ba251

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5

📥 Commits

Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.

📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough

Walkthrough

Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.

Changes

Native Client Sync Test Mock Fixes

Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • mikepitre

🐇 Two tiny lines of null,
A mock pinned down with care,
The token returns nothing at all—
And tests run true and fair!
Hop hop, the rabbit cheers! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

wobsoriano
wobsoriano commented Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
});

test('does not bounce a JS client listener event while applying a native client change', async () => {
mocks.getClientToken.mockResolvedValue(null);

@wobsorianowobsorianoJun 29, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery

wobsoriano
wobsoriano commented Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

test('ignores native client events that echo a JS-originated sync', async () => {
mocks.tokenCache.getToken.mockResolvedValue(null);
mocks.getClientToken.mockResolvedValue(null);

@wobsorianowobsorianoJun 29, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276

@github-actions

github-actionsBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-29T18:11:54.921Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on e0ba251.

@pkg-pr-new

pkg-pr-newBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251

@wobsoriano
wobsoriano merged commit d079c67 into mainJun 29, 2026
58 checks passed
@wobsoriano
wobsoriano deleted the rob/expo-flaky-test branch June 29, 2026 18:30
@coderabbitaicoderabbitaiBot mentioned this pull request Jun 29, 2026
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees

No one assigned

Labels

expo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test(expo): Stabilize native client sync echo tests by wobsoriano · Pull Request #9033 · clerk/javascript · GitHub
Skip to content
test(expo): Stabilize native client sync echo tests - #9033
Merged
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Jun 29, 2026
Merged
test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013
Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.
This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e0ba251
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5
📥 Commits
Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.
📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough
Walkthrough
Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.
Changes
Native Client Sync Test Mock Fixes
Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
  • mikepitre
🐇 Two tiny lines of null,

A mock pinned down with care,

The token returns nothing at all—

And tests run true and fair!

Hop hop, the rabbit cheers! 🎉
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
 });

 test('does not bounce a JS client listener event while applying a native client change', async () => {
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

 test('ignores native client events that echo a JS-originated sync', async () => {
 mocks.tokenCache.getToken.mockResolvedValue(null);
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276
@github-actions
github-actionsBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T18:11:54.921Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on e0ba251.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251
@wobsoriano
wobsoriano
merged commit d079c67
into
mainJun 29, 2026

58 checks passed

@wobsoriano
wobsoriano
deleted the

rob/expo-flaky-test

branch
June 29, 2026 18:30
@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 29, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Stabilize native client sync echo tests by wobsoriano · Pull Request #9033 · clerk/javascript · GitHub
Skip to content
test(expo): Stabilize native client sync echo tests - #9033
Merged
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Jun 29, 2026
Merged
test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013
Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.
This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e0ba251
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5
📥 Commits
Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.
📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough
Walkthrough
Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.
Changes
Native Client Sync Test Mock Fixes
Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
  • mikepitre
🐇 Two tiny lines of null,

A mock pinned down with care,

The token returns nothing at all—

And tests run true and fair!

Hop hop, the rabbit cheers! 🎉
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
 });

 test('does not bounce a JS client listener event while applying a native client change', async () => {
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

 test('ignores native client events that echo a JS-originated sync', async () => {
 mocks.tokenCache.getToken.mockResolvedValue(null);
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276
@github-actions
github-actionsBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T18:11:54.921Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on e0ba251.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251
@wobsoriano
wobsoriano
merged commit d079c67
into
mainJun 29, 2026

58 checks passed

@wobsoriano
wobsoriano
deleted the

rob/expo-flaky-test

branch
June 29, 2026 18:30
@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 29, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Stabilize native client sync echo tests by wobsoriano · Pull Request #9033 · clerk/javascript · GitHub
Skip to content
test(expo): Stabilize native client sync echo tests - #9033
Merged
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Jun 29, 2026
Merged
test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013
Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.
This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e0ba251
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5
📥 Commits
Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.
📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough
Walkthrough
Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.
Changes
Native Client Sync Test Mock Fixes
Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
  • mikepitre
🐇 Two tiny lines of null,

A mock pinned down with care,

The token returns nothing at all—

And tests run true and fair!

Hop hop, the rabbit cheers! 🎉
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
 });

 test('does not bounce a JS client listener event while applying a native client change', async () => {
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

 test('ignores native client events that echo a JS-originated sync', async () => {
 mocks.tokenCache.getToken.mockResolvedValue(null);
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276
@github-actions
github-actionsBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T18:11:54.921Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on e0ba251.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251
@wobsoriano
wobsoriano
merged commit d079c67
into
mainJun 29, 2026

58 checks passed

@wobsoriano
wobsoriano
deleted the

rob/expo-flaky-test

branch
June 29, 2026 18:30
@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 29, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
test(expo): Stabilize native client sync echo tests by wobsoriano · Pull Request #9033 · clerk/javascript · GitHub
Skip to content
test(expo): Stabilize native client sync echo tests - #9033
Merged
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Jun 29, 2026
Merged
test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013
Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.
This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e0ba251
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5
📥 Commits
Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.
📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough
Walkthrough
Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.
Changes
Native Client Sync Test Mock Fixes
Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
  • mikepitre
🐇 Two tiny lines of null,

A mock pinned down with care,

The token returns nothing at all—

And tests run true and fair!

Hop hop, the rabbit cheers! 🎉
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
 });

 test('does not bounce a JS client listener event while applying a native client change', async () => {
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

 test('ignores native client events that echo a JS-originated sync', async () => {
 mocks.tokenCache.getToken.mockResolvedValue(null);
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276
@github-actions
github-actionsBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T18:11:54.921Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on e0ba251.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251
@wobsoriano
wobsoriano
merged commit d079c67
into
mainJun 29, 2026

58 checks passed

@wobsoriano
wobsoriano
deleted the

rob/expo-flaky-test

branch
June 29, 2026 18:30
@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 29, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Stabilize native client sync echo tests by wobsoriano · Pull Request #9033 · clerk/javascript · GitHub
Skip to content
test(expo): Stabilize native client sync echo tests - #9033
Merged
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Jun 29, 2026
Merged
test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013
Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.
This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e0ba251
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5
📥 Commits
Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.
📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough
Walkthrough
Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.
Changes
Native Client Sync Test Mock Fixes
Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
  • mikepitre
🐇 Two tiny lines of null,

A mock pinned down with care,

The token returns nothing at all—

And tests run true and fair!

Hop hop, the rabbit cheers! 🎉
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
 });

 test('does not bounce a JS client listener event while applying a native client change', async () => {
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

 test('ignores native client events that echo a JS-originated sync', async () => {
 mocks.tokenCache.getToken.mockResolvedValue(null);
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276
@github-actions
github-actionsBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T18:11:54.921Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on e0ba251.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251
@wobsoriano
wobsoriano
merged commit d079c67
into
mainJun 29, 2026

58 checks passed

@wobsoriano
wobsoriano
deleted the

rob/expo-flaky-test

branch
June 29, 2026 18:30
@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 29, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
test(expo): Stabilize native client sync echo tests by wobsoriano · Pull Request #9033 · clerk/javascript · GitHub
Skip to content
test(expo): Stabilize native client sync echo tests - #9033
Merged
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Jun 29, 2026
Merged
test(expo): Stabilize native client sync echo tests#9033
wobsoriano merged 2 commits into
mainfrom 
rob/expo-flaky-test
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes a flaky test https://github.com/clerk/javascript/actions/runs/28389497839/job/84113032877?pr=9013
Stabilizes two Expo native client sync tests by preventing unrelated bootstrap native-token reloads from racing with the behavior under test.
This is the same class of flake fixed in #9016: tests were waiting for native configure, but bootstrap can still continue asynchronously and trigger JS reload/sync work afterward.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test scenarios to explicitly return a null client token during setup.
    • Improves test stability and ensures the cases exercise the intended JS/native sync behavior.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e0ba251
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 6:11pm
swingsetReadyReadyPreview, CommentJun 29, 2026 6:11pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f7e39e6a-ee90-4cb4-8631-2df5589b61d5
📥 Commits
Reviewing files that changed from the base of the PR and between 7926377 and e0ba251.
📒 Files selected for processing (1)
  • .changeset/lucky-hotels-rush.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lucky-hotels-rush.md
📝 Walkthrough
Walkthrough
Two native client sync tests now mock getClientToken to resolve to null before rendering, and a new changeset file was added.
Changes
Native Client Sync Test Mock Fixes
Layer / File(s)Summary
Set native token mock to null
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		Adds mocks.getClientToken resolving to null in the JS client listener bounce test and the JS-originated sync echo test.
Add changeset file
.changeset/lucky-hotels-rush.md		Adds a new two-line changeset markdown file.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
  • mikepitre
🐇 Two tiny lines of null,

A mock pinned down with care,

The token returns nothing at all—

And tests run true and fair!

Hop hop, the rabbit cheers! 🎉
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title is concise and accurately describes the main change: stabilizing Expo native client sync echo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Comment @coderabbitai help to get the list of available commands.
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
 });

 test('does not bounce a JS client listener event while applying a native client change', async () => {
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting to null since they do not depend on bootstrap native-token recovery
wobsoriano
wobsoriano
commented
Jun 29, 2026
View reviewed changes
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

 test('ignores native client events that echo a JS-originated sync', async () => {
 mocks.tokenCache.getToken.mockResolvedValue(null);
 mocks.getClientToken.mockResolvedValue(null);
@wobsorianowobsorianoJun 29, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto https://github.com/clerk/javascript/pull/9033/changes#r3493743276
@github-actions
github-actionsBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T18:11:54.921Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on e0ba251.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9033

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9033

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9033

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9033

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9033

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9033

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9033

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9033

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9033

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9033

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9033

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9033

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9033

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9033

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9033

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9033

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9033

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9033

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9033

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9033

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9033

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9033

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9033

commit: e0ba251
@wobsoriano
wobsoriano
merged commit d079c67
into
mainJun 29, 2026

58 checks passed

@wobsoriano
wobsoriano
deleted the

rob/expo-flaky-test

branch
June 29, 2026 18:30
@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 29, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mikepitremikepitremikepitre approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@mikepitre