Skip to content

test(expo): Isolate native token bootstrap in sync tests - #9039

Merged
wobsoriano merged 1 commit into
mainfrom
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged

test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom
rob/fix-flaky-expo-test-part-2

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 29, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.

This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests

    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.

  • Chores

    • Added a new changeset entry for release tracking.

@changeset-bot

changeset-botBot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aad955c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: bcf6e305-45fd-44ac-b295-183104535425

📥 Commits

Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.

📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough

Walkthrough

The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.

Native-client sync test mock consolidation

Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.

Suggested reviewers

  • mikepitre

🐇 Null is the default, no need to repeat,
Ten mock overrides gone — how neat!
The beforeEach sets the tone,
Each test need not moan alone.
Less code, same truth — a bunny feat! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c

@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-29T23:21:07.365Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on aad955c.

@wobsoriano
wobsoriano merged commit e9a09f8 into mainJun 30, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-flaky-expo-test-part-2 branch June 30, 2026 03:21
@wobsorianowobsoriano mentioned this pull request Jun 30, 2026
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees

No one assigned

Labels

expo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test(expo): Isolate native token bootstrap in sync tests by wobsoriano · Pull Request #9039 · clerk/javascript · GitHub
Skip to content
test(expo): Isolate native token bootstrap in sync tests - #9039
Merged
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged
test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.
This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores
    • Added a new changeset entry for release tracking.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: aad955c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: bcf6e305-45fd-44ac-b295-183104535425
📥 Commits
Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.
📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough
Walkthrough
The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.
Native-client sync test mock consolidation
Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.
Suggested reviewers
  • mikepitre
🐇 Null is the default, no need to repeat,

Ten mock overrides gone — how neat!

The beforeEach sets the tone,

Each test need not moan alone.

Less code, same truth — a bunny feat! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c
@github-actions
github-actionsBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T23:21:07.365Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on aad955c.
@wobsoriano
wobsoriano
merged commit e9a09f8
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-2

branch
June 30, 2026 03:21
@wobsorianowobsoriano
mentioned this pull request
Jun 30, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Isolate native token bootstrap in sync tests by wobsoriano · Pull Request #9039 · clerk/javascript · GitHub
Skip to content
test(expo): Isolate native token bootstrap in sync tests - #9039
Merged
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged
test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.
This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores
    • Added a new changeset entry for release tracking.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: aad955c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: bcf6e305-45fd-44ac-b295-183104535425
📥 Commits
Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.
📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough
Walkthrough
The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.
Native-client sync test mock consolidation
Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.
Suggested reviewers
  • mikepitre
🐇 Null is the default, no need to repeat,

Ten mock overrides gone — how neat!

The beforeEach sets the tone,

Each test need not moan alone.

Less code, same truth — a bunny feat! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c
@github-actions
github-actionsBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T23:21:07.365Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on aad955c.
@wobsoriano
wobsoriano
merged commit e9a09f8
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-2

branch
June 30, 2026 03:21
@wobsorianowobsoriano
mentioned this pull request
Jun 30, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Isolate native token bootstrap in sync tests by wobsoriano · Pull Request #9039 · clerk/javascript · GitHub
Skip to content
test(expo): Isolate native token bootstrap in sync tests - #9039
Merged
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged
test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.
This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores
    • Added a new changeset entry for release tracking.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: aad955c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: bcf6e305-45fd-44ac-b295-183104535425
📥 Commits
Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.
📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough
Walkthrough
The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.
Native-client sync test mock consolidation
Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.
Suggested reviewers
  • mikepitre
🐇 Null is the default, no need to repeat,

Ten mock overrides gone — how neat!

The beforeEach sets the tone,

Each test need not moan alone.

Less code, same truth — a bunny feat! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c
@github-actions
github-actionsBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T23:21:07.365Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on aad955c.
@wobsoriano
wobsoriano
merged commit e9a09f8
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-2

branch
June 30, 2026 03:21
@wobsorianowobsoriano
mentioned this pull request
Jun 30, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
test(expo): Isolate native token bootstrap in sync tests by wobsoriano · Pull Request #9039 · clerk/javascript · GitHub
Skip to content
test(expo): Isolate native token bootstrap in sync tests - #9039
Merged
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged
test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.
This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores
    • Added a new changeset entry for release tracking.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: aad955c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: bcf6e305-45fd-44ac-b295-183104535425
📥 Commits
Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.
📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough
Walkthrough
The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.
Native-client sync test mock consolidation
Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.
Suggested reviewers
  • mikepitre
🐇 Null is the default, no need to repeat,

Ten mock overrides gone — how neat!

The beforeEach sets the tone,

Each test need not moan alone.

Less code, same truth — a bunny feat! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c
@github-actions
github-actionsBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T23:21:07.365Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on aad955c.
@wobsoriano
wobsoriano
merged commit e9a09f8
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-2

branch
June 30, 2026 03:21
@wobsorianowobsoriano
mentioned this pull request
Jun 30, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Isolate native token bootstrap in sync tests by wobsoriano · Pull Request #9039 · clerk/javascript · GitHub
Skip to content
test(expo): Isolate native token bootstrap in sync tests - #9039
Merged
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged
test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.
This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores
    • Added a new changeset entry for release tracking.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: aad955c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: bcf6e305-45fd-44ac-b295-183104535425
📥 Commits
Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.
📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough
Walkthrough
The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.
Native-client sync test mock consolidation
Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.
Suggested reviewers
  • mikepitre
🐇 Null is the default, no need to repeat,

Ten mock overrides gone — how neat!

The beforeEach sets the tone,

Each test need not moan alone.

Less code, same truth — a bunny feat! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c
@github-actions
github-actionsBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T23:21:07.365Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on aad955c.
@wobsoriano
wobsoriano
merged commit e9a09f8
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-2

branch
June 30, 2026 03:21
@wobsorianowobsoriano
mentioned this pull request
Jun 30, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
test(expo): Isolate native token bootstrap in sync tests by wobsoriano · Pull Request #9039 · clerk/javascript · GitHub
Skip to content
test(expo): Isolate native token bootstrap in sync tests - #9039
Merged
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Jun 30, 2026
Merged
test(expo): Isolate native token bootstrap in sync tests#9039
wobsoriano merged 1 commit into
mainfrom 
rob/fix-flaky-expo-test-part-2
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 29, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
The native client sync tests in Expo were all starting with getClientToken() returning a device token by default. That meant tests which were trying to verify event handling could also get an unrelated bootstrap token write in the background.
This changes the default mock to return null and keeps the native token setup only in the tests that are actually covering recovery from a native token.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Updated native client sync test coverage to better reflect token-clearing behavior and resource reload flow.
    • Simplified shared test setup and tightened expectations around device token handling.
  • Chores
    • Added a new changeset entry for release tracking.
@changeset-bot
changeset-botBot
commented
Jun 29, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: aad955c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 29, 2026 11:18pm
swingsetReadyReadyPreview, CommentJun 29, 2026 11:18pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 29, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: bcf6e305-45fd-44ac-b295-183104535425
📥 Commits
Reviewing files that changed from the base of the PR and between 07e1b06 and aad955c.
📒 Files selected for processing (2)
  • .changeset/stable-expo-native-sync-tests.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
📝 Walkthrough
Walkthrough
The suite-level beforeEach default for mocks.getClientToken is changed from 'native-client-token' to null, removing the need for per-test mockResolvedValue(null) overrides across ten tests. One waitFor assertion for __internal_reloadInitialResources is removed and mocks.tokenCache.getToken is explicitly set to null in one test. A changeset file is added.
Native-client sync test mock consolidation
Layer / File(s)Summary
Shared default and per-test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx, .changeset/stable-expo-native-sync-tests.md		beforeEach now resolves getClientToken to null; ten individual tests drop their redundant mockResolvedValue(null) lines. In the "native clears the device token" test, tokenCache.getToken is explicitly nulled and the waitFor(__internal_reloadInitialResources) assertion is removed. Changeset entry added.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
  • clerk/javascript#9016: Modifies the same "reloads JS resources after native clears the device token" test around __internal_reloadInitialResources and deviceToken: null handling.
  • clerk/javascript#9033: Adjusts the same suite's mocks.getClientToken defaults and overrides in the native-client sync echo test scenarios.
  • clerk/javascript#8929: Introduces the syncClientStateFromJs contract that the test mock shapes in this PR are aligned against.
Suggested reviewers
  • mikepitre
🐇 Null is the default, no need to repeat,

Ten mock overrides gone — how neat!

The beforeEach sets the tone,

Each test need not moan alone.

Less code, same truth — a bunny feat! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly describes the main change: isolating native token bootstrap behavior in sync tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9039

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9039

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9039

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9039

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9039

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9039

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9039

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9039

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9039

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9039

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9039

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9039

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9039

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9039

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9039

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9039

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9039

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9039

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9039

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9039

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9039

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9039

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9039

commit: aad955c
@github-actions
github-actionsBot
commented
Jun 29, 2026

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-29T23:21:07.365Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on aad955c.
@wobsoriano
wobsoriano
merged commit e9a09f8
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-2

branch
June 30, 2026 03:21
@wobsorianowobsoriano
mentioned this pull request
Jun 30, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@alexcarpenter