Skip to content

test(expo): Gate native sync bootstrap behind load state - #9048

Merged
wobsoriano merged 4 commits into
mainfrom
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged

test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom
rob/fix-flaky-expo-test-part-3

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.

Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.

@vercel

vercelBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm

Request Review

@changeset-bot

changeset-botBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 42564ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.

Native-client sync test harness

Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.

Changes

Native-client sync test harness

Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.

Suggested reviewers

  • alexcarpenter

🐇 A token waits in native land,
Till loaded flips by test's hand.
saveToken called, resources reload,
Bootstrap sync — the path is showed!
Hops of green on every run! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-newBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce

@github-actions

github-actionsBot commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-30T18:29:32.116Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on 42564ce.

coderabbitai[bot]
coderabbitaiBot reviewed Jun 30, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: be837a02-c514-43fd-ac29-4e707892495e

📥 Commits

Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.

📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx

Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed the rob/fix-flaky-expo-test-part-3 branch from d4621fa to 6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano merged commit 268701c into mainJun 30, 2026
59 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-flaky-expo-test-part-3 branch June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees

No one assigned

Labels

expo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
test(expo): Gate native sync bootstrap behind load state by wobsoriano · Pull Request #9048 · clerk/javascript · GitHub
Skip to content
test(expo): Gate native sync bootstrap behind load state - #9048
Merged
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Jun 30, 2026
Merged
test(expo): Gate native sync bootstrap behind load state#9048
wobsoriano merged 4 commits into
mainfrom 
rob/fix-flaky-expo-test-part-3
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
PR #9039 was the right first step: remove the ambient native token from every test. But it did not fully isolate the bootstrap path, because the mocked Clerk instance was still loaded: true by default. In production, bootstrap only runs the native-to-JS sync after Clerk loads. With loaded: true in every test, each render could still start a background getClientToken() poll.
Fixes this flaky test in the android version bump PR https://github.com/clerk/javascript/actions/runs/28479174701/job/84411440692?pr=9053
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Tests
    • Improved native Clerk provider sync tests by tightening mocked bootstrap and device-token behavior.
    • Added coverage to confirm the device token is persisted after loading completes and that initial resource reloading is triggered.
    • Strengthened the device token change test expectations to better reflect the updated flow.
  • Chores
    • Added a changeset entry to track this update.
@vercel
vercelBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 30, 2026 6:28pm
swingsetReadyReadyPreview, CommentJun 30, 2026 6:28pm
Request Review
@changeset-bot
changeset-botBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 42564ce
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@coderabbitai
coderabbitaiBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
Updates the ClerkProvider native-client sync test suite: the clerkInstance mock now starts with loaded: false and exposes addOnLoaded; beforeEach captures registered callbacks for manual triggering. A new test asserts that on bootstrap, the native device token is synced to tokenCache via saveToken and __internal_reloadInitialResources is called. A changeset entry is added.
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Changes
Native-client sync test harness
Layer / File(s)Summary
Mock shape and beforeEach initialization
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		clerkInstance mock gains addOnLoaded and initializes with loaded: false; beforeEach resets tokenCache.getToken to resolve null and captures both addOnLoaded and addListener callbacks into mocks.clerkOnLoaded / mocks.clerkListener.
New bootstrap token-sync test and existing test cleanup
packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx		New test triggers clerkOnLoaded callback after setting loaded: true and asserts tokenCache.saveToken(CLERK_CLIENT_JWT_KEY, ...) and __internal_reloadInitialResources are called; removes redundant getToken reset, mockClear, and getClientToken assertion from the "native emits a device token change" test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
  • clerk/javascript#9039: Directly modifies the same ClerkProvider.nativeClientSync.test.tsx test mocks, adjusting tokenCache and getClientToken initialization and load/sync expectations.
Suggested reviewers
  • alexcarpenter
🐇 A token waits in native land,

Till loaded flips by test's hand.
saveToken called, resources reload,

Bootstrap sync — the path is showed!

Hops of green on every run! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly matches the main change: gating native sync bootstrap on Clerk's load state in Expo tests.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands.
@pkg-pr-new
pkg-pr-newBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9048

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9048

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9048

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9048

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9048

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9048

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9048

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9048

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9048

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9048

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9048

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9048

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9048

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9048

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9048

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9048

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9048

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9048

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9048

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9048

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9048

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9048

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9048

commit: 42564ce
@github-actions
github-actionsBot
commented
Jun 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-30T18:29:32.116Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 42564ce.
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 30, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx`:
- Around line 175-199: The test in ClerkProvider.nativeClientSync.test.tsx only
verifies the post-load sync path and can miss an early bootstrap fetch, so
harden it by asserting bootstrap stays idle before the captured addOnLoaded
callback fires. Use the existing mocks around ClerkProvider,
mocks.getClientToken, and mocks.clerkOnLoaded to add a negative expectation
before triggering loaded state, then keep the existing post-load assertions to
confirm the token is fetched and saved only after Clerk finishes loading.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: be837a02-c514-43fd-ac29-4e707892495e
📥 Commits
Reviewing files that changed from the base of the PR and between 4306146 and d4621fa.
📒 Files selected for processing (2)
  • .changeset/two-pumas-occur.md
  • packages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
Comment threadpackages/expo/src/provider/__tests__/ClerkProvider.nativeClientSync.test.tsx
@wobsoriano
wobsorianoforce-pushed
the
rob/fix-flaky-expo-test-part-3
branch
from
d4621fa to
6373fdaCompareJune 30, 2026 18:07
@wobsoriano
wobsoriano
merged commit 268701c
into
mainJun 30, 2026

59 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-flaky-expo-test-part-3

branch
June 30, 2026 23:12
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@seanperez29seanperez29seanperez29 approved these changes
@swolfandswolfandAwaiting requested review from swolfand

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@seanperez29