feat(shared): add internal directory sync react-query hooks - #9591

Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom
jim/dir-sync-2-hooks
Open

feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom
jim/dir-sync-2-hooks

Conversation

@kalafut

@kalafutkalafut commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown

Description

Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.

Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

✎

@changeset-bot

changeset-botBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6b53c5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercelBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC

Request Review

@kalafutkalafut changed the title feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 9525da1 to 2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new

pkg-pr-newBot commented Aug 28, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d

@github-actions

github-actionsBot commented Aug 28, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-02T22:52:30.900Z

Summary

MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4

@clerk/shared

Current version: 4.31.0
Recommended bump: MINOR → 4.32.0

Subpath ./react

🟢 Additions (4)

Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };

Added type alias UseOrganizationDirectorySyncParams

Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };

Added type alias UseOrganizationDirectorySyncReturn

Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };

Added type alias UseOrganizationDirectorySyncUsersParams

Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };

Added type alias UseOrganizationDirectorySyncUsersReturn

Report generated by Break Check

Last ran on 6b53c5d.

@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 2291ba0 to 8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 8db31e5 to 875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 875352a to f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from f801038 to 3d18031CompareSeptember 1, 2026 20:23
@coderabbitai

coderabbitaiBot commented Sep 1, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 3d18031 to 4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut requested a review from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7 reviewed Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx Outdated
NicolasLopes7
NicolasLopes7 reviewed Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx Outdated
NicolasLopes7
NicolasLopes7 approved these changes Sep 2, 2026
View reviewed changes

@NicolasLopes7NicolasLopes7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM

@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 4adb710 to 247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 247b096 to 3342ab9CompareSeptember 2, 2026 21:24
kalafutand others added 4 commits September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed the jim/dir-sync-2-hooks branch from 3342ab9 to 6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(shared): add internal directory sync react-query hooks - #9591
Open
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Open
feat(shared): add internal directory sync react-query hooks#9591
kalafut wants to merge 4 commits into
jim/dir-sync-1-resourcefrom 
jim/dir-sync-2-hooks
Conversation
@kalafut
@kalafutkalafut
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Description
Part 2 of 4 of the self-serve Directory Sync stack. Stacked on jim/dir-sync-1-resource. This change depends on the first PR and the stack will be squashed on merge.
Adds the internal react-query hooks __internal_useOrganizationDirectorySync and __internal_useOrganizationDirectorySyncUsers. Mutations go through the loaded DirectorySync resource, so they resolve undefined until the directory has loaded. The users hook takes the directory resource itself and stays dormant while it is nullish; it polls while armed via startPolling, so the wizard's test step doubles as a recent-activity feed.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
✎
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 6b53c5d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated
clerk-js-sandboxReadyReadyPreviewSep 2, 2026 10:47pm UTC
swingsetReadyReadyPreviewSep 2, 2026 10:47pm UTC
Request Review
@kalafutkalafut
changed the title
feat(self-serve-ds): add internal Directory Sync react-query hooksfeat(shared): add internal directory sync react-query hooksAug 27, 2026
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
9525da1 to
2291ba0CompareAugust 28, 2026 22:44
@pkg-pr-new
pkg-pr-newBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@9591

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@9591

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@9591

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@9591

@clerk/electron
npm i https://pkg.pr.new/@clerk/electron@9591

@clerk/electron-passkeys
npm i https://pkg.pr.new/@clerk/electron-passkeys@9591

@clerk/eslint-plugin
npm i https://pkg.pr.new/@clerk/eslint-plugin@9591

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@9591

@clerk/expo-google-signin
npm i https://pkg.pr.new/@clerk/expo-google-signin@9591

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@9591

@clerk/express
npm i https://pkg.pr.new/@clerk/express@9591

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@9591

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@9591

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@9591

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@9591

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@9591

@clerk/react
npm i https://pkg.pr.new/@clerk/react@9591

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@9591

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@9591

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@9591

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@9591

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@9591

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@9591

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@9591

commit: 6b53c5d
@github-actions
github-actionsBot
commented
Aug 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-09-02T22:52:30.900Z
Summary
MetricCount
Packages analyzed19
Packages with changes1
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions4
@clerk/shared
Current version: 4.31.0
Recommended bump: MINOR → 4.32.0
Subpath ./react
🟢 Additions (4)
Added: UseOrganizationDirectorySyncParams
+ type UseOrganizationDirectorySyncParams = {+ enterpriseConnectionId: string | null;+ enabled?: boolean;+ };
Added type alias UseOrganizationDirectorySyncParams
Added: UseOrganizationDirectorySyncReturn
+ type UseOrganizationDirectorySyncReturn = {+ data: DirectorySyncResource | null | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ createDirectorySync: (params?: CreateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>; /** Resolves `undefined` until `data` has loaded, since the mutations act on the loaded directory. */+ updateDirectorySync: (params: UpdateDirectorySyncParams) => Promise<DirectorySyncResource | undefined>;+ rotateDirectorySyncToken: () => Promise<DirectorySyncResource | undefined>;+ deleteDirectorySync: () => Promise<DeletedObjectResource | undefined>;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncReturn
Added: UseOrganizationDirectorySyncUsersParams
+ type UseOrganizationDirectorySyncUsersParams = {+ directory: DirectorySyncResource | null | undefined;+ params?: GetDirectorySyncUsersParams;+ pollIntervalMs?: number;+ enabled?: boolean;+ keepPreviousData?: boolean;+ };
Added type alias UseOrganizationDirectorySyncUsersParams
Added: UseOrganizationDirectorySyncUsersReturn
+ type UseOrganizationDirectorySyncUsersReturn = {+ data: DirectorySyncUserResource[] | undefined;+ totalCount: number | undefined;+ error: Error | null;+ isLoading: boolean;+ isFetching: boolean;+ isPolling: boolean;+ startPolling: () => void;+ stopPolling: () => void;+ revalidate: () => Promise<void>;+ };
Added type alias UseOrganizationDirectorySyncUsersReturn
Report generated by Break Check
Last ran on 6b53c5d.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
2291ba0 to
8db31e5CompareAugust 31, 2026 16:36
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
8db31e5 to
875352aCompareAugust 31, 2026 16:48
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
875352a to
f801038CompareAugust 31, 2026 22:40
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
f801038 to
3d18031CompareSeptember 1, 2026 20:23
@coderabbitai
coderabbitaiBot
commented
Sep 1, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 39f5bceb-4059-4fbc-9e9a-ba8781288dca
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
  •  🔍 Trigger review
Comment @coderabbitai help to get the list of available commands.
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3d18031 to
4adb710CompareSeptember 1, 2026 23:32
@kalafut
kalafut
requested a review
from dstaleySeptember 2, 2026 19:21
NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySyncUsers.tsx
Outdated

NicolasLopes7
NicolasLopes7
reviewed
Sep 2, 2026
View reviewed changes
Comment threadpackages/shared/src/react/hooks/useOrganizationDirectorySync.tsx
Outdated

NicolasLopes7
NicolasLopes7
approved these changes
Sep 2, 2026
View reviewed changes
@NicolasLopes7NicolasLopes7
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got fable looking/running this and had a couple of inline-comments. Other than that I'd suggest tests for the hooks to cover the regressions, otherwise LGTM
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
4adb710 to
247b096CompareSeptember 2, 2026 20:49
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
247b096 to
3342ab9CompareSeptember 2, 2026 21:24
kalafutand others
added 4 commits
September 2, 2026 15:44
@kalafut
feat(self-serve-ds): add internal Directory Sync react-query hooks
580e552
__internal_useOrganizationDirectorySync and
__internal_useOrganizationDirectorySyncUsers; the users hook polls
continuously while enabled so the test step can double as a
recent-activity feed.
@kalafut@claude
feat(self-serve-ds): route Directory Sync hooks through the Directory…
93b5c80
…Sync resource
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U54pszNFtqsBNpQhXaGvaa
@kalafut
Remove placeholder reuse
11403ee
@kalafut
Fix test result polling, and invalidation
6b53c5d
Also add tests
@kalafut
kalafutforce-pushed
the
jim/dir-sync-2-hooks
branch
from
3342ab9 to
6b53c5dCompareSeptember 2, 2026 22:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@NicolasLopes7NicolasLopes7NicolasLopes7 approved these changes
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kalafut@NicolasLopes7