Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { ClerkAPIResponseError } from '@/error';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import { __internal_useOrganizationDirectorySync } from '../useOrganizationDirectorySync';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const directory = { id: 'dir_1', enterpriseConnectionId: 'ent_1' };
const getDirectorySyncSpy = vi.fn((_enterpriseConnectionId: string) => Promise.resolve(directory));

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1', getDirectorySync: getDirectorySyncSpy },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const keysFor = (enterpriseConnectionId: string) =>
createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: true,
tracked: { organizationId: 'org_1', enterpriseConnectionId },
untracked: { args: {} },
});

const renderDirectorySync = (enterpriseConnectionId: string | null = 'ent_1') =>
renderHook(() => __internal_useOrganizationDirectorySync({ enterpriseConnectionId }), { wrapper });

describe('useOrganizationDirectorySync', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('resolves the directory for the connection', async () => {
const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(getDirectorySyncSpy).toHaveBeenCalledWith('ent_1');
expect(result.current.data).toBe(directory);
expect(result.current.error).toBeNull();
});

it('treats a 404 as "no directory yet" and resolves null instead of an error', async () => {
getDirectorySyncSpy.mockRejectedValueOnce(new ClerkAPIResponseError('Not found', { status: 404, data: [] }));

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));

expect(result.current.data).toBeNull();
expect(result.current.error).toBeNull();
});

it('stays dormant without an enterprise connection id', () => {
const { result } = renderDirectorySync(null);

expect(getDirectorySyncSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
});

it('revalidate refetches only this org+connection, leaving other connections cached', async () => {
const { queryKey: otherKey } = keysFor('ent_other');
defaultQueryClient.client.setQueryData(otherKey, { id: 'dir_other', enterpriseConnectionId: 'ent_other' });

const { result } = renderDirectorySync();
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(getDirectorySyncSpy).toHaveBeenCalledTimes(1);

await act(async () => {
await result.current.revalidate();
});

expect(getDirectorySyncSpy).toHaveBeenCalledTimes(2);
expect(defaultQueryClient.client.getQueryState(otherKey)?.isInvalidated).toBe(false);
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { DirectorySyncResource } from '@/types/directorySync';

import type { UseOrganizationDirectorySyncUsersReturn } from '../useOrganizationDirectorySyncUsers';
import { __internal_useOrganizationDirectorySyncUsers } from '../useOrganizationDirectorySyncUsers';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const POLL_INTERVAL_MS = 20;

const getUsersSpy = vi.fn(() => Promise.resolve({ data: [{ id: 'du_1' }], total_count: 1 }));

const createDirectory = (id: string) =>
({ id, enterpriseConnectionId: 'ent_1', getUsers: getUsersSpy }) as unknown as DirectorySyncResource;

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
queryClient: defaultQueryClient,
__internal_lastEmittedResources: {
user: null,
session: null,
organization: { id: 'org_1' },
client: null,
},
});

vi.mock('../../contexts', () => ({
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
useInitialStateContext: () => undefined,
}));

const renderUsers = (initialDirectory: DirectorySyncResource | null) =>
renderHook(
({ directory }: { directory: DirectorySyncResource | null }) =>
__internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS }),
{ wrapper, initialProps: { directory: initialDirectory } },
);

describe('useOrganizationDirectorySyncUsers', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('stays dormant without a directory', () => {
const { result } = renderUsers(null);

expect(getUsersSpy).not.toHaveBeenCalled();
expect(result.current.data).toBeUndefined();
expect(result.current.isPolling).toBe(false);
});

it('polls while armed and stops on stopPolling', async () => {
const { result } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.isPolling).toBe(false);

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));

act(() => result.current.stopPolling());
expect(result.current.isPolling).toBe(false);
});

it('disarms polling when the directory identity changes', async () => {
const { result, rerender } = renderUsers(createDirectory('dir_1'));
await waitFor(() => expect(result.current.isLoading).toBe(false));

act(() => result.current.startPolling());
expect(result.current.isPolling).toBe(true);

rerender({ directory: createDirectory('dir_2') });
expect(result.current.isPolling).toBe(false);
});

it('keeps polling armed by a child effect in the same commit the directory arrives', async () => {
let latest: UseOrganizationDirectorySyncUsersReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
directory,
startPolling,
}: {
directory: DirectorySyncResource | null;
startPolling: () => void;
}) => {
useEffect(() => {
if (directory) {
startPolling();
}
}, [directory, startPolling]);
return null;
};

const Parent = ({ directory }: { directory: DirectorySyncResource | null }) => {
latest = __internal_useOrganizationDirectorySyncUsers({ directory, pollIntervalMs: POLL_INTERVAL_MS });
return (
<Child
directory={directory}
startPolling={latest.startPolling}
/>
);
};

const { rerender } = render(<Parent directory={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent directory={createDirectory('dir_1')} />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getUsersSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});
});
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { act, render, renderHook, waitFor } from '@testing-library/react';
import React, { useEffect } from 'react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { GetEnterpriseConnectionTestRunsParams } from '@/types/enterpriseConnectionTestRun';

import { INTERNAL_STABLE_KEYS } from '../../stable-keys';
import { createCacheKeys } from '../createCacheKeys';
import type { UseOrganizationEnterpriseConnectionTestRunsReturn } from '../useOrganizationEnterpriseConnectionTestRuns';
import { __internal_useOrganizationEnterpriseConnectionTestRuns } from '../useOrganizationEnterpriseConnectionTestRuns';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';
Expand DownExpand Up@@ -99,3 +101,69 @@ describe('useOrganizationEnterpriseConnectionTestRuns β€” revalidate invalidatio
invalidateSpy.mockRestore();
});
});

describe('useOrganizationEnterpriseConnectionTestRuns β€” polling arm scope', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
});

it('keeps polling armed by a child effect in the same commit the connection arrives', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
let latest: UseOrganizationEnterpriseConnectionTestRunsReturn | undefined;

// Child effects run before parent effects, so this is the ordering a
// reset-in-effect implementation would silently cancel.
const Child = ({
enterpriseConnectionId,
revalidate,
}: {
enterpriseConnectionId: string | null;
revalidate: UseOrganizationEnterpriseConnectionTestRunsReturn['revalidate'];
}) => {
useEffect(() => {
if (enterpriseConnectionId) {
void revalidate();
}
}, [enterpriseConnectionId, revalidate]);
return null;
};

const Parent = ({ enterpriseConnectionId }: { enterpriseConnectionId: string | null }) => {
latest = __internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 });
return (
<Child
enterpriseConnectionId={enterpriseConnectionId}
revalidate={latest.revalidate}
/>
);
};

const { rerender } = render(<Parent enterpriseConnectionId={null} />);
expect(latest?.isPolling).toBe(false);

rerender(<Parent enterpriseConnectionId='ent_1' />);

await waitFor(() => expect(latest?.isPolling).toBe(true));
await waitFor(() => expect(getTestRunsSpy.mock.calls.length).toBeGreaterThanOrEqual(3));
});

it('disarms polling when the connection changes', async () => {
getTestRunsSpy.mockImplementation(() => Promise.resolve({ data: [], total_count: 0 }));
const { result, rerender } = renderHook(
({ enterpriseConnectionId }: { enterpriseConnectionId: string }) =>
__internal_useOrganizationEnterpriseConnectionTestRuns({ enterpriseConnectionId, pollIntervalMs: 20 }),
{ wrapper, initialProps: { enterpriseConnectionId: 'ent_1' } },
);
await waitFor(() => expect(result.current.isLoading).toBe(false));

await act(async () => {
await result.current.revalidate();
});
expect(result.current.isPolling).toBe(true);

rerender({ enterpriseConnectionId: 'ent_2' });
expect(result.current.isPolling).toBe(false);
});
});
10 changes: 10 additions & 0 deletions packages/shared/src/react/hooks/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,6 +49,16 @@ export type {
} from './useOrganizationEnterpriseConnections';
export { __internal_useOrganizationDomains } from './useOrganizationDomains';
export type { UseOrganizationDomainsParams, UseOrganizationDomainsReturn } from './useOrganizationDomains';
export { __internal_useOrganizationDirectorySync } from './useOrganizationDirectorySync';
export type {
UseOrganizationDirectorySyncParams,
UseOrganizationDirectorySyncReturn,
} from './useOrganizationDirectorySync';
export { __internal_useOrganizationDirectorySyncUsers } from './useOrganizationDirectorySyncUsers';
export type {
UseOrganizationDirectorySyncUsersParams,
UseOrganizationDirectorySyncUsersReturn,
} from './useOrganizationDirectorySyncUsers';
export { __internal_useOrganizationEnterpriseConnectionTestRuns } from './useOrganizationEnterpriseConnectionTestRuns';
export type {
UseOrganizationEnterpriseConnectionTestRunsParams,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import { useMemo } from 'react';

import type { GetDirectorySyncUsersParams } from '../../types/directorySync';
import { INTERNAL_STABLE_KEYS } from '../stable-keys';
import { createCacheKeys } from './createCacheKeys';

/**
* @internal
*/
export function useOrganizationDirectorySyncCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
}) {
const { organizationId, enterpriseConnectionId } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
},
untracked: {
args: {},
},
});
}, [organizationId, enterpriseConnectionId]);
}

/**
* @internal
*/
export function useOrganizationDirectorySyncUsersCacheKeys(params: {
organizationId: string | null;
enterpriseConnectionId: string | null;
directoryId: string | null;
args: GetDirectorySyncUsersParams;
}) {
const { organizationId, enterpriseConnectionId, directoryId, args } = params;
return useMemo(() => {
return createCacheKeys({
stablePrefix: INTERNAL_STABLE_KEYS.ORGANIZATION_DIRECTORY_SYNC_USERS_KEY,
authenticated: Boolean(organizationId),
tracked: {
organizationId: organizationId ?? null,
enterpriseConnectionId: enterpriseConnectionId ?? null,
directoryId: directoryId ?? null,
},
untracked: {
args,
},
});
// The args object is intentionally serialized via the consumer to keep stability.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, enterpriseConnectionId, directoryId, JSON.stringify(args)]);
}
Loading
Loading