Uh oh!
There was an error while loading. Please reload this page.
fix: three Node.js compat bugs in node:crypto and node:buffer - #6923
Open
Sertug17 wants to merge 1 commit into
Open
fix: three Node.js compat bugs in node:crypto and node:buffer#6923Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three Node.js compatibility bugs found during manual code review.
Changes
1.
node:crypto—Cipheriv.prototype.updatedefault encodingFixes#6920
cipher.update('string')withoutinputEncodingnow defaults to'utf8'instead of throwingERR_INVALID_ARG_VALUE, matching Node.js behavior.2.
node:crypto—Hmac.prototype.digestfinalizationFixes#6921
Calling
hmac.digest()a second time now throwsERR_CRYPTO_HASH_FINALIZEDinstead of silently returning an empty Buffer, matchingHash.prototype.digestand Node.js behavior.3.
node:buffer—Buffer.alloc/allocUnsafeoff-by-oneFixes#6922
Changed
size >= kMaxLengthtosize > kMaxLengthso thatBuffer.alloc(kMaxLength)no longer incorrectly throwsERR_OUT_OF_RANGE. The internalcreateBufferfunction already used>— this makesallocconsistent.