Skip to content

fix: three Node.js compat bugs in node:crypto and node:buffer#6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sertug17 wants to merge 1 commit into
base:main
Choose a base branch
from
+4 −14
Open

fix: three Node.js compat bugs in node:crypto and node:buffer #6923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/node/internal/crypto_cipher.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,7 @@ Cipheriv.prototype.update = function (
let ret: ArrayBuffer;
if (typeof data === 'string') {
if (inputEncoding === undefined) {
throw new ERR_INVALID_ARG_VALUE(
'inputEncoding',
inputEncoding,
'If inputEncoding is not provided then the data must be a Buffer'
);
inputEncoding = 'utf8';
}
ret = this[kHandle].update(Buffer.from(data, inputEncoding));
} else if (isAnyArrayBuffer(data)) {
Expand DownExpand Up@@ -356,11 +352,7 @@ Decipheriv.prototype.update = function (
let ret: ArrayBuffer;
if (typeof data === 'string') {
if (inputEncoding === undefined) {
throw new ERR_INVALID_ARG_VALUE(
'inputEncoding',
inputEncoding,
'If inputEncoding is not provided then the data must be a Buffer'
);
inputEncoding = 'utf8';
}
ret = this[kHandle].update(Buffer.from(data, inputEncoding));
} else if (isAnyArrayBuffer(data)) {
Expand Down
4 changes: 1 addition & 3 deletions src/node/internal/crypto_hash.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -277,9 +277,7 @@ Hmac.prototype.digest = function (
): Buffer | string {
const state = this[kState];
if (state[kFinalized]) {
return !outputEncoding || outputEncoding === 'buffer'
? Buffer.from('')
: '';
throw new ERR_CRYPTO_HASH_FINALIZED();
}

// Explicit conversion for backward compatibility.
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_buffer.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -447,7 +447,7 @@ function alloc(size: number, fill?: FillValue, encoding?: string): Buffer {
if (Number.isNaN(size)) {
throw new ERR_INVALID_ARG_VALUE.RangeError('size', size);
}
if (size >= kMaxLength) {
if (size > kMaxLength) {
throw new ERR_OUT_OF_RANGE('size', `0 to ${kMaxLength}`, size);
}

Expand Down