Conversation
….json`; change internal CJS path - Refactoring: Switch to ESM - Update: Switch from deprecated `request` to `node-fetch` - Testing: Switch to `mocha`/`chai`/`c8` - Testing: Begin binary file coverage - Docs: Add ESM file-server example
This was referenced Jul 23, 2021
Merged
cloudhead
approved these changes
Jul 23, 2021
cloudhead pushed a commit
that referenced
this pull request
Jul 25, 2021
Zarel pushed a commit
to Zarel/node-static
that referenced
this pull request
Aug 10, 2021
- **Breaking change**: Add type: 'module' and exports to `package.json`; change internal CJS path - Refactoring: Switch to ESM - Update: Switch from deprecated `request` to `node-fetch` - Testing: Switch to `mocha`/`chai`/`c8` - Testing: Begin binary file coverage - Docs: Add ESM file-server example
Zarel pushed a commit
to Zarel/node-static
that referenced
this pull request
Aug 10, 2021
- **Breaking change**: Add type: 'module' and exports to `package.json`; change internal CJS path - Refactoring: Switch to ESM - Update: Switch from deprecated `request` to `node-fetch` - Testing: Switch to `mocha`/`chai`/`c8` - Testing: Begin binary file coverage - Docs: Add ESM file-server example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: 'module'andexportstopackage.json;change internal CJS path
requesttonode-fetchmocha/chai/c8These changes relate to adding ESM support. Testing ESM required mocha and c8, and using Mocha allowed beginning to test the binary for coverage. In the process also switched from deprecated
requestused in testing.Note that the binary file is now safely only added in ESM now since the
engineswe have already applied is Node 12+. However, for APIs, I added a Rollup routine to continue supporting CJS.Would be good to get some others to test it out.