Command line basics - #230
Merged
Merged
Conversation
….json`; change internal CJS path - Refactoring: Switch to ESM - Update: Switch from deprecated `request` to `node-fetch` - Testing: Switch to `mocha`/`chai`/`c8` - Testing: Begin binary file coverage - Docs: Add ESM file-server example
Also updates eslint
brettz9force-pushed
the
command-line-basics
branch
from
July 23, 2021 03:03
94af60c to
389849bCompare| import events from 'events'; | ||
| import http from 'http'; | ||
| import path from 'path'; | ||
| // import buffer from 'buffer'; |
CollaboratorAuthor
There was a problem hiding this comment.
That line had been based on a different commented out line (the same, but in CommonJS form). I can remove it if it wasn't there to remind you to do something :-)
cloudhead
approved these changes
Jul 23, 2021
Zarel pushed a commit
to Zarel/node-static
that referenced
this pull request
Aug 10, 2021
Zarel pushed a commit
to Zarel/node-static
that referenced
this pull request
Aug 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #229.
Fixes#228.
feat: switch from neodoc to lighter command-line-basics
Besides a smaller size (through
command-line-args,command-line-basicsbundlesupdate-notifierso user can be informed if there is an update.