Uh oh!
There was an error while loading. Please reload this page.
feat(featureflags): launch the New UI flag - #1286
Merged
Merged
Conversation
Mark FeatureFlag.NewUi as launched. The controller short-circuits launched flags to their default, so the new UI is now on for everyone: a user who toggled it off during the beta is moved onto it (the stored `false` is ignored, and cleared on next launch), and the flag drops out of availableEntries so the toggle no longer renders in Labs. The v1 code the flag gated is still in the tree; tearing it out is a separate change. Also align the Labs empty state with iOS — drop the emoji and match the copy and typography of SettingsAdvancedBetaFeaturesScreen. With NewUi gone from the list, that empty state is now reachable on tracks where no other flag is visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
FeatureFlag.NewUias launched, turning the new UI on for everyone and removing the toggle from Labs. This is the first of two changes — the v1 code teardown follows separately.Why
launchedrather than just leavingdefault = truedefaultwas alreadytrue, but that only covered users who never touched the toggle.InternalFeatureFlagControllershort-circuitslaunchedflags inget()andobserve():so a persisted
falsefrom a beta tester who opted out is now ignored, and the controller'sinitblock clears the stored preference on next launch.launchedalso drops the flag fromavailableEntries, which is what removes the row from the Labs list.minTrackwas checked and only filters the Labs list — it never gates the value.Labs empty state
With
NewUiout of the list, the empty state is now reachable on tracks where no other flag is visible, so it's aligned with iOS'sSettingsAdvancedBetaFeaturesScreen: emoji dropped, copy and typography matched.displayMediumtextSmalltextMediumNot in this PR
The v1 code the flag gated is still in the tree and now unreachable — the v1
AppContent, the v1NavigationBarbody,ScannerNavigationBar,BalanceScreen, and theisNewUiplumbing throughCodeNavigator/MainRoot/AppScreenContent. That teardown is a separate change, along with theNavBarConfig/FeatureFlag.NavBar/ Labs "Navigation Bar" screen cluster thatNavBarConfig's own docs mark for removal with v1.