Uh oh!
There was an error while loading. Please reload this page.
chore(ui): tear out the v1 UI behind the newUI flag - #1290
Open
bmc08gt wants to merge 1 commit into
Open
Conversation
`FeatureFlag.NewUi` launched, so every `isNewUi` branch had exactly one live
side. This removes the flag and collapses those branches, then deletes the v1
surfaces that are stranded once the branch is gone.
Removed
- `FeatureFlag.NewUi` and `FeatureFlag.NavBar` (the v1 nav-bar config flag),
plus the Labs "Nav Bar" settings screen that edited it.
- The v1 scanner chrome: `DecorView`, `ScannerDecorItem`,
`ScannerNavigationBar`, `LongPressDraggable`, `NavBarConfig`,
`GiveButtonLabel`.
- `apps/flipcash/features/home` — the v1 home host, unreferenced once the nav
bar is hoisted to the app root. Dropped from `settings.gradle.kts`.
- The v1 balance surface (`BalanceScreen`, `BalanceScreenContent`,
`CashReservesRow`) and the v1 currency-info sections (`TokenBalance`,
`TokenDetails`), superseded by the wallet deck and `CurrencyInfoContentV2`.
- `CurrencyCreatorUpsellCard` — the creator promo lives on the wallet now.
UI tests
The Maestro suite still drove v1 affordances (a "Tips"/"Discover"/"Cash" tab
row, a `menu_button`, a swipe-down sheet dismissal), so it is retargeted to the
v2 tab model rather than left to fail:
- `NavigationBar` tabs are tagged `nav_scanner` / `nav_wallet` / `nav_chats` /
`nav_tipcard`; `helpers/close_open_sheet.yaml` unwinds to the scanner tab.
- `SwapStep.Entry` is explicitly tagged `swap_screen` (the derived id would be
`entry_screen`); `buy.yaml` / `sell.yaml` already anchored on `swap_screen`.
- `CurrencyInfoExpansion` carries the `token_info_screen` anchor too, since in
v2 a wallet card expands as an overlay instead of pushing the screen.
- The chats list is tagged `chat_list`.
- `buy.yaml`/`sell.yaml` follow v2 swap semantics ("Get" on a currency you do
not hold, "Convert" in place of "Sell"), give flows enter via
Wallet → currency → Give, and `BaselineProfileGenerator` journeys switch tabs
instead of tapping v1 labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1286, which flipped
FeatureFlag.NewUito launched. With the flagpermanently on, every
isNewUibranch had exactly one live side — this removes theflag and collapses those branches, then deletes the v1 surfaces that are stranded
once the branch is gone.
Removed
FeatureFlag.NewUiandFeatureFlag.NavBar(the v1 nav-bar config flag),plus the Labs "Nav Bar" settings screen that edited it.
DecorView,ScannerDecorItem,ScannerNavigationBar,LongPressDraggable,NavBarConfig,GiveButtonLabel. The v2 nav bar is a singlepersistent overlay hoisted to the app root; none of this had a caller left.
apps/flipcash/features/home— the v1 home host. Dropped fromsettings.gradle.kts.BalanceScreen,BalanceScreenContent,CashReservesRow)and the v1 currency-info sections (
TokenBalance,TokenDetails), superseded by thewallet card deck and
CurrencyInfoContentV2.CurrencyCreatorUpsellCard— the creator promo is a wallet action tile now.Net: 92 files, +630 / −3766.
UI tests
The Maestro suite and the macrobenchmark still drove v1 affordances — a
"Tips"/"Discover"/"Cash" tab row, a
menu_button, a swipe-down sheet dismissal — sothey are retargeted to the v2 tab model rather than left to rot:
NavigationBartabs are taggednav_scanner/nav_wallet/nav_chats/nav_tipcard, andhelpers/close_open_sheet.yamlunwinds to the scanner tab(tabs are replaced on one root back stack, so Back never unwinds between them).
SwapStep.Entryis explicitly taggedswap_screen.buy.yaml/sell.yamlalreadyanchored on that id, but nothing ever emitted it — the derived id is
entry_screen.CurrencyInfoExpansioncarries thetoken_info_screenanchor too: in v2 a wallet cardexpands as an overlay rather than pushing
AppRoute.Token.Info, so the flows wouldotherwise lose their anchor on the most common path into currency info.
chat_list.buy.yaml/sell.yamlfollow v2 swap semantics: there is no "Sell" (liquidating is aConvert into Dollars), "Buy" is "Get" and is only offered on a currency you do not
hold, and the funding currency is picked inline rather than as a pushed step.
currency info, not the scanner.
BaselineProfileGeneratorjourneys switch tabs by resource id instead of tapping v1labels;
sendChatJourney(which entered an unbuilt module via a "Send" tab) becomes achats-tab journey.