Skip to content

build(codes): declare the kikcode lint tasks' dependency on generated fixtures - #1288

Merged
bmc08gt merged 1 commit into
code/cashfrom
fix/kikcode-lint-fixture-dependency
Aug 20, 2026
Merged

build(codes): declare the kikcode lint tasks' dependency on generated fixtures#1288
bmc08gt merged 1 commit into
code/cashfrom
fix/kikcode-lint-fixture-dependency

Conversation

@bmc08gt

Copy link
Copy Markdown
Collaborator

CI on code/cash is red since #1287: the Run Flipcash Tests job fails with two Gradle validation errors in :libs:codes:kikcode.

A problem was found with the configuration of task ':libs:codes:kikcode:lintAnalyzeAndroidHostTest'.
Property has implicit dependency
Task ':libs:codes:kikcode:lintAnalyzeAndroidHostTest' uses this output of task
':libs:codes:kikcode:generateTestFixtures' without declaring an explicit or implicit dependency.

commonTest's kotlin.srcDir(generateTestFixtures) carries the task dependency to the Kotlin compile tasks only. AGP's lintAnalyzeAndroidHostTest and generateAndroidHostTestLintModel read the same source directories straight off disk, so Gradle rejects the build whenever generateTestFixtures and those lint tasks land in one task graph — exactly what CI's flipcashTestDebug :apps:flipcash:app:lintDebug invocation does.

This declares the dependency explicitly for the module's lint tasks. The name filter only matches lintAnalyze* / *LintModel tasks, so the lint-jar/compileLint tasks are untouched.

… fixtures
`commonTest`'s `kotlin.srcDir(generateTestFixtures)` carries the task dependency to
the Kotlin compile tasks only. AGP's `lintAnalyzeAndroidHostTest` and
`generateAndroidHostTestLintModel` read the same source directories straight off
disk, so Gradle failed the build on an undeclared dependency on
`build/generated/testFixtures` whenever both landed in one task graph -- which is
exactly what CI's `flipcashTestDebug :apps:flipcash:app:lintDebug` does.
Wire the dependency on those lint tasks explicitly.
@github-actionsgithub-actionsBot added the type: build Build system, Gradle, dependencies label Aug 20, 2026
@bmc08gt
bmc08gt merged commit 4946d80 into code/cashAug 20, 2026
3 checks passed
@bmc08gt
bmc08gt deleted the fix/kikcode-lint-fixture-dependency branch August 20, 2026 21:16
bmc08gt added a commit that referenced this pull request Aug 21, 2026
… fixtures (#1292)
`commonTest`'s `kotlin.srcDir(generateTestFixtures)` carries the task dependency to
the Kotlin compile tasks only. AGP's `lintAnalyzeAndroidHostTest` and
`generateAndroidHostTestLintModel` read the same source directories straight off
disk, so Gradle failed the build on an undeclared dependency on
`build/generated/testFixtures` whenever both landed in one task graph -- which is
exactly what CI's `flipcashTestDebug :apps:flipcash:app:lintDebug` does.
This is the same wiring #1288 added to :libs:codes:kikcode; #1289 introduced an
identical fixture generator in :libs:encryption:base58 without it, leaving
code/cash red and failing every open PR on a build-config error unrelated to its
own changes.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: buildBuild system, Gradle, dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@bmc08gt