Uh oh!
There was an error while loading. Please reload this page.
build(base58): declare the base58 lint tasks' dependency on generated fixtures - #1292
Merged
Merged
Conversation
… fixtures `commonTest`'s `kotlin.srcDir(generateTestFixtures)` carries the task dependency to the Kotlin compile tasks only. AGP's `lintAnalyzeAndroidHostTest` and `generateAndroidHostTestLintModel` read the same source directories straight off disk, so Gradle failed the build on an undeclared dependency on `build/generated/testFixtures` whenever both landed in one task graph -- which is exactly what CI's `flipcashTestDebug :apps:flipcash:app:lintDebug` does. This is the same wiring #1288 added to :libs:codes:kikcode; #1289 introduced an identical fixture generator in :libs:encryption:base58 without it, leaving code/cash red and failing every open PR on a build-config error unrelated to its own changes.
Uh oh!
There was an error while loading. Please reload this page.
bmc08gt added a commit
that referenced
this pull request
Aug 21, 2026
…esign * origin/code/cash: fix(core): add \ to escape ' in What's (#1298) feat(shared-core): wrap the framework in a Swift target (#1297) chore: update display name entry title/hint (#1296) ci(shared-core): write a placeholder local.properties before publishing (#1295) build(shared-core): publish the XCFramework to flipcash-shared-core-spm (#1294) refactor(build-logic): extract the KMP test-fixture generator into a convention plugin (#1293) build(base58): declare the base58 lint tasks' dependency on generated fixtures (#1292) test(base58): run the vector gate on Kotlin/Native, not just the JVM (#1289) build(codes): declare the kikcode lint tasks' dependency on generated fixtures (#1288) # Conflicts: # apps/flipcash/core/src/main/res/values/strings.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code/cashis red at HEAD, so every open PR is currently failing on a build-config error unrelated to its own changes.#1289 introduced a
GenerateTestFixturestask in:libs:encryption:base58, wired into the build viacommonTest { kotlin.srcDir(generateTestFixtures) }. That form carries the task dependency to the Kotlin compile tasks only — AGP'sgenerateAndroidHostTestLintModelandlintAnalyzeAndroidHostTestread the same source directories straight off disk, so Gradle fails on an undeclared dependency onbuild/generated/testFixturesonce both land in one task graph. That is exactly what CI'sflipcashTestDebug :apps:flipcash:app:lintDebugdoes:This is the same wiring #1288 added to
:libs:codes:kikcodea minute earlier. #1289's own CI was already failing on this when it merged.Follow-up
The
GenerateTestFixturestask classes inbase58andkikcodeare now byte-identical apart from the generated package name. That copy-paste is why this broke twice — extracting it into abuild-logicconvention plugin that wires the lint dependency automatically would stop a third recurrence.