Skip to content

refactor(nx-plugin): set env vars if verbose is given - #1159

Merged
BioPhoton merged 29 commits into
mainfrom
refactor/nx-plugin/fix-verbose-handling
Dec 4, 2025
Merged

refactor(nx-plugin): set env vars if verbose is given#1159
BioPhoton merged 29 commits into
mainfrom
refactor/nx-plugin/fix-verbose-handling

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Dec 2, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR transforms the terminal args --verbose into a env var CP_VERBOSE=true

@nx-cloud

nx-cloudBot commented Dec 2, 2025•
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d7c4eec

CommandStatusDurationResult
nx run ci:code-pushup -- merge-diffs --files=/h...✅ Succeeded5sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded1m 22sView ↗
nx run-many --targets=code-pushup --parallel=fa...✅ Succeeded13m 35sView ↗
nx run-many -t unit-test,int-test✅ Succeeded5sView ↗

☁️ Nx Cloud last updated this comment at 2025-12-04 11:50:07 UTC

@pkg-pr-new

pkg-pr-newBot commented Dec 2, 2025•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1159

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1159

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1159

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1159

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1159

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1159

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1159

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1159

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1159

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1159

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1159

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1159

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1159

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1159

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1159

commit: d7c4eec

@BioPhotonBioPhoton mentioned this pull request Dec 2, 2025
Open
13 tasks
John Doe added 8 commits December 2, 2025 15:46
John Doe
refactor: wip
21511d4
John Doe
refactor: wip
e120e3b
John Doe
refactor: wip
5bab88e
John Doe
refactor: wip
bf78e82
John Doe
refactor: wip
676b88c
John Doe
refactor: wip
5ff3627
John Doe
Merge branch 'main' into refactor/nx-plugin/fix-verbose-handling
38c07da
# Conflicts:
#	e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts
#	packages/nx-plugin/src/executors/cli/executor.ts
#	packages/nx-plugin/src/executors/cli/executor.unit.test.ts
John Doe
refactor: fix unit test
be53602
@github-actions

github-actionsBot commented Dec 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit d017c3d with previous commit d1a115b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🔴 47🔴 42↓ −4.9
Code coverage🟡 89🟡 89↑ +0.1
Bug prevention🟡 67🟡 67–
Code style🟢 100🟢 100–
Security🔴 43🔴 43–
Updates🟡 71🟡 71–
Type Safety🟡 56🟡 56–
Miscellaneous🟡 67🟡 67–
Documentation🔴 35🔴 35–
Accessibility🟢 92🟢 92–
Best Practices🟢 100🟢 100–
SEO🟢 92🟢 92–
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 3 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🔴 47🔴 42↓ −4.9
Code coverageCode coverage metrics🟡 89🟡 89↑ +0.1

21 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseInitial server response time was short🟥 Root document took 760 ms🟩 Root document took 550 ms↓ −27.9 %
LighthouseTotal Blocking Time🟥 660 ms🟥 1,000 ms↑ +52.7 %
LighthouseMax Potential First Input Delay🟥 480 ms🟥 850 ms↑ +76.8 %
LighthouseSpeed Index🟥 6.2 s🟥 5.8 s↓ −6.5 %
LighthouseFirst Contentful Paint🟥 3.2 s🟥 3.2 s↑ +0.8 %
Code coverageBranch coverage🟨 87.2 %🟨 87.2 %↑ +0.1 %
LighthouseAvoids enormous network payloads🟩 Total size was 2,055 KiB🟩 Total size was 2,051 KiB↓ −0.2 %
LighthouseMinimizes main-thread work🟥 6.1 s🟥 8.3 s↑ +36.8 %
LighthouseJavaScript execution time🟥 2.2 s🟥 3.3 s↑ +51.6 %
LighthouseUses efficient cache policy on static assets🟨 31 resources found🟨 31 resources found↓ −0.1 %
LighthouseServer Backend Latencies🟩 1,470 ms🟩 810 ms↓ −44.8 %
LighthouseReduce unused CSS🟥 Potential savings of 94 KiB🟥 Potential savings of 94 KiB↑ +66.7 %
LighthouseRemove duplicate modules in JavaScript bundles🟥 Potential savings of 105 KiB🟥 Potential savings of 103 KiB↓ −25 %
LighthouseLargest Contentful Paint🟥 11.0 s🟥 11.0 s↓ −0.5 %
LighthouseMetrics🟩 100%🟩 100%↓ −0.1 %
LighthouseTime to Interactive🟥 12.2 s🟥 12.2 s↓ −0.1 %
LighthouseNetwork Round Trip Times🟩 60 ms🟩 50 ms↓ −19.4 %
LighthouseReduce unused JavaScript🟥 Potential savings of 185 KiB🟥 Potential savings of 186 KiB↓ −1.1 %
TypeScriptSemantic errors🟥 2622 errors🟥 2623 errors↑ +0.1 %
Code coverageLine coverage🟨 84.5 %🟨 84.5 %↓ −0.1 %

658 other audits are unchanged.

@BioPhoton
BioPhoton marked this pull request as ready for review December 2, 2025 18:05
@github-actions

github-actionsBot commented Dec 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit d017c3d with previous commit d1a115b.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Code coverage🟡 85🟡 85↑ +0.3

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
Code coverageCode coverage metrics🟡 85🟡 85↑ +0.3

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
Code coverageBranch coverage🟨 75.4 %🟨 76.4 %↑ +1.2 %
Code coverageLine coverage🟨 79.3 %🟨 79.3 %↓ −0.1 %

445 other audits are unchanged.

13 other projects are unchanged.

@BioPhotonBioPhoton changed the title refactor: set env vars if verbose is givenrefactor(nx-plugin): set env vars if verbose is givenDec 2, 2025
@BioPhotonBioPhoton mentioned this pull request Dec 3, 2025
Merged
matejchalk
matejchalk reviewed Dec 3, 2025
View reviewed changes
Comment threadpackages/nx-plugin/src/executors/cli/executor.ts Outdated
Comment threadpackages/nx-plugin/src/executors/cli/executor.unit.test.ts Outdated
Comment threadpackages/nx-plugin/src/executors/cli/executor.unit.test.ts Outdated
Comment threadpackages/nx-plugin/src/executors/cli/executor.ts
matejchalk
matejchalk approved these changes Dec 4, 2025
View reviewed changes
Comment threadpackages/nx-plugin/src/executors/cli/executor.int.test.ts Outdated
Comment threadpackages/nx-plugin/src/executors/cli/executor.int.test.ts Outdated
Michael Hladkyand others added 3 commits December 4, 2025 12:31
Michael Hladky
Merge branch 'main' into refactor/nx-plugin/fix-verbose-handling
f21e7eb
@BioPhoton@matejchalk
Update packages/nx-plugin/src/executors/cli/executor.int.test.ts
c543f62
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton@matejchalk
Update packages/nx-plugin/src/executors/cli/executor.int.test.ts
d7c4eec
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
BioPhoton merged commit 3bafc89 into mainDec 4, 2025
24 checks passed
@BioPhoton
BioPhoton deleted the refactor/nx-plugin/fix-verbose-handling branch December 4, 2025 12:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalkmatejchalkmatejchalk approved these changes

Assignees

@BioPhotonBioPhoton

Labels

🧩 nx-plugin🔬 testingwriting tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton@matejchalk