refactor(nx-plugin): add env vars to executor by BioPhoton · Pull Request #1161 · code-pushup/cli

BioPhoton · 2025-12-02T18:16:02Z

This PR enables the plugin to use our local TS code instead of a installed NPM package.
I also renamed AutorunExecutor to CliExecutor

depends on #1159

Followup PR will cover testing the logic in runCliExecutor.

# Conflicts: # e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts

…-vars-to-executor # Conflicts: # packages/nx-plugin/src/executors/cli/executor.ts

…ugin/add-env-vars-to-executor

nx-cloud · 2025-12-02T18:16:55Z

View your CI Pipeline Execution ↗ for commit 5c02a21

Command	Status	Duration	Result
`nx run-many --targets=code-pushup --parallel=fa...`	❌ Failed	13m 46s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-11 17:16:39 UTC

pkg-pr-new · 2025-12-02T18:17:34Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1161

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1161

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1161

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1161

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1161

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1161

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1161

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1161

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1161

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1161

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1161

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1161

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1161

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1161

commit: 5c02a21

github-actions · 2025-12-02T18:21:57Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 3a909e2 with previous commit f74d2dd.

💼 Project `plugin-axe`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 95	🟢 93
Documentation	🟡 68	🟡 68

4 other categories are unchanged.

👎 2 groups regressed, 👍 1 audit improved, 👎 2 audits regressed, 2 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 95	🟢 93
JSDoc coverage	Documentation coverage	🟡 68	🟡 68

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Code coverage	Branch coverage	🟩 93.6 %	🟨 86.4 %
Code coverage	Line coverage	🟨 67.7 %	🟨 72.3 %
JSDoc coverage	Functions coverage	🟥 14 undocumented functions	🟥 21 undocumented functions
JSDoc coverage	Variables coverage	🟥 11 undocumented variables	🟥 16 undocumented variables
JSDoc coverage	Types coverage	🟥 2 undocumented types	🟥 6 undocumented types

437 other audits are unchanged.

💼 Project `cli`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 92	🟢 92
Documentation	🟡 65	🟡 65

4 other categories are unchanged.

👍 2 groups improved, 👍 3 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 92	🟢 92
JSDoc coverage	Documentation coverage	🟡 65	🟡 65

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Code coverage	Function coverage	🟩 95.9 %	🟩 97.3 %
Code coverage	Line coverage	🟨 88 %	🟨 88.5 %
JSDoc coverage	Functions coverage	🟥 17 undocumented functions	🟥 16 undocumented functions
Code coverage	Branch coverage	🟨 84.5 %	🟨 84.2 %

439 other audits are unchanged.

💼 Project `plugin-lighthouse`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🔴 47	🔴 48
Code coverage	🟢 99	🟢 99

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDoc coverage	Documentation coverage	🔴 47	🔴 48
Code coverage	Code coverage metrics	🟢 99	🟢 99

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDoc coverage	Variables coverage	🟥 20 undocumented variables	🟥 20 undocumented variables
Code coverage	Line coverage	🟩 97.2 %	🟩 97 %
Code coverage	Branch coverage	🟩 96.1 %	🟩 96.1 %

440 other audits are unchanged.

💼 Project `core`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 89	🟡 90
Documentation	🟡 74	🟡 74

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 89	🟡 90
JSDoc coverage	Documentation coverage	🟡 74	🟡 74

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Code coverage	Line coverage	🟩 90.5 %	🟩 91.2 %
JSDoc coverage	Functions coverage	🟥 11 undocumented functions	🟥 12 undocumented functions
Code coverage	Branch coverage	🟨 81.1 %	🟨 81.7 %
Code coverage	Function coverage	🟩 93.1 %	🟩 93.2 %

439 other audits are unchanged.

💼 Project `utils`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 94	🟢 95
Documentation	🔴 38	🔴 38

4 other categories are unchanged.

👍 2 groups improved, 👍 3 audits improved, 👎 1 audit regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 94	🟢 95
JSDoc coverage	Documentation coverage	🔴 38	🔴 38

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDoc coverage	Types coverage	🟥 47 undocumented types	🟥 45 undocumented types
Code coverage	Function coverage	🟩 95.3 %	🟩 95.5 %
JSDoc coverage	Functions coverage	🟥 236 undocumented functions	🟥 233 undocumented functions
Code coverage	Line coverage	🟩 97 %	🟩 96.9 %
Code coverage	Branch coverage	🟩 91.9 %	🟩 92 %

438 other audits are unchanged.

💼 Project `plugin-eslint`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🟡 66	🟡 66
Code coverage	🟢 94	🟢 94

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDoc coverage	Documentation coverage	🟡 66	🟡 66
Code coverage	Code coverage metrics	🟢 94	🟢 94

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDoc coverage	Variables coverage	🟥 13 undocumented variables	🟥 15 undocumented variables
Code coverage	Line coverage	🟩 91.8 %	🟩 92.5 %
JSDoc coverage	Functions coverage	🟥 46 undocumented functions	🟥 48 undocumented functions
Code coverage	Branch coverage	🟨 85 %	🟨 84.7 %
Code coverage	Function coverage	🟩 98.2 %	🟩 98.2 %
JSDoc coverage	Types coverage	🟥 14 undocumented types	🟥 15 undocumented types

437 other audits are unchanged.

💼 Project `nx-plugin`

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 85	🟡 85

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 85	🟡 85

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Line coverage	🟨 79.3 %	🟨 79.9 %
Code coverage	Branch coverage	🟨 76.4 %	🟨 76.4 %

445 other audits are unchanged.

7 other projects are unchanged.

github-actions · 2025-12-02T18:24:03Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 3a909e2 with previous commit f74d2dd.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 44	🔴 34
Best Practices	🟢 100	🟢 97
Code style	🟢 100	🟢 99
Updates	🟡 71	🟡 71
Code coverage	🟡 89	🟡 89
Documentation	🔴 35	🔴 35
Axe Accessibility	n/a ()*	🟡 88	n/a ()*
Bug prevention	🟡 67	🟡 67	–
Security	🔴 43	🔴 43	–
Type Safety	🟡 56	🟡 56	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
SEO	🟢 92	🟢 92	–

(*) New category.

👍 2 groups improved, 👎 5 groups regressed, 👍 5 audits improved, 👎 9 audits regressed, 28 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
ESLint	Style guide (import)	🟢 100	🟡 80
Lighthouse	Performance	🔴 44	🔴 34
Lighthouse	Best Practices	🟢 100	🟢 97
ESLint	Suggestions	🟢 100	🟢 99
JS Packages	NPM outdated dependencies	🟡 71	🟡 71
Code coverage	Code coverage metrics	🟡 89	🟡 89
JSDoc coverage	Documentation coverage	🔴 35	🔴 35

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
ESLint	Forbid unassigned imports	🟩 passed	🟥 1 warning
Lighthouse	No browser errors logged to the console	🟩 passed	🟥 failed
Lighthouse	Properly size images	🟨 Potential savings of 5 KiB	🟩 0
Lighthouse	First Contentful Paint	🟥 3.2 s	🟥 5.4 s
Lighthouse	Speed Index	🟥 6.7 s	🟥 10.0 s
Lighthouse	Total Blocking Time	🟥 800 ms	🟥 1,120 ms
Lighthouse	Time to Interactive	🟥 13.0 s	🟥 14.7 s
JS Packages	Outdated NPM dev dependencies.	🟨 59 outdated package versions (34 major, 19 minor, 6 patch)	🟨 60 outdated package versions (35 major, 19 minor, 6 patch)
JSDoc coverage	Variables coverage	🟥 246 undocumented variables	🟥 253 undocumented variables
Code coverage	Function coverage	🟩 90.3 %	🟩 90.6 %
Code coverage	Line coverage	🟨 84.7 %	🟨 84.9 %
Code coverage	Branch coverage	🟨 87.3 %	🟨 87.1 %
JSDoc coverage	Types coverage	🟥 241 undocumented types	🟥 244 undocumented types
JSDoc coverage	Functions coverage	🟥 561 undocumented functions	🟥 567 undocumented functions
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,032 KiB	🟩 Total size was 2,068 KiB
Lighthouse	Uses efficient cache policy on static assets	🟨 32 resources found	🟨 30 resources found
Lighthouse	Minimizes main-thread work	🟥 7.5 s	🟥 10.3 s
Lighthouse	Initial server response time was short	🟥 Root document took 790 ms	🟥 Root document took 2,690 ms
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Server Backend Latencies	🟩 1,760 ms	🟩 2,360 ms
Lighthouse	JavaScript execution time	🟥 2.9 s	🟥 3.5 s
Lighthouse	Reduce unused CSS	🟥 Potential savings of 105 KiB	🟥 Potential savings of 94 KiB
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 186 KiB	🟥 Potential savings of 187 KiB
Lighthouse	Largest Contentful Paint	🟥 11.6 s	🟥 11.7 s
Lighthouse	Max Potential First Input Delay	🟥 840 ms	🟥 970 ms
Lighthouse	Avoids an excessive DOM size	🟥 2,249 elements	🟥 2,353 elements
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 104 KiB	🟥 Potential savings of 101 KiB
Lighthouse	Network Round Trip Times	🟩 50 ms	🟩 70 ms
TypeScript	Semantic errors	🟥 2623 errors	🟥 2609 errors
Axe Accessibility	IDs used in ARIA and labels must be unique	🟩 38 elements	🟩 28 elements
Axe Accessibility	ARIA hidden element must not be focusable or contain focusable elements	🟩 192 elements	🟩 200 elements
Axe Accessibility	Elements must only use supported ARIA attributes	🟩 102 elements	🟩 96 elements
Axe Accessibility	ARIA attributes must be used as specified for the element's role	🟩 102 elements	🟩 96 elements
Axe Accessibility	Elements must only use permitted ARIA attributes	🟩 102 elements	🟩 96 elements
Axe Accessibility	ARIA attributes must conform to valid names	🟩 102 elements	🟩 96 elements
Axe Accessibility	Interactive controls must not be nested	🟩 63 elements	🟩 59 elements
Axe Accessibility	Inline text spacing must be adjustable with custom stylesheets	🟩 44 elements	🟩 41 elements
Axe Accessibility	Buttons must have discernible text	🟩 15 elements	🟩 13 elements
TypeScript	No implicit any errors	🟥 96 errors	🟥 95 errors
Axe Accessibility	ARIA attributes must conform to valid values	🟥 9 errors	🟥 8 errors
Axe Accessibility	Elements must have their visible text as part of their accessible name	🟥 3 errors	🟥 2 errors
Lighthouse	Cumulative Layout Shift	🟩 0	🟩 0

636 other audits are unchanged.

# Conflicts: # packages/nx-plugin/src/executors/cli/executor.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts

John Doe added 21 commits December 2, 2025 14:19

refactor: set env vars if verbose is given
348246c

refactor: fix int test
2dcfb65

refactor: fix lint
1106a36

refactor: wip
21511d4

refactor: wip
e120e3b

refactor: wip
5bab88e

refactor: wip
bf78e82

refactor: wip
676b88c

refactor: wip
5ff3627

refactor: intro evn options to cli executor
f270316

Merge branch 'main' into refactor/nx-plugin/fix-verbose-handling
38c07da
# Conflicts: # e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts # packages/nx-plugin/src/executors/cli/executor.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts

refactor: fix unit test
be53602

refactor: wip
f3a9231

refactor: wip
13a6340

refactor: wip
f5b950b

refactor: wip
aea384b

refactor: wip
4e02f79

refactor: fix lint
986ce0e

Merge remote-tracking branch 'origin/main' into fix/nx-plugin/add-env…
893b1d3
…-vars-to-executor # Conflicts: # packages/nx-plugin/src/executors/cli/executor.ts

Merge branch 'refactor/nx-plugin/fix-verbose-handling' into fix/nx-pl…
f4b8cdd
…ugin/add-env-vars-to-executor

refactor: wip
15418df

github-actionsBot assigned BioPhoton Dec 2, 2025

github-actionsBot added 🔬 testing writing tests 🧩 nx-plugin labels Dec 2, 2025

BioPhoton mentioned this pull request Dec 2, 2025
chore: use @code-pushup/nx-plugin in repo #1091
Open
13 tasks

Merge branch 'main' into fix/nx-plugin/add-env-vars-to-executor
507a9e6
# Conflicts: # packages/nx-plugin/src/executors/cli/executor.ts # packages/nx-plugin/src/executors/cli/executor.unit.test.ts

Michael Hladky added 6 commits December 4, 2025 13:41

refactor: wip
e8033d3

refactor: wip
8c1e35c

Merge branch 'main' into fix/nx-plugin/add-env-vars-to-executor
20d8c86

refactor: wip
983f1f8

refactor: wip
2eb3abd

refactor: wip
2787b89

BioPhoton marked this pull request as ready for review December 4, 2025 17:43

BioPhoton requested a review from matejchalk December 4, 2025 17:48

Michael Hladky added 6 commits December 4, 2025 18:53

refactor: wip
e74275b

refactor: wip
0118a7e

refactor: wip
093b4e6

refactor: wip
4a483a6

Merge branch 'main' into fix/nx-plugin/add-env-vars-to-executor
75d080e

refactor: wip
e5e8df0

BioPhoton enabled auto-merge (squash) December 10, 2025 12:41

matejchalk requested changes Dec 11, 2025
View reviewed changes

Comment threadpackages/nx-plugin/src/executors/cli/executor.ts

John Doe added 3 commits December 11, 2025 17:50

refactor: fix env var logging
1fd918b

refactor: wip
eac2f7a

Merge branch 'main' into fix/nx-plugin/add-env-vars-to-executor
5c02a21

BioPhoton requested a review from matejchalk December 11, 2025 17:00

matejchalk approved these changes Dec 11, 2025
View reviewed changes

BioPhoton merged commit 0396b84 into mainDec 11, 2025
22 of 24 checks passed

BioPhoton deleted the fix/nx-plugin/add-env-vars-to-executor branch December 11, 2025 17:06

Navigation Menu

Uh oh!

refactor(nx-plugin): add env vars to executor - #1161

refactor(nx-plugin): add env vars to executor#1161
BioPhoton merged 37 commits into
mainfrom
fix/nx-plugin/add-env-vars-to-executor

BioPhoton commented Dec 2, 2025•
edited
Loading

Uh oh!

nx-cloudBot commented Dec 2, 2025•
edited
Loading

Uh oh!

pkg-pr-newBot commented Dec 2, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Dec 2, 2025•
edited
Loading

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

🗃️ Groups

🛡️ Audits

Uh oh!

github-actionsBot commented Dec 2, 2025•
edited
Loading

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BioPhoton commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloudBot commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project plugin-axe

🗃️ Groups

🛡️ Audits

💼 Project cli

🗃️ Groups

🛡️ Audits

💼 Project plugin-lighthouse

🗃️ Groups

🛡️ Audits

💼 Project core

🗃️ Groups

🛡️ Audits

💼 Project utils

🗃️ Groups

🛡️ Audits

💼 Project plugin-eslint

🗃️ Groups

🛡️ Audits

💼 Project nx-plugin

🗃️ Groups

🛡️ Audits

Uh oh!

github-actionsBot commented Dec 2, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BioPhoton commented Dec 2, 2025•
edited
Loading

nx-cloudBot commented Dec 2, 2025•
edited
Loading

pkg-pr-newBot commented Dec 2, 2025•
edited
Loading

github-actionsBot commented Dec 2, 2025•
edited
Loading

💼 Project `plugin-axe`

💼 Project `cli`

💼 Project `plugin-lighthouse`

💼 Project `core`

💼 Project `utils`

💼 Project `plugin-eslint`

💼 Project `nx-plugin`

github-actionsBot commented Dec 2, 2025•
edited
Loading