Uh oh!
There was an error while loading. Please reload this page.
feat(models): add report filename option - #174
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
left a comment
There was a problem hiding this comment.
It works nicely with the config 👍
The PR description is a bit misleading, --filename (or --persist.filename) doesn't work as a CLI argument. You'd have to add persist.filename to core-config-options.ts to make it accessible from the CLI (we should auto-sync those in the future, probably).
Also, I noticed the PR title doesn't follow our commit conventions - model scope should be models.
The changes should help to improve testing of report generation. ATM all tests write in the same folder and with the same file name. Adding a
filenameoption to core would improve the testing situation and is helpful in for integrations.This PR includes:
persistConfigSchemawithfilenameand a default valueImplementing the CLI option is resolved in a followup PR
closes#161