Skip to content

refactor(models): refine types for better DX and exploration - #183

Merged
BioPhoton merged 7 commits into
mainfrom
improve-models-types
Oct 31, 2023
Merged

refactor(models): refine types for better DX and exploration#183
BioPhoton merged 7 commits into
mainfrom
improve-models-types

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Oct 29, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

closes#147

@BioPhotonBioPhoton self-assigned this Oct 29, 2023
@BioPhotonBioPhoton added this to the 1. Internal MVP milestone Oct 29, 2023
@BioPhotonBioPhoton added the 🤓 UX UX improvement for CLI users label Oct 29, 2023
@BioPhotonBioPhoton mentioned this pull request Oct 30, 2023
Merged
matejchalk
matejchalk reviewed Oct 30, 2023
View reviewed changes

@matejchalkmatejchalk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very nice improvement 🙂

Comment threadpackages/core/src/lib/implementation/json-to-gql.ts
Comment threadpackages/models/src/lib/plugin-config.ts Outdated
Comment threadpackages/models/src/lib/category-config.ts Outdated
Comment threadpackages/core/src/lib/implementation/json-to-gql.ts Outdated
matejchalk
matejchalk previously approved these changes Oct 30, 2023
View reviewed changes
@BioPhoton
BioPhoton merged commit d9e5b70 into mainOct 31, 2023
@BioPhoton
BioPhoton deleted the improve-models-types branch October 31, 2023 10:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalkmatejchalkmatejchalk approved these changes
@vmasekvmasekAwaiting requested review from vmasek

Assignees

@BioPhotonBioPhoton

Labels

🧩 models🤓 UXUX improvement for CLI users

Projects

None yet

Milestone

1. Internal MVP

Development

Successfully merging this pull request may close these issues.

improve models types

2 participants

@BioPhoton@matejchalk