Skip to content

feat(nx-plugin): add general executor logic - #740

Merged
BioPhoton merged 21 commits into
mainfrom
executor-utils
Jul 12, 2024
Merged

feat(nx-plugin): add general executor logic#740
BioPhoton merged 21 commits into
mainfrom
executor-utils

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Jul 10, 2024

Copy link
Copy Markdown
Collaborator

This PR add the general executor logic to the nx-plugin package.

It includes:

Potential improvements:

Related to:
#63

@github-actions

github-actionsBot commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 6c7277a with source commit 2f8d78e.

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🟡 54🟡 55↑ +0.8
Code coverage🟡 89🟡 89↑ +0
Accessibility🟢 91🟢 91
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Bug prevention🟢 100🟢 100
Code style🟢 99🟢 99
Security🟢 100🟢 100
Updates🟡 78🟡 78
Custom checks🟡 67🟡 67

🗃️ Groups

👍 2 groups improved
🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🟡 54🟡 55↑ +0.8
Code coverageCode coverage metrics🟡 89🟡 89↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 5 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score
🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseSpeed Index🟥 6.0 s🟥 6.7 s↑ +12 %
LighthouseLargest Contentful Paint🟨 3.1 s🟨 2.9 s↓ −8 %
LighthouseTime to Interactive🟥 14.6 s🟥 17.1 s↑ +17 %
LighthouseFirst Contentful Paint🟨 2.9 s🟨 2.9 s↓ −3 %
LighthouseFirst Meaningful Paint🟨 2.9 s🟨 2.9 s↓ −3 %
Code coverageBranch coverage🟨 83.7 %🟨 83.5 %↓ +0 %
Code coverageLine coverage🟩 91.8 %🟩 91.9 %↑ +0 %
Code coverageFunction coverage🟩 91.8 %🟩 91.9 %↑ +0 %
LighthouseMinimizes main-thread work🟥 17.8 s🟥 21.9 s↑ +23 %
LighthouseMetrics🟩 14630🟩 17061↑ +17 %
LighthouseTotal Blocking Time🟥 5,310 ms🟥 7,660 ms↑ +44 %
LighthouseJavaScript execution time🟥 7.2 s🟥 9.2 s↑ +29 %
LighthouseMax Potential First Input Delay🟥 1,680 ms🟥 2,930 ms↑ +75 %
LighthouseAvoids enormous network payloads🟩 Total size was 1,787 KiB🟩 Total size was 1,787 KiB↓ +0 %
LighthouseEliminate render-blocking resources🟥 Potential savings of 650 ms🟥 Potential savings of 810 ms↑ +25 %
LighthouseInitial server response time was short🟩 Root document took 420 ms🟩 Root document took 360 ms↓ −14 %
LighthouseUses efficient cache policy on static assets🟨 28 resources found🟨 28 resources found↓ +0 %
LighthouseReduce unused CSS🟥 Potential savings of 105 KiB🟥 Potential savings of 105 KiB↓ −4 %
LighthouseServer Backend Latencies🟩 210 ms🟩 220 ms↑ +7 %
LighthouseNetwork Round Trip Times🟩 60 ms🟩 50 ms↓ −9 %

489 other audits are unchanged.

@BioPhoton
BioPhoton marked this pull request as ready for review July 11, 2024 00:27
Comment threadpackages/nx-plugin/src/executors/internal/config.integration.test.ts Outdated
Comment threadpackages/nx-plugin/src/executors/internal/env.ts Outdated
Comment threadpackages/nx-plugin/src/executors/internal/config.ts Outdated
Comment threadpackages/nx-plugin/src/executors/internal/config.ts Outdated
Comment threadpackages/nx-plugin/src/executors/internal/config.ts Outdated
Comment threadpackages/nx-plugin/src/generators/configuration/generator.ts Outdated
Comment threadpackages/nx-plugin/src/generators/configuration/schema.json Outdated
Comment threadtesting/test-utils/src/lib/utils/path.ts
Comment threadpackages/nx-plugin/src/generators/init/Readme.md
Comment threadpackages/nx-plugin/src/executors/internal/env.unit.test.ts Outdated
BioPhotonand others added 2 commits July 12, 2024 19:34
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
BioPhoton enabled auto-merge (rebase) July 12, 2024 18:06
@BioPhoton
BioPhoton merged commit 2951228 into mainJul 12, 2024
@BioPhoton
BioPhoton deleted the executor-utils branch July 12, 2024 19:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 core🧩 nx-plugin📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests🛠️ tooling🧩 utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton@matejchalk