Skip to content

feat(nx-plugin): add executor to nx-plugin - #737

Merged
BioPhoton merged 116 commits into
mainfrom
add-executor-to-nx-plugin
Jul 24, 2024
Merged

feat(nx-plugin): add executor to nx-plugin#737
BioPhoton merged 116 commits into
mainfrom
add-executor-to-nx-plugin

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Jul 8, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Precondition:
#740
closes#289

This PR includes:

  • add executor autorun
  • add executor utils
  • add format normalization

Not included in this PR:

Related to:
#63

@BioPhoton
feat(nx-plugin): add basic executor
870fc10
@BioPhoton
wip
fb701fd
@BioPhoton
wip
cd143ec
@BioPhoton
wip
405a47b
@BioPhoton
refactor(nx-plugin): polish executor logic
d630581
@BioPhoton
wip
922f2bc
@BioPhoton
Merge branch 'main' into add-executor-to-nx-plugin
9b065c6
# Conflicts:
#	e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts
#	e2e/nx-plugin-e2e/tests/init.e2e.test.ts
#	e2e/nx-plugin-e2e/vite.config.e2e.ts
#	package-lock.json
#	packages/nx-plugin/project.json
#	packages/nx-plugin/src/generators/configuration/__snapshots__/generator.integration.test.ts.snap
#	packages/nx-plugin/src/generators/configuration/files/code-pushup.config.ts.template
#	packages/nx-plugin/src/generators/configuration/generator.integration.test.ts
#	packages/nx-plugin/src/generators/configuration/generator.ts
#	testing/test-utils/src/index.ts
@BioPhoton
feat(nx-plugin): adjust executor
c8f68ee
@BioPhoton
Merge branch 'main' into add-executor-to-nx-plugin
34e16fd
# Conflicts:
#	README.md
#	e2e/nx-plugin-e2e/project.json
@BioPhoton
feat(nx-plugin): fix lint
1f21131
@BioPhoton
feat(nx-plugin): fix unit-test
3827a3c
@BioPhoton
wip
cf78b86
@github-actions

github-actionsBot commented Jul 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 9ce99d0 with source commit a08978e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🔴 48🔴 44↓ −3.7
Code coverage🟡 90🟡 90↓ −0.1
Accessibility🟢 91🟢 91–
Best Practices🟢 100🟢 100–
SEO🟡 61🟡 61–
Bug prevention🟢 100🟢 100–
Code style🟢 99🟢 99–
Security🟢 100🟢 100–
Updates🟡 79🟡 79–
Custom checks🟡 67🟡 67–

🗃️ Groups

👎 2 groups regressed
🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🔴 48🔴 44↓ −3.7
Code coverageCode coverage metrics🟡 90🟡 90↓ −0.1

18 other groups are unchanged.

🛡️ Audits

👍 4 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score
🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseLargest Contentful Paint🟨 3.5 s🟨 3.9 s↑ +12 %
LighthouseSpeed Index🟥 7.2 s🟥 8.2 s↑ +14 %
LighthouseFirst Contentful Paint🟥 3.2 s🟥 3.2 s↓ −1 %
LighthouseTime to Interactive🟥 20.4 s🟥 17.7 s↓ −14 %
LighthouseFirst Meaningful Paint🟨 3.2 s🟨 3.2 s↓ −1 %
Code coverageLine coverage🟩 91.6 %🟩 91.3 %↓ +0 %
Code coverageBranch coverage🟨 83.8 %🟨 83.6 %↓ +0 %
Code coverageFunction coverage🟩 92.3 %🟩 92.4 %↑ +0 %
LighthouseAvoids enormous network payloads🟩 Total size was 1,789 KiB🟩 Total size was 1,782 KiB↓ +0 %
LighthouseTotal Blocking Time🟥 13,220 ms🟥 9,530 ms↓ −28 %
LighthouseMetrics🟩 20417🟩 17653↓ −14 %
LighthouseJavaScript execution time🟥 13.2 s🟥 11.4 s↓ −14 %
LighthouseMinimizes main-thread work🟥 26.3 s🟥 24.7 s↓ −6 %
LighthouseMax Potential First Input Delay🟥 3,290 ms🟥 3,980 ms↑ +21 %
LighthouseServer Backend Latencies🟩 380 ms🟩 130 ms↓ −65 %
LighthouseEliminate render-blocking resources🟥 Potential savings of 1,420 ms🟥 Potential savings of 1,510 ms↑ +6 %
LighthouseInitial server response time was short🟩 Root document took 410 ms🟩 Root document took 360 ms↓ −12 %
LighthouseNetwork Round Trip Times🟩 60 ms🟩 20 ms↓ −76 %
LighthouseUses efficient cache policy on static assets🟨 27 resources found🟨 27 resources found↑ +0 %
LighthouseAvoids an excessive DOM size🟥 2,184 elements🟥 2,185 elements↑ +0 %

489 other audits are unchanged.

BioPhoton
BioPhoton commented Jul 8, 2024
View reviewed changes
Comment threadpackages/models/src/lib/upload-config.unit.test.ts
BioPhoton
BioPhoton commented Jul 21, 2024
View reviewed changes
Comment thread.github/workflows/code-pushup.yml Outdated
@github-actionsgithub-actionsBot removed the 🦾 CI/CD Continuous integration and deployment label Jul 21, 2024
@BioPhoton
Merge branch 'main' into add-executor-to-nx-plugin
ff9613b
# Conflicts:
#	packages/cli/src/lib/implementation/core-config.middleware.ts
#	packages/cli/src/lib/implementation/core-config.middleware.unit.test.ts
@BioPhoton
refactor(utils): support nested objects in cliObjToArgs
b534f23
@BioPhotonBioPhoton mentioned this pull request Jul 22, 2024
Merged
@BioPhoton
Merge branch 'main' into add-executor-to-nx-plugin
a1d03f1
# Conflicts:
#	packages/nx-plugin/src/executors/internal/cli.ts
#	packages/nx-plugin/src/executors/internal/cli.unit.test.ts
#	packages/utils/src/lib/transform.unit.test.ts
matejchalk
matejchalk reviewed Jul 23, 2024
View reviewed changes
Comment threadpackages/models/code-pushup.config.ts Outdated
Comment threadpackages/models/project.json Outdated
Comment threadpackages/nx-plugin/mock/utils/executor.ts Outdated
Comment threadpackages/nx-plugin/src/executors/autorun/Readme.md Outdated
Comment threadpackages/nx-plugin/src/executors/autorun/Readme.md
Comment threadpackages/nx-plugin/src/executors/autorun/executor.ts Outdated
Comment threadpackages/nx-plugin/src/executors/autorun/utils.ts Outdated
Comment threadtesting/test-utils/src/lib/utils/nx.ts Outdated
Comment threadnx.json Outdated
@BioPhoton
BioPhoton merged commit ba4f181 into mainJul 24, 2024
@BioPhoton
BioPhoton deleted the add-executor-to-nx-plugin branch July 24, 2024 09:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalkmatejchalkmatejchalk approved these changes

Assignees

@BioPhotonBioPhoton

Labels

🧩 nx-plugin📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests🛠️ tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

intro RC schema

2 participants

@BioPhoton@matejchalk