Skip to content

feat(utils): add nested objects to cli args parsing - #758

Merged
BioPhoton merged 4 commits into
mainfrom
add-nested-objects-to-cli-args-parsing
Jul 22, 2024
Merged

feat(utils): add nested objects to cli args parsing#758
BioPhoton merged 4 commits into
mainfrom
add-nested-objects-to-cli-args-parsing

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Jul 22, 2024

Copy link
Copy Markdown
Collaborator

Hotfix for #737

before:
parseObjToCliArgs({persist: {format: ['md', 'json']}}) => --persist.format="md,json"

after:
parseObjToCliArgs({persist: {format: ['md', 'json']}}) => --persist.format="md" --persist.format="json"

@github-actions

github-actionsBot commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 446b9e4 with source commit 9826945.

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🟡 53🔴 44↓ −9.2
Code coverage🟡 89🟡 89↑ +0
Accessibility🟢 91🟢 91
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Bug prevention🟢 100🟢 100
Code style🟢 99🟢 99
Security🟢 100🟢 100
Updates🟡 78🟡 78
Custom checks🟡 67🟡 67

🗃️ Groups

👍 1 group improved, 👎 1 group regressed
🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🟡 53🔴 44↓ −9.2
Code coverageCode coverage metrics🟡 89🟡 89↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 4 audits improved, 👎 5 audits regressed, 10 audits changed without impacting score
🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseEliminate render-blocking resources🟥 Potential savings of 1,380 ms🟨 Potential savings of 0 ms↓ −100 %
LighthouseReduce unused CSS🟥 Potential savings of 105 KiB🟨 Potential savings of 105 KiB↓ −100 %
LighthouseLargest Contentful Paint🟨 3.2 s🟥 4.2 s↑ +29 %
LighthouseSpeed Index🟥 5.9 s🟥 7.6 s↑ +30 %
LighthouseFirst Meaningful Paint🟨 2.9 s🟨 3.0 s↑ +4 %
LighthouseFirst Contentful Paint🟨 2.9 s🟨 3.0 s↑ +2 %
LighthouseTime to Interactive🟥 16.6 s🟥 18.4 s↑ +11 %
Code coverageBranch coverage🟨 83.5 %🟨 83.5 %↑ +0 %
Code coverageLine coverage🟩 91.9 %🟩 91.9 %↑ +0 %
LighthouseTotal Blocking Time🟥 7,340 ms🟥 12,620 ms↑ +72 %
LighthouseMinimizes main-thread work🟥 19.5 s🟥 24.2 s↑ +24 %
LighthouseJavaScript execution time🟥 9.6 s🟥 12.2 s↑ +27 %
LighthouseMetrics🟩 16638🟩 18449↑ +11 %
LighthouseAvoids enormous network payloads🟩 Total size was 1,786 KiB🟩 Total size was 1,787 KiB↑ +0 %
LighthouseMax Potential First Input Delay🟥 3,170 ms🟥 2,440 ms↓ −23 %
LighthouseUses efficient cache policy on static assets🟨 27 resources found🟨 27 resources found↑ +0 %
LighthouseServer Backend Latencies🟩 150 ms🟩 230 ms↑ +53 %
LighthouseInitial server response time was short🟩 Root document took 330 ms🟩 Root document took 380 ms↑ +15 %
LighthouseNetwork Round Trip Times🟩 20 ms🟩 30 ms↑ +14 %

490 other audits are unchanged.

@github-actionsgithub-actionsBot added the 🔬 testing writing tests label Jul 22, 2024
@BioPhoton
BioPhoton marked this pull request as ready for review July 22, 2024 10:03
@BioPhoton
BioPhoton merged commit ae5b2cd into mainJul 22, 2024
@BioPhoton
BioPhoton deleted the add-nested-objects-to-cli-args-parsing branch July 22, 2024 10:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton@matejchalk