Skip to content

fix: update pkgs - #965

Merged
BioPhoton merged 6 commits into
mainfrom
update-pkgs
Mar 11, 2025
Merged

fix: update pkgs#965
BioPhoton merged 6 commits into
mainfrom
update-pkgs

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Mar 5, 2025

Copy link
Copy Markdown
Collaborator

This are warnings from the CI run.

npm warn deprecated rimraf@2.4.5: Rimraf versions prior to v4 are no longer supported
npm warn deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@6.0.4: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

@github-actions

github-actionsBot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 7230fbc with previous commit c677fa2.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🟡 56🟡 50↓ −5.1
Updates🟡 81🟡 81↑ +0.5
Code coverage🟢 91🟢 91
Security🟡 75🟡 75
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Bug prevention🟢 100🟢 100
Code style🟢 100🟢 100
Documentation🔴 23🔴 23
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 5 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🟡 56🟡 50↓ −5.1
JS PackagesNPM outdated dependencies🟡 81🟡 81↑ +0.5

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseSpeed Index🟨 4.8 s🟨 5.7 s↑ +19 %
LighthouseFirst Contentful Paint🟨 2.7 s🟨 2.9 s↑ +7.6 %
LighthouseTotal Blocking Time🟥 2,270 ms🟥 5,180 ms↑ +128 %
LighthouseLargest Contentful Paint🟨 3.5 s🟨 3.6 s↑ +3.5 %
LighthouseTime to Interactive🟥 12.4 s🟥 13.9 s↑ +11.6 %
JS PackagesOutdated NPM prod dependencies.🟨 15 outdated package versions (4 major, 9 minor, 2 patch)🟨 15 outdated package versions (4 major, 9 minor, 2 patch) +0 %
LighthouseMinimizes main-thread work🟥 11.2 s🟥 16.5 s↑ +47.3 %
LighthouseJavaScript execution time🟥 5.7 s🟥 8.5 s↑ +48.9 %
LighthouseMetrics🟩 100%🟩 100%↑ +11.6 %
LighthouseMax Potential First Input Delay🟥 1,670 ms🟥 2,070 ms↑ +24.4 %
LighthouseAvoids enormous network payloads🟩 Total size was 1,829 KiB🟩 Total size was 1,828 KiB↓ −0.1 %
LighthouseEliminate render-blocking resources🟥 Potential savings of 1,000 ms🟥 Potential savings of 870 ms↓ −13 %
LighthouseServer Backend Latencies🟩 60 ms🟩 190 ms↑ +188 %
LighthouseUses efficient cache policy on static assets🟨 27 resources found🟨 27 resources found↓ −0.1 %
LighthouseInitial server response time was short🟩 Root document took 400 ms🟩 Root document took 330 ms↓ −16.9 %
LighthouseNetwork Round Trip Times🟩 10 ms🟩 40 ms↑ +346.7 %

580 other audits are unchanged.

@vmasek

Copy link
Copy Markdown
Collaborator

Do you want to update this PR or should it wait for packages update with the Nx upgrade after #971 is done?

@github-actionsgithub-actionsBot added the 🔬 testing writing tests label Mar 10, 2025
Comment threadpackages/plugin-eslint/vite.config.integration.ts Outdated
@github-actionsgithub-actionsBot removed the 🔬 testing writing tests label Mar 11, 2025
@BioPhoton
BioPhoton marked this pull request as ready for review March 11, 2025 11:10
@BioPhoton
BioPhoton merged commit 46d0102 into mainMar 11, 2025
@BioPhoton
BioPhoton deleted the update-pkgs branch March 11, 2025 11:47
Comment threadpackage.json
"multi-progress-bars": "^5.0.3",
"nx": "19.8.13",
"parse-lcov": "^1.0.4",
"rimraf": "^6.0.1",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using rimraf directly? 🤨

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we are, the report refers to transitive dependency, on other hand I wanted to use it for test folders cleanup anyway 😀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@BioPhoton@vmasek@matejchalk