Skip to content

feat: nx-plugin with v2 format - #971

Open
aramirezj wants to merge 23 commits into
code-pushup:mainfrom
aramirezj:feat--nx-plugin-v2
Open

feat: nx-plugin with v2 format#971
aramirezj wants to merge 23 commits into
code-pushup:mainfrom
aramirezj:feat--nx-plugin-v2

Conversation

@aramirezj

@aramirezjaramirezj commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

closes#881

@github-actionsgithub-actionsBot removed the 🔬 testing writing tests label Mar 9, 2025
@github-actions

github-actionsBot commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b03db63 with previous commit b03db63.

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🟡 51🔴 47↓ −3.2
Code coverage🟢 90🟢 90
Security🟡 67🟡 67
Updates🟡 81🟡 81
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Bug prevention🟢 100🟢 100
Code style🟢 100🟢 100
Documentation🔴 23🔴 23
👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🟡 51🔴 47↓ −3.2

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseSpeed Index🟨 5.3 s🟥 7.0 s↑ +32.6 %
LighthouseTime to Interactive🟥 12.0 s🟥 14.0 s↑ +17.5 %
LighthouseTotal Blocking Time🟥 2,310 ms🟥 6,290 ms↑ +172.1 %
LighthouseFirst Contentful Paint🟥 3.0 s🟨 2.9 s↓ −4.2 %
LighthouseLargest Contentful Paint🟨 3.8 s🟨 3.8 s↓ −1.2 %
LighthouseMinimizes main-thread work🟥 11.5 s🟥 19.5 s↑ +69.4 %
LighthouseJavaScript execution time🟥 5.1 s🟥 7.8 s↑ +53.7 %
LighthouseMetrics🟩 100%🟩 100%↑ +17.5 %
LighthouseMax Potential First Input Delay🟥 1,370 ms🟥 2,680 ms↑ +96.3 %
LighthouseEliminate render-blocking resources🟥 Potential savings of 1,000 ms🟥 Potential savings of 490 ms↓ −51.4 %
LighthouseUses efficient cache policy on static assets🟨 27 resources found🟨 27 resources found↓ −0.1 %
LighthouseServer Backend Latencies🟩 180 ms🟩 230 ms↑ +26.7 %
LighthouseInitial server response time was short🟩 Root document took 380 ms🟩 Root document took 400 ms↑ +6.8 %
LighthouseAvoids enormous network payloads🟩 Total size was 1,832 KiB🟩 Total size was 1,832 KiB↓ −0.1 %
LighthouseNetwork Round Trip Times🟩 60 ms🟩 60 ms↓ −2.4 %

581 other audits are unchanged.

Comment threadpackages/nx-plugin/src/plugin/utils.ts

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Soon we have it working for latest Nx.
We could add a test for the normalize function.

@aramirezjaramirezj changed the title feat: mvp nx-plugin with v2 formatfeat: nx-plugin with v2 formatMar 9, 2025
@vmasek

Copy link
Copy Markdown
Collaborator

From what I understood we are keeping both legacy and V2 for backwards compatibility.

Looks good so far, I'll watch this as this is now to only blocker for moving to latest Nx.
It will also unlock latest vitest which I'm looking forward updating to 👍🏻

@vmasekvmasek mentioned this pull request Mar 10, 2025
@BioPhoton

Copy link
Copy Markdown
Collaborator

From what I understood we are keeping both legacy and V2 for backwards compatibility.

Looks good so far, I'll watch this as this is now to only blocker for moving to latest Nx. It will also unlock latest vitest which I'm looking forward updating to 👍🏻

There is one thing left and that is considering projec.jsonANDpackage.json

@github-actionsgithub-actionsBot added the 🔬 testing writing tests label Mar 10, 2025
Comment threadpackages/nx-plugin/src/plugin/utils.ts Outdated
Comment threadpackages/nx-plugin/src/plugin/types.ts Outdated
aramirezjand others added 2 commits March 10, 2025 22:42
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>
Co-authored-by: Michael Hladky <10064416+BioPhoton@users.noreply.github.com>

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added changes for file extensions

BioPhoton
BioPhoton previously approved these changes Mar 10, 2025
@github-actionsgithub-actionsBot added the 📖 Project documentation improvements or additions to the project documentation label Mar 11, 2025
Comment threadtesting/test-nx-utils/src/lib/utils/nx-plugin.unit.test.ts Outdated
Comment threade2e/nx-plugin-e2e/tests/plugin-derive-config.e2e.test.ts Outdated
@aramirezj

Copy link
Copy Markdown
ContributorAuthor

All done! Ready to review again

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e tests fail in the nx-plugin this does not seem like flakeiness

Screenshot 2025-03-24 at 11 25 19

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 nx-plugin📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement create nodes V2 API for the nx-plugin project

3 participants

@aramirezj@vmasek@BioPhoton