Seperate lowercase and uppercase input by magnus-ISU · Pull Request #168 · codebicycle/videospeed

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU · 2021-12-16T03:15:39Z

This refactors a lot of input code to resolve#167 (shortcuts can be set to either uppercase or lowercase). The way it does so is by mostly ignoring the keyCode attribute of an input event and instead using the string key which contains more information and in a more human-readable way. Unfortunately, this currently means it breaks any preconfigured options a user has set and users will need to reconfigure it. Assuming this is unacceptable (I assume it is) I can add in a migration strategy; but I need to know how best that done.

I also removed the old 5.3.0 settings conversion code because its been here long enough I think. In doing so, I was able to simplify some logic. Additionally, vine.co does not really exist anymore so disabling the extension there by default is unneeded I think.

I need testing for numpad keys to see if they still work the same. I wrote this all on a laptop without them.

There are several TODOs marked around the code where I wasn't sure what was going on and need review to tell me if my comments are correct or not.

The version is not bumped, please tell me how to change it. This could be a bump to 0.7.0.0 or something, to signify it is a breaking change and add no migration. Or it could need to be updated to have a migration path, and become 0.6.4.0. Or maybe the project tracks upstream versions directly and only manifest-version should be bumped. I'm not sure.

EDIT: now adds the feature suggested in #119 also

…want to address before this is merged.

…t the code they are documenting

…ng wrong, but still doesn't work

…ion's behavior

…icated and should be essentially hidden, it is dumb to bypass the formatter

…ally better than keeping the first line right after

…s rule matches any reddit

… merge with seperate-lower-upper because it changes a lot about settings too

magnus-ISU · 2021-12-16T19:03:10Z

Just found out from reading #153 that this tracks upstream very closely and thus probably won't merge this. Time to plan to rewrite everything for chromium lol.

Also upstream is at 7.1 already, hurry up and update this!

magnus-ISU · 2021-12-16T23:57:49Z

Upstream PR: igrigorik#907

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

magnus-ISU added 25 commits December 15, 2021 10:15

Visually seperate the two, but don't logically
5df6612

Stash before I test whether I made all necessary changes
8e137c2

Still not working, can't figure out how to log either
6f88156

Working if you manually set options
8282783

Appears to be working?
25892c9

Actually working now. There is no migration for user's old settings
2fdadc1

In the progress of refactoring common code to a constants file
2c127b8

Modularity is not possible it seems
3d16740

Improve comments, collapse the imports, add TODOs for things I still …
163b9fc
…want to address before this is merged.

ignore directory that the official tool web-ext creates for builds
5761444

Add another TODO where one should be
7611b58

Remove nothing-comments that don't actually give any information abou…
0efef97
…t the code they are documenting

remove whitespace on a newline
e995630

Use imports as they should be if they worked
f685d20

This is needed in script tags, might have been part of what I was doi…
9a9b17a
…ng wrong, but still doesn't work

Fix options.js and now it works there
ef51c92

Readd inject's duplication of constants.js code
2c24494

derp
06b0d6f

Clean up code a bit, revert a dumb change I made in the logging funct…
af90027
…ion's behavior

Apply formatter - even though the constants code in inject.js is dupl…
6415661
…icated and should be essentially hidden, it is dumb to bypass the formatter

Realized that backslashes at the start of a multiline string are actu…
2388f56
…ally better than keeping the first line right after

Revert to switch on true - it is needed for regexes. Fix reddit so it…
da40d24
…s rule matches any reddit

Prepare for configurable sizes, but it is not possible yet; I want to…
9e58e7d
… merge with seperate-lower-upper because it changes a lot about settings too

Merge branch 'change-size-controls' into seperate-lower-upper
aade4d6

Customizable controller size
868e0b7

magnus-ISU mentioned this pull request Dec 16, 2021
Size of buttons #119
Open

magnus-ISU mentioned this pull request Dec 16, 2021
Feature Request: Capital and lowercase input is differentiated igrigorik/videospeed#906
Closed

magnus-ISU closed this Dec 16, 2021

Conversation

magnus-ISU commented Dec 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

magnus-ISU commented Dec 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

magnus-ISU commented Dec 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

magnus-ISU commented Dec 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

magnus-ISU commented Dec 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

magnus-ISU commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

magnus-ISU commented Dec 16, 2021•
edited
Loading

magnus-ISU commented Dec 16, 2021•
edited
Loading

magnus-ISU commented Dec 16, 2021•
edited
Loading

magnus-ISU commented Dec 16, 2021•
edited
Loading

magnus-ISU commented Dec 16, 2021•
edited
Loading

magnus-ISU commented Dec 16, 2021•
edited
Loading

magnus-ISU commented Dec 16, 2021•
edited
Loading