Skip to content

fix: miss the effects types - #5027

Merged
kobenguyent merged 5 commits into
3.xfrom
fix-missing-effects-types
Jun 26, 2025
Merged

fix: miss the effects types#5027
kobenguyent merged 5 commits into
3.xfrom
fix-missing-effects-types

Conversation

@kobenguyent

@kobenguyentkobenguyent commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
kobenguyent requested a review from CopilotJune 25, 2025 09:41

This comment was marked as outdated.

@kobenguyent
kobenguyent requested a review from CopilotJune 25, 2025 09:48

This comment was marked as outdated.

@kobenguyent
kobenguyent requested a review from CopilotJune 25, 2025 10:07

This comment was marked as outdated.

@kobenguyent
kobenguyent requested a review from CopilotJune 25, 2025 11:26

This comment was marked as outdated.

@kobenguyent
kobenguyent requested a review from CopilotJune 25, 2025 14:29

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing type definitions for effects by adding new type tests and updating configuration files.

  • Adds tests to verify that tryTo functions return promises with boolean values.
  • Updates the JSDoc configuration to include the new effects module.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
typings/tests/global-variables.types.tsAdded type tests for tryTo functions to ensure they return Promise
typings/jsdoc.conf.jsIncluded the effects module to generate documentation for new types

@kobenguyent
kobenguyent merged commit 926a36a into 3.xJun 26, 2025
@kobenguyent
kobenguyent deleted the fix-missing-effects-types branch June 26, 2025 08:26
@kobenguyentkobenguyent mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing TS definition for effects: Cannot find module 'codeceptjs/effects' or its corresponding type declarations

2 participants

@kobenguyent