refactor: PHP 8.0 constructor promotion by kenjis · Pull Request #6924 · codeigniter4/CodeIgniter4

kenjis · 2022-11-29T07:37:27Z

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis · 2022-11-29T07:37:27Z

Needs #6923

Description
See #6921

Use constructor promotion.
This may contain breaking changes.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

… '>=')`

Applied rules: * StrEndsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrStartsWithRector (https://wiki.php.net/rfc/add_str_starts_with_and_ends_with_functions) * StrContainsRector (https://externals.io/message/108562 php/php-src#5179)

…anual tweaks This may contains breaking changes.

kenjis · 2022-11-29T08:01:11Z

This is a breaking chage:
https://3v4l.org/BrHEP

samsonasik · 2022-11-29T08:06:21Z

Yes, that seems need to be skipped

kenjis · 2022-11-29T08:09:42Z

- $this->autoloader = $autoloader;
+ public function __construct(
+ protected Autoloader $autoloader
+ ) {


For example, if a dev extends FileLocator and it has protected $autoloader;,
this change is a breaking change.
https://3v4l.org/NhqDb

There are possible options:
make a note about property re-definition possible breaking change without add type
wait to push to 4.4 only

Another way;: make Rector extension to help user migrating to new definition.

Removing type in the constructor makes no errors (I don't know why),
https://3v4l.org/2A85L
but I don't want to remove already declared types in constructors.

Better way: make a patch to rector to:
skip non-typed property for protected/public property, except define INLINE_PUBLIC config that allow bc break on non-final class, same like TypedPropertyRector way
That's just quick guessing, probably there is a better way.

@kenjis here possibly the solution, I create PR to make it configurable INLINE_PUBLIC default false:
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126

This seems the best approach to me. Glad your patch was already accepted!

samsonasik · 2022-11-29T08:36:04Z

@kenjis some rules like StrEndsWithRector, StrStartsWithRector, StrContainsRector seems easy merge 👍 , define small PRs and iterate to next rules when possible.

kenjis · 2022-11-29T23:41:56Z

If we drop PHP 7.4 in v4.4, I would like to type missing public/protected properties with constructor promotion.
These will be breaking changes, though.

samsonasik · 2022-11-29T23:45:03Z

Yes, I agree 👍

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

kenjis added 10 commits November 29, 2022 09:21

Change min PHP version to 8.0
71599de

chore: require ^8.0 in composer.json
a13c231

chore: drop PHP 7.4 in workflows
202cb84

docs: require min PHP version 8.0
7142f27

refactor: remove version check `version_compare(PHP_VERSION, '8.0.0',…
2e9b5cb
… '>=')`

docs: add changelog
c482999

chore: use LevelSetList::UP_TO_PHP_80
adb8fea

docs: fix@vartype for IncomingRequest::$uri
3f7b2b3

refactor: apply ClassPropertyAssignToConstructorPromotionRector and m…
45d5d8f
…anual tweaks This may contains breaking changes.

kenjis added the 4.3 label Nov 29, 2022

kenjis marked this pull request as draft November 29, 2022 07:37

kenjis added 2 commits November 29, 2022 16:46

chore: add ClassPropertyAssignToConstructorPromotionRector
91b42da

style: change coding style for constructors
21daf33

kenjis added the refactor Pull requests that refactor code label Nov 29, 2022

kenjis mentioned this pull request Nov 29, 2022
refactor: upgrade to PHP 8.0 with rector #6923
Closed
5 tasks

kenjis commented Nov 29, 2022
View reviewed changes

kenjis added the breaking change Pull requests that may break existing functionalities label Nov 29, 2022

samsonasik mentioned this pull request Nov 29, 2022
[Php80] Make configurable INLINE_PUBLIC on ClassPropertyAssignToConstructorPromotionRector rectorphp/rector-src#3126
Merged

kenjis added 4.4 and removed 4.3 labels Nov 29, 2022

kenjis deleted the branch codeigniter4:4.3January 10, 2023 06:36

kenjis closed this Jan 10, 2023

Uh oh!

Conversation

kenjis commented Nov 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenjis commented Nov 29, 2022

Uh oh!

samsonasik commented Nov 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samsonasik commented Nov 29, 2022

Uh oh!

kenjis commented Nov 29, 2022

Uh oh!

samsonasik commented Nov 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kenjis commented Nov 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenjis commented Nov 29, 2022

Uh oh!

samsonasik commented Nov 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samsonasik commented Nov 29, 2022

Uh oh!

kenjis commented Nov 29, 2022

Uh oh!

samsonasik commented Nov 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kenjis commented Nov 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenjis commented Nov 29, 2022

kenjis commented Nov 29, 2022•
edited
Loading

kenjis commented Nov 29, 2022•
edited
Loading

kenjis commented Nov 29, 2022•
edited
Loading