Fix spark migrate issue with -g option

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.

[rougevache]

Description
Supersedes #7845

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails. This is because $this->ensureTable() is executed before $this->setGroup($group). I've simply moved $this->ensureTable() to execute after setting the group.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for sending PR!

You must sign all commits with a valid GPG key.
The first commit is not signed.
The second commit is not valid.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

[MGatner]

Code looks good! Please address the merge blockers.

[rougevache]

Sorry team, I was on vacation, I've removed the unsigned commit.

[datamweb]

@filoboss Your commit is still unsigned.
Please see here.

[kenjis]

No user is associated with the committer email.

[rougevache]

Ok, sorry, email author problem, this one is good.

[kenjis]

@filoboss Thank you for signing.

When performing a spark migrate with the -g option to use a different DBgroup other than the default, and when there's no default database configured, the migration fails.

Why there's no default database configured?
If not, it seems we cannot create the migration table.

Should it fail if you don't have the default database?

[kenjis]

Coding style check failed. Fix it.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6063126644/job/16459850567?pr=7846

[kenjis]

when there's no default database configured

If there is no default group in Config\Database, migration does not work at all.
Even if in this PR branch.

$ php spark migrate -g test1CodeIgniter v4.3.7 Command Line Tool - Server Time: 2023-09-04 02:08:22 UTC+00:00[InvalidArgumentException]default is not a valid database connection group.at SYSTEMPATH/Database/Config.php:69Backtrace: 1 SYSTEMPATH/Common.php:362 CodeIgniter\Database\Config::connect('default', true) 2 SYSTEMPATH/Database/MigrationRunner.php:151 db_connect(null) 3 SYSTEMPATH/Config/Services.php:415 CodeIgniter\Database\MigrationRunner()->__construct(null, null) 4 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations(Object(Config\Migrations), null, false) 5 SYSTEMPATH/Config/BaseService.php:193 CodeIgniter\Config\BaseService::__callStatic('migrations', [...]) 6 SYSTEMPATH/Config/Services.php:410 CodeIgniter\Config\BaseService::getSharedInstance('migrations', null, null) 7 SYSTEMPATH/Config/BaseService.php:252 CodeIgniter\Config\Services::migrations() 8 SYSTEMPATH/Commands/Database/Migrate.php:69 CodeIgniter\Config\BaseService::__callStatic('migrations', []) 9 SYSTEMPATH/CLI/Commands.php:65 CodeIgniter\Commands\Database\Migrate()->run([...]) 10 SYSTEMPATH/CLI/Console.php:37 CodeIgniter\CLI\Commands()->run('migrate', [...]) 11 ROOTPATH/spark:97 CodeIgniter\CLI\Console()->run()

[kenjis]

I'm sure there is a bug round the -g option, but I'm not sure how to fix it.
Please see #7891.

[kenjis]

We have update the description for -g. See #7894
And if you don't have the default DB group, CI4 does not work.
You must set the default DB group.

[qury]

Hi Guys,

I run into a this problem as well. I have multiple database connections defined. The default is a read-only DB.
When i define a migration and specify DBGroup to be a connection which is a differetn rw database then migration still failes that i can't write to the default DB.

For me the solution was to update the system/Commands/Database/Migrate.php file and do the below:

Now, i'm not sure if this is the right was to do this or if there are any other places to update, but as far as i can tell there is no other place besides the constructor in MigrationRunner where the database connection is set or where we allow to overwrite the db connection.

[kenjis]

@qury Your configuration is not supported by the CI4 DB migration.
The default database group must be writable.
Please see #7891 (comment) for migration assumptions.

So you need to customize the migration for yourself.
Your change seems okay if you have only one database to write.