fix: `spark migrate` `-g` option by kenjis · Pull Request #7894 · codeigniter4/CodeIgniter4

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis · 2023-09-04T07:10:33Z

Description
See #7891

fix description for -g in spark migrate, migrate:refresh, and migrate:status
remove -g option in spark migrate:rollback because it does not work (and should not work)

The current behavior

migrage:rollback:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:28 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:10:26 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:10:26 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:rollback -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:37 UTC+00:00Rolling back migrations to batch: 0 Rolling back: (App) 2023-09-04-013455_App\Database\Migrations\Test2AddBlog Rolling back: (App) 2023-09-04-013454_App\Database\Migrations\Test1AddBlog Rolling back: (App) 2023-09-04-013453_App\Database\Migrations\DefaultAddBlogDone rolling back migrations.
$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 06:10:39 UTC+00:00+-----------+-------------------+----------------+-------+-------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+-------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+-------+-------------+-------+

migrate:status:

$ php spark migrate:statusCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:42 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | test1 | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g defaultCodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:48 UTC+00:00+-----------+-------------------+----------------+---------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+---------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | default | 2023-09-04 06:22:19 | 1 || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | --- | --- | --- |+-----------+-------------------+----------------+---------+---------------------+-------+
$ php spark migrate:status -g test2CodeIgniter v4.4.0 Command Line Tool - Server Time: 2023-09-04 07:15:52 UTC+00:00+-----------+-------------------+----------------+-------+---------------------+-------+| Namespace | Version | Filename | Group | Migrated On | Batch |+-----------+-------------------+----------------+-------+---------------------+-------+| App | 2023-09-04-013453 | DefaultAddBlog | --- | --- | --- || App | 2023-09-04-013454 | Test1AddBlog | --- | --- | --- || App | 2023-09-04-013455 | Test2AddBlog | test2 | 2023-09-04 06:22:19 | 1 |+-----------+-------------------+----------------+-------+---------------------+-------+

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

Does this need a changelog note?

Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

kenjis · 2023-09-05T01:31:02Z

@MGatner Rebased and added changelog.

MGatner

Thanks! Looks good.

xonipatino · 2023-10-10T20:36:24Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):

if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}

this solved my problem.

It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

xonipatino · 2023-10-10T21:52:20Z

Hello everyone, I have had the same recent problem with version 4.4.1 having the CI_ENVIRONMENT in "development", review the code of the file \system\Database\MigrationRunner.php and comment the following lines (849 - 855):
if (ENVIRONMENT !== 'testing' && $group === 'tests' && $this->groupFilter !== 'tests') {
// @codeCoverageIgnoreStart
$this->groupSkip = true;
return true;
// @codeCoverageIgnoreEnd
}
this solved my problem.
It should be allowed that regardless of whether your CI_ENVIRONMENT is "production", "testing" or "development" you can rollback without any problem.

Hello, I found a better way to solve and modify these two files:

In \system\Commands\Database\MigrateRollback.php

lines 84-86 and 93:

/*if (is_string($group)) {
$runner->setGroup($group);
}*/
$group = is_string($group) ? $group : null;
...
...
...
if (! $runner->regress($batch, $group)) { //added second parameter

In \system\Database\MigrationRunner.php

lines 236-240:

// Set database group if not null
if ($group !== null) {
$this->groupFilter = $group; // add this lines
$this->setGroup($group);
}

kenjis · 2023-10-11T00:19:40Z

Your customization is yours, no problem.

But the specifications of the CI4 migration are:

If you find any behavior against the spec, feel free to create an issue or send a PR.

kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Sep 4, 2023

MGatner reviewed Sep 4, 2023
View reviewed changes

kenjis added 8 commits September 5, 2023 10:23

docs: add empty lines
4b3f577

docs: fix text decration
2c59aa9

docs: fix descripton for -g option in spark migrate
6cc94db

fix: remove -g option in migrate:rollback
710649f
Rollback specifies a batch number and returns the database to that state. It is not possible to specify a specific group to return to a state.

docs: fix descriptions for -g option
ec9d753

docs: fix out-of-dated explanation
6d94e2e

docs: add description for migration table
f4c8315

doc: add changelog
a58258f

kenjis force-pushed the fix-migration-db-group branch from ed9ba07 to a58258fCompare September 5, 2023 01:30

MGatner approved these changes Sep 9, 2023
View reviewed changes

kenjis merged commit 1ff3e6e into codeigniter4:developSep 9, 2023

kenjis deleted the fix-migration-db-group branch September 9, 2023 12:06

This was referenced Sep 11, 2023
What is the -g option in spark migrate for? #7891
Closed
Fix spark migrate issue with -g option #7846
Closed

michalsn mentioned this pull request Oct 10, 2023
migration:rollback does not work in 'development' environment #8026
Closed

kenjis mentioned this pull request Oct 18, 2023
Bug: Migration runner allows a $db but its never passed to the Migration files #8060
Closed