4.4.2 Ready code - #8062

Merged
kenjis merged 303 commits into
masterfrom
develop
Oct 19, 2023
Merged

4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom
develop

Conversation

@kenjis

@kenjiskenjis commented Oct 19, 2023

Copy link
Copy Markdown
Member

No description provided.

kenjisand others added 30 commits September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others added 28 commits October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis mentioned this pull request Oct 19, 2023
Merged
5 tasks
@kenjis
kenjis merged commit cf43310 into masterOct 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
4.4.2 Ready code - #8062
Merged
kenjis merged 303 commits into
masterfrom 
develop
Oct 19, 2023
Merged
4.4.2 Ready code#8062
kenjis merged 303 commits into
masterfrom 
develop
Conversation
@kenjis
@kenjiskenjis
commented
Oct 19, 2023

Copy link


Copy Markdown

Member
 No description provided. 
kenjisand others
added 30 commits
September 8, 2023 17:35
@kenjis
chore: add system/Test/ControllerResponse.php to skip list
94d546b
It caused an error.
Warning: Undefined array key 1852 in /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendor/nikic/php-parser/lib/PhpParser/Internal/TokenStream.php on line 209
Error: ] Could not process
"/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/ControllerResp
onse.php" file, due to:
"System error: "PhpParser\Internal\TokenStream::getIndentationBefore():
Return value must be of type int, null returned"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
209
Error: Process completed with exit code 1.
@kenjis
chore: change PHPUnitLevelSetList::UP_TO_PHPUNIT_100 to PHPUnitSetLis…
f75e33d
…t::PHPUNIT_100
It does not work for us.
See #7904 (comment)
@kenjis
chore: skip the specific rule
0276d89
See #7904 (comment)
@samsonasik
Merge pull request#7911from kenjis/fix-ReflectionHelper-setValue
b38cec4
[PHP 8.3] refactor: ReflectionProperty::setValue() signature deprecation
@samsonasik
Merge pull request#7904from kenjis/update-rector.php
64819ee
chore: update rector.php
@kenjis
chore: add PHP 8.3 to test-phpunit.yml
9f2bac3
@kenjis
chore: composer require --dev phpstan/phpstan-strict-rules
f094a28
@kenjis
chore: enable disallowedConstructs
92cf3bb
@kenjis
chore: update baseline
a3507c8
vendor/bin/phpstan analyze --generate-baseline phpstan-baseline.php
@kenjis
Merge pull request#7894from kenjis/fix-migration-db-group
1ff3e6e
fix: `spark migrate` `-g` option
@kenjis
Merge pull request#7910from kenjis/docs-filters.rst
bdbb775
docs: improve filters.rst
@kenjis
Merge pull request#7916from kenjis/add-phpstan-strict-rules-disallo…
cc28c41
…wedConstructs
chore: add phpstan-strict-rules disallowedConstructs
@paulbalandan
fix: types for common functions
7d3db2c
@paulbalandan
refactor: remove unneeded arguments to session
a6eceb0
@ddevsr
GH: auto label conflict PR
15787fd
@ddevsr
Update label-conflict.yml
4ac597b
@kenjis
test: change DBDebug to true
6f99752
@kenjis
Merge pull request#7919from paulbalandan/session-service
6c4f668
refactor: remove unneeded arguments to session
@ddevsr
remove uneeded trigger push
c3ccb20
@paulbalandan
Use phpstan-codeigniter
042eaaa
@ddevsr
fix: message issue comment
664aceb
@kenjis
Merge pull request#7907from ddevsr/patch-1
10b2514
fix: [DebugBar] dark mode `timeline-color-open` color text on `Debug`
@kenjis
Merge pull request#7917from paulbalandan/phpstan-helpers
37ff3a4
fix: types for common functions
@kenjis
Merge pull request#7921from ddevsr/patch-2
f314d0a
GH: auto label conflict PR
@kenjis
Merge pull request#7923from paulbalandan/phpstan-codeigniter
b6ecf0b
chore: use phpstan-codeigniter
@kenjis
chore: add matchingInheritedMethodNames rule
3f77632
@ddevsr
fix: move labeler conflict PR
b702cf6
@kenjis
Merge pull request#7928from ddevsr/move-labeler-conflict
f35f956
chore: fix move labeler conflict PR
@kenjis
docs: add warning on PHP 7.4 EOL
d06f9cf
@datamweb
chore: update phpstan exclude list
4905fe9
samsonasikand others
added 28 commits
October 16, 2023 11:28
@samsonasik
empty string context is impossible
11fcb7a
@samsonasik
add assert array for properties
9c49724
@samsonasik
move alternatives to previous assign
e73893f
@samsonasik
updated to only check not null
534d917
@samsonasik
updated to only check not null
8f015f8
@samsonasik
updated to only check not null
9cb0fba
@samsonasik
updated to only check not null
201f4a0
@samsonasik
updated to only check not null
ca30ea6
@samsonasik
updated to only check not null
6f2c5ff
@samsonasik@kenjis
add empty string check
3803fbc
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik@kenjis
add empty string check
faa0c99
Co-authored-by: kenjis <kenji.uui@gmail.com>
@samsonasik
run rector
0317245
@samsonasik
regenerate baseline
31ed124
@kenjis
Merge pull request#7951from samsonasik/boolean-in-if
431748b
[Rector] Apply BooleanInIfConditionRuleFixerRector
@kenjis
Merge pull request#8040from kenjis/fix-spark-routes-bug
21132d4
fix: `spark routes` may show incorrect route names
@kenjis
Merge pull request#8041from kenjis/docs-improve-curlrequest.rst
364d9e1
docs: improve curlrequest.rst
@kenjis
docs: add note for routes after calling resetServices()
1f753bc
@kenjis
fix: file sort order
87ea6a9
Sort by full path.
@kenjis
Merge pull request#8043from kenjis/docs-fix-installation/upgrade_fi…
dd02f5e
…le_upload
docs: fix anchor text in installation/upgrade_file_upload.rst
@kenjis
Merge pull request#8047from kenjis/docs-testing-service-reset
2fe4f94
docs: add note for routes after calling resetServices()
@kenjis
test: fix assertion
054061a
There was 1 failure:
1) CodeIgniter\Database\BaseConnectionTest::testStoresConnectionTimings
Failed asserting that '0.000000' is greater than 0.0.
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/BaseConnectionTest.php:125
@kenjis
Merge pull request#8052from kenjis/fix-BaseConnectionTest-testStore…
098bd10
…sConnectionTimings
test: fix assertion in BaseConnectionTest::testStoresConnectionTimings()
@kenjis
Merge pull request#8037from kenjis/fix-Factories-cache-bug
a9fa8f0
fix: Factories caching bug
@kenjis
Merge pull request#8048from kenjis/fix-Files-Collector-sort
afe3cb2
fix: file sort order in Files DebugBar
@kenjis
Prep for 4.4.2 release
14fd67b
@kenjis
docs: split CHANGELOG.md
1f5d5ee
@kenjis
docs: fix typo
28191cc
@kenjis
Merge pull request#8061from kenjis/release-4.4.2
47b3460
Prep for 4.4.2 release
@kenjiskenjis
mentioned this pull request
Oct 19, 2023
 Merged

5 tasks
@kenjis
kenjis
merged commit cf43310
into
masterOct 19, 2023
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

14 participants

@kenjis@neznaika0@samsonasik@paulbalandan@ddevsr@datamweb@totoprayogo1916@pjsde@michalsn@sammyskills@dgvirtual@obozdag@ping-yee@mostafakhudair