Skip to content

feat: [Validation] add field_exists rule - #8123

Merged
kenjis merged 10 commits into
codeigniter4:4.5from
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged

feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from
kenjis:feat-validation-field_exists

Conversation

@kenjis

@kenjiskenjis commented Oct 30, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Needs #8131

Description
For #8006

  • add rule to check if the field exist in the data

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis added enhancement PRs that improve existing functionalities 4.5 labels Oct 30, 2023
kenjis
kenjis commented Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
?string $error = null,
?string $field = null
): bool {
return array_key_exists($field, $data);

@kenjiskenjisOct 30, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?

@MGatnerMGatnerNov 5, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.

@MGatnerMGatnerNov 5, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.

@kenjiskenjisNov 9, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
Closed
Merged
@kenjis
kenjis marked this pull request as draft October 31, 2023 06:05
@kenjis
kenjisforce-pushed the feat-validation-field_exists branch 2 times, most recently from 673ff74 to eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis marked this pull request as ready for review November 8, 2023 08:00
@michalsn

michalsn commented Nov 8, 2023•
edited
Loading

Copy link
Copy Markdown
Member

I believe we would also need versions _with and _without.

Yes for dot array syntax. I see it's already done.

@kenjis

kenjis commented Nov 9, 2023

Copy link
Copy Markdown
MemberAuthor

I believe we would also need versions _with and _without.

Really?
Do you have a use case?

@michalsn

michalsn commented Nov 11, 2023

Copy link
Copy Markdown
Member

Sorry, I forgot about this one.

Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.

I think I saw a request like this a long time ago, but I can't find it now.

@kenjis

kenjis commented Nov 12, 2023

Copy link
Copy Markdown
MemberAuthor

I think we can use required_with in most cases.

Some optional fields depend on selected parameters. They're not required though.

If it is not required, then it is okay that the key does not exists in the data.
Also, if it depends on selected parameters, we need to write custom rule?

If it is required, and the value may be null, empty string, then we need field_exists_with.

@kenjis
kenjisforce-pushed the feat-validation-field_exists branch from f24c53a to cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner approved these changes Nov 19, 2023
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.

@kenjis
kenjis merged commit 8b72997 into codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis deleted the feat-validation-field_exists branch November 19, 2023 21:02
@kenjiskenjis mentioned this pull request Nov 22, 2023
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees

No one assigned

Labels

enhancementPRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: [Validation] add `field_exists` rule by kenjis · Pull Request #8123 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: [Validation] add field_exists rule - #8123
Merged
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged
feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Conversation
@kenjis
@kenjiskenjis
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Needs #8131
Description

For #8006
  • add rule to check if the field exist in the data
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

labels
Oct 30, 2023
kenjis
kenjis
commented
Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
 ?string $error = null,
 ?string $field = null
 ): bool {
 return array_key_exists($field, $data);
@kenjiskenjisOct 30, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.
@kenjiskenjisNov 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
 Closed

 Merged

@kenjis
kenjis
marked this pull request as draft
October 31, 2023 06:05
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
2 times, most recently
from
673ff74 to
eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis
marked this pull request as ready for review
November 8, 2023 08:00
@michalsn
michalsn
commented
Nov 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
I believe we would also need versions _with and _without.
Yes for dot array syntax. I see it's already done.
@kenjis
kenjis
commented
Nov 9, 2023

Copy link


Copy Markdown

MemberAuthor
I believe we would also need versions _with and _without.
Really?

Do you have a use case?
@michalsn
michalsn
commented
Nov 11, 2023

Copy link


Copy Markdown

Member
Sorry, I forgot about this one.
Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.
I think I saw a request like this a long time ago, but I can't find it now.
@kenjis
kenjis
commented
Nov 12, 2023

Copy link


Copy Markdown

MemberAuthor
I think we can use required_with in most cases.
Some optional fields depend on selected parameters. They're not required though.
If it is not required, then it is okay that the key does not exists in the data.

Also, if it depends on selected parameters, we need to write custom rule?
If it is required, and the value may be null, empty string, then we need field_exists_with.
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
from
f24c53a to
cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner
approved these changes
Nov 19, 2023
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.
@kenjis
kenjis
merged commit 8b72997
into
codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis
deleted the

feat-validation-field_exists

branch
November 19, 2023 21:02
@kenjiskenjis
mentioned this pull request
Nov 22, 2023
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels

enhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: [Validation] add `field_exists` rule by kenjis · Pull Request #8123 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: [Validation] add field_exists rule - #8123
Merged
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged
feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Conversation
@kenjis
@kenjiskenjis
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Needs #8131
Description

For #8006
  • add rule to check if the field exist in the data
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

labels
Oct 30, 2023
kenjis
kenjis
commented
Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
 ?string $error = null,
 ?string $field = null
 ): bool {
 return array_key_exists($field, $data);
@kenjiskenjisOct 30, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.
@kenjiskenjisNov 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
 Closed

 Merged

@kenjis
kenjis
marked this pull request as draft
October 31, 2023 06:05
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
2 times, most recently
from
673ff74 to
eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis
marked this pull request as ready for review
November 8, 2023 08:00
@michalsn
michalsn
commented
Nov 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
I believe we would also need versions _with and _without.
Yes for dot array syntax. I see it's already done.
@kenjis
kenjis
commented
Nov 9, 2023

Copy link


Copy Markdown

MemberAuthor
I believe we would also need versions _with and _without.
Really?

Do you have a use case?
@michalsn
michalsn
commented
Nov 11, 2023

Copy link


Copy Markdown

Member
Sorry, I forgot about this one.
Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.
I think I saw a request like this a long time ago, but I can't find it now.
@kenjis
kenjis
commented
Nov 12, 2023

Copy link


Copy Markdown

MemberAuthor
I think we can use required_with in most cases.
Some optional fields depend on selected parameters. They're not required though.
If it is not required, then it is okay that the key does not exists in the data.

Also, if it depends on selected parameters, we need to write custom rule?
If it is required, and the value may be null, empty string, then we need field_exists_with.
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
from
f24c53a to
cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner
approved these changes
Nov 19, 2023
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.
@kenjis
kenjis
merged commit 8b72997
into
codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis
deleted the

feat-validation-field_exists

branch
November 19, 2023 21:02
@kenjiskenjis
mentioned this pull request
Nov 22, 2023
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels

enhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: [Validation] add `field_exists` rule by kenjis · Pull Request #8123 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: [Validation] add field_exists rule - #8123
Merged
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged
feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Conversation
@kenjis
@kenjiskenjis
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Needs #8131
Description

For #8006
  • add rule to check if the field exist in the data
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

labels
Oct 30, 2023
kenjis
kenjis
commented
Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
 ?string $error = null,
 ?string $field = null
 ): bool {
 return array_key_exists($field, $data);
@kenjiskenjisOct 30, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.
@kenjiskenjisNov 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
 Closed

 Merged

@kenjis
kenjis
marked this pull request as draft
October 31, 2023 06:05
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
2 times, most recently
from
673ff74 to
eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis
marked this pull request as ready for review
November 8, 2023 08:00
@michalsn
michalsn
commented
Nov 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
I believe we would also need versions _with and _without.
Yes for dot array syntax. I see it's already done.
@kenjis
kenjis
commented
Nov 9, 2023

Copy link


Copy Markdown

MemberAuthor
I believe we would also need versions _with and _without.
Really?

Do you have a use case?
@michalsn
michalsn
commented
Nov 11, 2023

Copy link


Copy Markdown

Member
Sorry, I forgot about this one.
Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.
I think I saw a request like this a long time ago, but I can't find it now.
@kenjis
kenjis
commented
Nov 12, 2023

Copy link


Copy Markdown

MemberAuthor
I think we can use required_with in most cases.
Some optional fields depend on selected parameters. They're not required though.
If it is not required, then it is okay that the key does not exists in the data.

Also, if it depends on selected parameters, we need to write custom rule?
If it is required, and the value may be null, empty string, then we need field_exists_with.
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
from
f24c53a to
cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner
approved these changes
Nov 19, 2023
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.
@kenjis
kenjis
merged commit 8b72997
into
codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis
deleted the

feat-validation-field_exists

branch
November 19, 2023 21:02
@kenjiskenjis
mentioned this pull request
Nov 22, 2023
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels

enhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat: [Validation] add `field_exists` rule by kenjis · Pull Request #8123 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: [Validation] add field_exists rule - #8123
Merged
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged
feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Conversation
@kenjis
@kenjiskenjis
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Needs #8131
Description

For #8006
  • add rule to check if the field exist in the data
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

labels
Oct 30, 2023
kenjis
kenjis
commented
Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
 ?string $error = null,
 ?string $field = null
 ): bool {
 return array_key_exists($field, $data);
@kenjiskenjisOct 30, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.
@kenjiskenjisNov 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
 Closed

 Merged

@kenjis
kenjis
marked this pull request as draft
October 31, 2023 06:05
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
2 times, most recently
from
673ff74 to
eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis
marked this pull request as ready for review
November 8, 2023 08:00
@michalsn
michalsn
commented
Nov 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
I believe we would also need versions _with and _without.
Yes for dot array syntax. I see it's already done.
@kenjis
kenjis
commented
Nov 9, 2023

Copy link


Copy Markdown

MemberAuthor
I believe we would also need versions _with and _without.
Really?

Do you have a use case?
@michalsn
michalsn
commented
Nov 11, 2023

Copy link


Copy Markdown

Member
Sorry, I forgot about this one.
Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.
I think I saw a request like this a long time ago, but I can't find it now.
@kenjis
kenjis
commented
Nov 12, 2023

Copy link


Copy Markdown

MemberAuthor
I think we can use required_with in most cases.
Some optional fields depend on selected parameters. They're not required though.
If it is not required, then it is okay that the key does not exists in the data.

Also, if it depends on selected parameters, we need to write custom rule?
If it is required, and the value may be null, empty string, then we need field_exists_with.
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
from
f24c53a to
cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner
approved these changes
Nov 19, 2023
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.
@kenjis
kenjis
merged commit 8b72997
into
codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis
deleted the

feat-validation-field_exists

branch
November 19, 2023 21:02
@kenjiskenjis
mentioned this pull request
Nov 22, 2023
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels

enhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: [Validation] add `field_exists` rule by kenjis · Pull Request #8123 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: [Validation] add field_exists rule - #8123
Merged
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged
feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Conversation
@kenjis
@kenjiskenjis
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Needs #8131
Description

For #8006
  • add rule to check if the field exist in the data
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

labels
Oct 30, 2023
kenjis
kenjis
commented
Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
 ?string $error = null,
 ?string $field = null
 ): bool {
 return array_key_exists($field, $data);
@kenjiskenjisOct 30, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.
@kenjiskenjisNov 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
 Closed

 Merged

@kenjis
kenjis
marked this pull request as draft
October 31, 2023 06:05
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
2 times, most recently
from
673ff74 to
eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis
marked this pull request as ready for review
November 8, 2023 08:00
@michalsn
michalsn
commented
Nov 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
I believe we would also need versions _with and _without.
Yes for dot array syntax. I see it's already done.
@kenjis
kenjis
commented
Nov 9, 2023

Copy link


Copy Markdown

MemberAuthor
I believe we would also need versions _with and _without.
Really?

Do you have a use case?
@michalsn
michalsn
commented
Nov 11, 2023

Copy link


Copy Markdown

Member
Sorry, I forgot about this one.
Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.
I think I saw a request like this a long time ago, but I can't find it now.
@kenjis
kenjis
commented
Nov 12, 2023

Copy link


Copy Markdown

MemberAuthor
I think we can use required_with in most cases.
Some optional fields depend on selected parameters. They're not required though.
If it is not required, then it is okay that the key does not exists in the data.

Also, if it depends on selected parameters, we need to write custom rule?
If it is required, and the value may be null, empty string, then we need field_exists_with.
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
from
f24c53a to
cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner
approved these changes
Nov 19, 2023
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.
@kenjis
kenjis
merged commit 8b72997
into
codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis
deleted the

feat-validation-field_exists

branch
November 19, 2023 21:02
@kenjiskenjis
mentioned this pull request
Nov 22, 2023
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels

enhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
feat: [Validation] add `field_exists` rule by kenjis · Pull Request #8123 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: [Validation] add field_exists rule - #8123
Merged
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Nov 19, 2023
Merged
feat: [Validation] add field_exists rule#8123
kenjis merged 10 commits into
codeigniter4:4.5from 
kenjis:feat-validation-field_exists
Conversation
@kenjis
@kenjiskenjis
commented
Oct 30, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Needs #8131
Description

For #8006
  • add rule to check if the field exist in the data
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

labels
Oct 30, 2023
kenjis
kenjis
commented
Oct 30, 2023
View reviewed changes
Comment threadsystem/Validation/Rules.php
 ?string $error = null,
 ?string $field = null
 ): bool {
 return array_key_exists($field, $data);
@kenjiskenjisOct 30, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we need to handle the key with dot array syntax?
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'm afraid so. See required_without above. May be worth having a private method for $data transformations.
@MGatnerMGatnerNov 5, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see your next PR - much better solution.
@kenjiskenjisNov 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

This was referenced Oct 30, 2023
 Closed

 Merged

@kenjis
kenjis
marked this pull request as draft
October 31, 2023 06:05
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
2 times, most recently
from
673ff74 to
eda462aCompareNovember 8, 2023 07:46
@kenjis
kenjis
marked this pull request as ready for review
November 8, 2023 08:00
@michalsn
michalsn
commented
Nov 8, 2023•

edited

Loading

Copy link


Copy Markdown

Member
I believe we would also need versions _with and _without.
Yes for dot array syntax. I see it's already done.
@kenjis
kenjis
commented
Nov 9, 2023

Copy link


Copy Markdown

MemberAuthor
I believe we would also need versions _with and _without.
Really?

Do you have a use case?
@michalsn
michalsn
commented
Nov 11, 2023

Copy link


Copy Markdown

Member
Sorry, I forgot about this one.
Example... an API with a custom payload? Some optional fields depend on selected parameters. They're not required though.
I think I saw a request like this a long time ago, but I can't find it now.
@kenjis
kenjis
commented
Nov 12, 2023

Copy link


Copy Markdown

MemberAuthor
I think we can use required_with in most cases.
Some optional fields depend on selected parameters. They're not required though.
If it is not required, then it is okay that the key does not exists in the data.

Also, if it depends on selected parameters, we need to write custom rule?
If it is required, and the value may be null, empty string, then we need field_exists_with.
@kenjis
kenjisforce-pushed
the
feat-validation-field_exists
branch
from
f24c53a to
cfa4fa1CompareNovember 12, 2023 02:45
MGatner
MGatner
approved these changes
Nov 19, 2023
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think starting here makes sense and if we find need for additional related rules they can follow.
@kenjis
kenjis
merged commit 8b72997
into
codeigniter4:4.5Nov 19, 2023
@kenjis
kenjis
deleted the

feat-validation-field_exists

branch
November 19, 2023 21:02
@kenjiskenjis
mentioned this pull request
Nov 22, 2023
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels

enhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@MGatner