Skip to content

feat: add ArrayHelper::dotKeyExists() - #8131

Merged
kenjis merged 3 commits into
codeigniter4:4.5from
kenjis:feat-ArrayHelper-dotKeyExists
Nov 6, 2023
Merged

feat: add ArrayHelper::dotKeyExists()#8131
kenjis merged 3 commits into
codeigniter4:4.5from
kenjis:feat-ArrayHelper-dotKeyExists

Conversation

@kenjis

@kenjiskenjis commented Oct 31, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Needs #8130

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis added enhancement PRs that improve existing functionalities 4.5 labels Oct 31, 2023
@kenjis
kenjis marked this pull request as draft October 31, 2023 06:04
@kenjiskenjis mentioned this pull request Oct 31, 2023
Merged
5 tasks
@kenjis
kenjisforce-pushed the feat-ArrayHelper-dotKeyExists branch 2 times, most recently from d1930b8 to 7ee981aCompareOctober 31, 2023 06:34
@kenjiskenjis mentioned this pull request Oct 31, 2023
Closed
5 tasks
@kenjis
kenjisforce-pushed the feat-ArrayHelper-dotKeyExists branch 2 times, most recently from 9101a92 to c107070CompareNovember 3, 2023 00:44
@kenjis
kenjis marked this pull request as ready for review November 3, 2023 00:45
MGatner
MGatner approved these changes Nov 5, 2023
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice recursive implementation.

Comment threadsystem/Helpers/Array/ArrayHelper.php
@kenjis
kenjisforce-pushed the feat-ArrayHelper-dotKeyExists branch from 3531245 to dce6576CompareNovember 6, 2023 01:13
@kenjis
kenjis merged commit e875b05 into codeigniter4:4.5Nov 6, 2023
@kenjis
kenjis deleted the feat-ArrayHelper-dotKeyExists branch November 6, 2023 21:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes

Assignees

No one assigned

Labels

enhancementPRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis@MGatner