feat: add DB config `dateFormat` to provide default date/time formats by kenjis · Pull Request #8525 · codeigniter4/CodeIgniter4

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis · 2024-02-07T04:03:21Z

Description
See #7177

add DB config dateFormat

We should have this config value in the Connection class. Because each connection has the datetime format.

The current DB related class layers:

Entity
Model
Builder
Connection

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

MGatner

I think this is the right way for the config, but it still leaves a big question about implementation. Were you planning that as a separate PR?

ddevsr · 2024-02-07T13:08:04Z

I hope this feature can be used by .env for multiple connection

kenjis · 2024-02-08T00:47:44Z

Some people want to use .env too much.
It is only for Config items that may change in different environments.
For example, if you build a development environment, the database host/username/password would be different from these in the production environment.
But why do you need to change the datatime format?

kenjis · 2024-02-08T01:37:33Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

MGatner

I'm good with this but there were a lot of differing opinions on the original thread - maybe see if @michalsn and @lonnieezell have thoughts.

github-actions · 2024-02-10T00:45:50Z

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

kenjis · 2024-02-13T01:29:54Z

@MGatner Yes, I'm going to use these values in Model and DataConverter (DataCaster) #8243.

#8538 and #8243. Both are ready to merge.

kenjis added enhancement PRs that improve existing functionalities 4.5 labels Feb 7, 2024

kenjis mentioned this pull request Feb 7, 2024
[Model] DateTime hardcoded format Y-m-d H:i:s drives to error on some databases #7177
Closed

kenjis force-pushed the feat-db-config-dateFormat branch from 0a8f785 to 79f5d3fCompare February 7, 2024 11:48

MGatner reviewed Feb 7, 2024
View reviewed changes

MGatner approved these changes Feb 8, 2024
View reviewed changes

michalsn approved these changes Feb 9, 2024
View reviewed changes

github-actionsBot added the stale Pull requests with conflicts label Feb 10, 2024

kenjis force-pushed the feat-db-config-dateFormat branch from 7d792d2 to 629de41Compare February 10, 2024 00:51

kenjis removed the stale Pull requests with conflicts label Feb 10, 2024

kenjis added 2 commits February 12, 2024 08:39

feat: add DB config dateFormat to provide default date/time formats
a738313

docs: add missing '
2a7591c

kenjis force-pushed the feat-db-config-dateFormat branch from 629de41 to 2a7591cCompare February 11, 2024 23:39

kenjis merged commit 3b23657 into codeigniter4:4.5Feb 12, 2024

kenjis deleted the feat-db-config-dateFormat branch February 12, 2024 01:27

This was referenced Feb 12, 2024
feat: use $db->dateFormat in Model #8538
Merged
[4.5] fix: $db->dateFormat merge #8539
Merged

kenjis added the database Issues or pull requests that affect the database layer label Feb 12, 2024