Skip to content

feat: use $db->dateFormat in Model - #8538

Merged
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged

feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:feat-model-uses-db-dateFormat

Conversation

@kenjis

@kenjiskenjis commented Feb 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Description
For #7177
See #8525

How it works

If you set the date/time formats in your DB config,

'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],

the formats will be used when a Model converts a Time instance to a string.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis added enhancement PRs that improve existing functionalities 4.5 database Issues or pull requests that affect the database layer labels Feb 12, 2024
@kenjis
kenjisforce-pushed the feat-model-uses-db-dateFormat branch from 4dc1711 to d38f1f2CompareFebruary 13, 2024 01:15
@kenjis

kenjis commented Feb 13, 2024

Copy link
Copy Markdown
MemberAuthor

Added docs.

@kenjiskenjis mentioned this pull request Feb 13, 2024
Merged
5 tasks
kenjis added a commit to kenjis/codeigniter-shield that referenced this pull request Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis mentioned this pull request Feb 14, 2024
Merged
5 tasks
@kenjis
kenjis merged commit 17381a0 into codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis deleted the feat-model-uses-db-dateFormat branch February 17, 2024 02:05
This was referenced Feb 19, 2024
Closed
Closed
@kenjis

kenjis commented Apr 8, 2024

Copy link
Copy Markdown
MemberAuthor

This change is not sufficient. See codeigniter4/shield#1086 (comment)

@kenjiskenjis mentioned this pull request Apr 9, 2024
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
+1 more reviewer
@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: use $db->dateFormat in Model by kenjis · Pull Request #8538 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: use $db->dateFormat in Model - #8538
Merged
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged
feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Conversation
@kenjis
@kenjiskenjis
commented
Feb 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Description

For #7177

See #8525
How it works
If you set the date/time formats in your DB config,
'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],
the formats will be used when a Model converts a Time instance to a string.
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

database
Issues or pull requests that affect the database layer
labels
Feb 12, 2024
@kenjis
kenjisforce-pushed
the
feat-model-uses-db-dateFormat
branch
from
4dc1711 to
d38f1f2CompareFebruary 13, 2024 01:15
@kenjis
kenjis
commented
Feb 13, 2024

Copy link


Copy Markdown

MemberAuthor
Added docs.
@kenjiskenjis
mentioned this pull request
Feb 13, 2024
 Merged

5 tasks
kenjis added a commit
to kenjis/codeigniter-shield
that referenced
this pull request
Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis
mentioned this pull request
Feb 14, 2024
 Merged

5 tasks
@kenjis
kenjis
merged commit 17381a0
into
codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis
deleted the

feat-model-uses-db-dateFormat

branch
February 17, 2024 02:05

This was referenced Feb 19, 2024

Closed


Closed

@kenjis
kenjis
commented
Apr 8, 2024

Copy link


Copy Markdown

MemberAuthor
This change is not sufficient. See codeigniter4/shield#1086 (comment)
@kenjiskenjis
mentioned this pull request
Apr 9, 2024
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

+1 more reviewer

@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use $db->dateFormat in Model by kenjis · Pull Request #8538 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: use $db->dateFormat in Model - #8538
Merged
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged
feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Conversation
@kenjis
@kenjiskenjis
commented
Feb 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Description

For #7177

See #8525
How it works
If you set the date/time formats in your DB config,
'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],
the formats will be used when a Model converts a Time instance to a string.
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

database
Issues or pull requests that affect the database layer
labels
Feb 12, 2024
@kenjis
kenjisforce-pushed
the
feat-model-uses-db-dateFormat
branch
from
4dc1711 to
d38f1f2CompareFebruary 13, 2024 01:15
@kenjis
kenjis
commented
Feb 13, 2024

Copy link


Copy Markdown

MemberAuthor
Added docs.
@kenjiskenjis
mentioned this pull request
Feb 13, 2024
 Merged

5 tasks
kenjis added a commit
to kenjis/codeigniter-shield
that referenced
this pull request
Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis
mentioned this pull request
Feb 14, 2024
 Merged

5 tasks
@kenjis
kenjis
merged commit 17381a0
into
codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis
deleted the

feat-model-uses-db-dateFormat

branch
February 17, 2024 02:05

This was referenced Feb 19, 2024

Closed


Closed

@kenjis
kenjis
commented
Apr 8, 2024

Copy link


Copy Markdown

MemberAuthor
This change is not sufficient. See codeigniter4/shield#1086 (comment)
@kenjiskenjis
mentioned this pull request
Apr 9, 2024
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

+1 more reviewer

@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use $db->dateFormat in Model by kenjis · Pull Request #8538 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: use $db->dateFormat in Model - #8538
Merged
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged
feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Conversation
@kenjis
@kenjiskenjis
commented
Feb 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Description

For #7177

See #8525
How it works
If you set the date/time formats in your DB config,
'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],
the formats will be used when a Model converts a Time instance to a string.
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

database
Issues or pull requests that affect the database layer
labels
Feb 12, 2024
@kenjis
kenjisforce-pushed
the
feat-model-uses-db-dateFormat
branch
from
4dc1711 to
d38f1f2CompareFebruary 13, 2024 01:15
@kenjis
kenjis
commented
Feb 13, 2024

Copy link


Copy Markdown

MemberAuthor
Added docs.
@kenjiskenjis
mentioned this pull request
Feb 13, 2024
 Merged

5 tasks
kenjis added a commit
to kenjis/codeigniter-shield
that referenced
this pull request
Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis
mentioned this pull request
Feb 14, 2024
 Merged

5 tasks
@kenjis
kenjis
merged commit 17381a0
into
codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis
deleted the

feat-model-uses-db-dateFormat

branch
February 17, 2024 02:05

This was referenced Feb 19, 2024

Closed


Closed

@kenjis
kenjis
commented
Apr 8, 2024

Copy link


Copy Markdown

MemberAuthor
This change is not sufficient. See codeigniter4/shield#1086 (comment)
@kenjiskenjis
mentioned this pull request
Apr 9, 2024
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

+1 more reviewer

@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat: use $db->dateFormat in Model by kenjis · Pull Request #8538 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: use $db->dateFormat in Model - #8538
Merged
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged
feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Conversation
@kenjis
@kenjiskenjis
commented
Feb 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Description

For #7177

See #8525
How it works
If you set the date/time formats in your DB config,
'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],
the formats will be used when a Model converts a Time instance to a string.
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

database
Issues or pull requests that affect the database layer
labels
Feb 12, 2024
@kenjis
kenjisforce-pushed
the
feat-model-uses-db-dateFormat
branch
from
4dc1711 to
d38f1f2CompareFebruary 13, 2024 01:15
@kenjis
kenjis
commented
Feb 13, 2024

Copy link


Copy Markdown

MemberAuthor
Added docs.
@kenjiskenjis
mentioned this pull request
Feb 13, 2024
 Merged

5 tasks
kenjis added a commit
to kenjis/codeigniter-shield
that referenced
this pull request
Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis
mentioned this pull request
Feb 14, 2024
 Merged

5 tasks
@kenjis
kenjis
merged commit 17381a0
into
codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis
deleted the

feat-model-uses-db-dateFormat

branch
February 17, 2024 02:05

This was referenced Feb 19, 2024

Closed


Closed

@kenjis
kenjis
commented
Apr 8, 2024

Copy link


Copy Markdown

MemberAuthor
This change is not sufficient. See codeigniter4/shield#1086 (comment)
@kenjiskenjis
mentioned this pull request
Apr 9, 2024
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

+1 more reviewer

@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use $db->dateFormat in Model by kenjis · Pull Request #8538 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: use $db->dateFormat in Model - #8538
Merged
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged
feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Conversation
@kenjis
@kenjiskenjis
commented
Feb 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Description

For #7177

See #8525
How it works
If you set the date/time formats in your DB config,
'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],
the formats will be used when a Model converts a Time instance to a string.
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

database
Issues or pull requests that affect the database layer
labels
Feb 12, 2024
@kenjis
kenjisforce-pushed
the
feat-model-uses-db-dateFormat
branch
from
4dc1711 to
d38f1f2CompareFebruary 13, 2024 01:15
@kenjis
kenjis
commented
Feb 13, 2024

Copy link


Copy Markdown

MemberAuthor
Added docs.
@kenjiskenjis
mentioned this pull request
Feb 13, 2024
 Merged

5 tasks
kenjis added a commit
to kenjis/codeigniter-shield
that referenced
this pull request
Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis
mentioned this pull request
Feb 14, 2024
 Merged

5 tasks
@kenjis
kenjis
merged commit 17381a0
into
codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis
deleted the

feat-model-uses-db-dateFormat

branch
February 17, 2024 02:05

This was referenced Feb 19, 2024

Closed


Closed

@kenjis
kenjis
commented
Apr 8, 2024

Copy link


Copy Markdown

MemberAuthor
This change is not sufficient. See codeigniter4/shield#1086 (comment)
@kenjiskenjis
mentioned this pull request
Apr 9, 2024
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

+1 more reviewer

@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
feat: use $db->dateFormat in Model by kenjis · Pull Request #8538 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
feat: use $db->dateFormat in Model - #8538
Merged
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Feb 17, 2024
Merged
feat: use $db->dateFormat in Model#8538
kenjis merged 2 commits into
codeigniter4:4.5from 
kenjis:feat-model-uses-db-dateFormat
Conversation
@kenjis
@kenjiskenjis
commented
Feb 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Description

For #7177

See #8525
How it works
If you set the date/time formats in your DB config,
'dateFormat' => [
'date' => 'Y-m-d',
'datetime' => 'Y-m-d H:i:s',
],
the formats will be used when a Model converts a Time instance to a string.
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added

enhancement
PRs that improve existing functionalities
4.5

database
Issues or pull requests that affect the database layer
labels
Feb 12, 2024
@kenjis
kenjisforce-pushed
the
feat-model-uses-db-dateFormat
branch
from
4dc1711 to
d38f1f2CompareFebruary 13, 2024 01:15
@kenjis
kenjis
commented
Feb 13, 2024

Copy link


Copy Markdown

MemberAuthor
Added docs.
@kenjiskenjis
mentioned this pull request
Feb 13, 2024
 Merged

5 tasks
kenjis added a commit
to kenjis/codeigniter-shield
that referenced
this pull request
Feb 14, 2024
@kenjis
refactor: remove hard coded 'Y-m-d H:i:s'
b05dbdc
See codeigniter4#608
and codeigniter4/CodeIgniter4#8538
@kenjiskenjis
mentioned this pull request
Feb 14, 2024
 Merged

5 tasks
@kenjis
kenjis
merged commit 17381a0
into
codeigniter4:4.5Feb 17, 2024
@kenjis
kenjis
deleted the

feat-model-uses-db-dateFormat

branch
February 17, 2024 02:05

This was referenced Feb 19, 2024

Closed


Closed

@kenjis
kenjis
commented
Apr 8, 2024

Copy link


Copy Markdown

MemberAuthor
This change is not sufficient. See codeigniter4/shield#1086 (comment)
@kenjiskenjis
mentioned this pull request
Apr 9, 2024
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes

+1 more reviewer

@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

databaseIssues or pull requests that affect the database layerenhancementPRs that improve existing functionalities

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@michalsn@datamweb