refactor: [db:create] add command line message on detect extension sqlite3 not loaded by renpv · Pull Request #9051 · codeigniter4/CodeIgniter4

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

renpv · 2024-07-18T23:54:08Z

add command line message on detect extension sqlite3 not loaded

Description
Explain what you have changed, and why.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

add command line message on detect extension sqlite3 not loaded

ddevsr · 2024-07-19T01:47:49Z

What you want to solve? and describe a problem

kenjis · 2024-07-19T02:53:01Z

+ if (!extension_loaded('sqlite3')) {
+ CLI::error("extension [sqlite3] not loaded. Uncomment it in the php.ini file", 'light_gray', 'red');
+ CLI::newLine();
+
+ return;
+ }


I don't accept this in here. It is only for SQLite3, so it should not in this class.

kenjis · 2024-07-19T02:53:30Z

Why do you need this?

renpv · 2024-07-19T10:41:31Z

Com essa extensão desabilitada, se tentar conectar a um banco SQLite o sistema retorna o seguinte erro: [image: c8b6bcc0-391d-443c-97ed-a6b3945161f6.png] Essa mensagem dificulta a resolução do problema. Com essa linha de código o sistema vai retornar essa mensagem: [image: image.png] Estou sugerindo incluir esse código porque não é a primeira vez que eu perco um tempo considerável tentando resolver um problema baseado em uma mensagem errada. Eu coloquei nesse arquivo porque ele faz algumas validações iniciais relacionadas ao SQLite. Fico à disposição. Atenciosamente, Em qui., 18 de jul. de 2024, 23:53, kenjis ***@***.***> escreveu:

…

Why do you need this? — Reply to this email directly, view it on GitHub <#9051 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGKSQJ2D2MKWLDUPVB3BZTZNB5UBAVCNFSM6AAAAABLDSSJKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXHE4DANRUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

renpv · 2024-07-19T19:36:58Z

What you want to solve? and describe a problem

With the extension disabled, when trying to execute a command related to SQLite the system returns an error that does not help with resolution.

I'm including this code because it's not the first time I've spend a specific amount of time trying to solve a problem based on a
wrong message.

kenjis · 2024-07-19T23:08:26Z

Can you show the exact error message that does not help?

renpv · 2024-07-20T00:36:55Z

Can you show the exact error message that does not help?

kenjis · 2024-07-20T02:29:56Z

We have some commands to use database. All commands would report the same error message Class “SQLite3” not found.

Database
db:create Create a new database schema.
db:seed Runs the specified seeder to populate known data into the database.
db:table Retrieves information on the selected table.
migrate Locates and runs all new migrations against the database.
migrate:refresh Does a rollback followed by a latest to refresh the current state of the database.
migrate:rollback Runs the "down" method for all migrations in the last batch.
migrate:status Displays a list of all migrations and whether they've been run or not.

We have some database drivers. The drivers other than SQLite3 would report error messages if the extension is not loaded.

$ php spark db:create report
CodeIgniter v4.5.3 Command Line Tool - Server Time: 2024-07-20 02:22:47 UTC+00:00
[CodeIgniter\Database\Exceptions\DatabaseException]
Unable to connect to the database.
Main connection [SQLSRV]: Undefined constant "CodeIgniter\Database\SQLSRV\SQLSRV_ENC_CHAR"
at SYSTEMPATH/Database/BaseConnection.php:467

kenjis · 2024-07-20T02:47:22Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

renpv · 2024-07-20T10:03:06Z

How about this?

--- a/system/Database/SQLite3/Connection.php+++ b/system/Database/SQLite3/Connection.php@@ -55,6 +55,16 @@ class Connection extends BaseConnection
*/
protected $busyTimeout;
+ public function __construct(array $params)+ {+ assert(+ extension_loaded('sqlit3'),+ 'The required PHP extension "sqlit3" is not loaded.'+ );++ parent::__construct($params);+ }+
/**
* @return void
*/

Great. Much better. But sqlit3 is wrong. Correct sqlite3

renpv · 2024-07-22T12:18:17Z

I think the same happens with the other drivers

kenjis · 2024-08-30T01:05:02Z

@renpv I sent #9160. Check it.

kenjis · 2024-09-05T01:25:04Z

Closed by #9160

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Update CreateDatabase.php
b7c945b
add command line message on detect extension sqlite3 not loaded

renpv changed the title ~~Update CreateDatabase.php~~refactor: add command line message on detect extension sqlite3 not loadedJul 18, 2024

kenjis reviewed Jul 19, 2024
View reviewed changes

kenjis changed the title ~~refactor: add command line message on detect extension sqlite3 not loaded~~refactor: [db:create] add command line message on detect extension sqlite3 not loadedJul 19, 2024

kenjis mentioned this pull request Aug 30, 2024
refactor: improve error message for missing PHP DB extensions #9160
Merged
5 tasks

kenjis closed this Sep 5, 2024

Uh oh!

Conversation

renpv commented Jul 18, 2024• edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ddevsr commented Jul 19, 2024

Uh oh!

kenjisJul 19, 2024

Choose a reason for hiding this comment

Uh oh!

kenjis commented Jul 19, 2024

Uh oh!

renpv commented Jul 19, 2024 via email

Uh oh!

renpv commented Jul 19, 2024

Uh oh!

kenjis commented Jul 19, 2024

Uh oh!

renpv commented Jul 20, 2024

Uh oh!

kenjis commented Jul 20, 2024

Uh oh!

kenjis commented Jul 20, 2024

Uh oh!

renpv commented Jul 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

renpv commented Jul 22, 2024

Uh oh!

kenjis commented Aug 30, 2024

Uh oh!

kenjis commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

renpv commented Jul 18, 2024• edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ddevsr commented Jul 19, 2024

Uh oh!

kenjisJul 19, 2024

Choose a reason for hiding this comment

Uh oh!

kenjis commented Jul 19, 2024

Uh oh!

renpv commented Jul 19, 2024 via email

Uh oh!

renpv commented Jul 19, 2024

Uh oh!

kenjis commented Jul 19, 2024

Uh oh!

renpv commented Jul 20, 2024

Uh oh!

kenjis commented Jul 20, 2024

Uh oh!

kenjis commented Jul 20, 2024

Uh oh!

renpv commented Jul 20, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

renpv commented Jul 22, 2024

Uh oh!

kenjis commented Aug 30, 2024

Uh oh!

kenjis commented Sep 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

renpv commented Jul 18, 2024•
edited by kenjis
Loading

renpv commented Jul 20, 2024•
edited
Loading

renpv commented Jul 18, 2024•
edited by kenjis
Loading

renpv commented Jul 20, 2024•
edited
Loading

renpv commented Jul 18, 2024•
edited by kenjis
Loading

renpv commented Jul 20, 2024•
edited
Loading

renpv commented Jul 18, 2024•
edited by kenjis
Loading