refactor: improve error message for missing PHP DB extensions by kenjis · Pull Request #9160 · codeigniter4/CodeIgniter4

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

kenjis · 2024-08-30T01:02:20Z

Description
Supersedes #9051
See #9158

$ php spark db:create reportCodeIgniter v4.5.4 Command Line Tool - Server Time: 2024-08-30 00:59:08 UTC+00:00[CodeIgniter\Exceptions\CriticalError]The required PHP extension "sqlsrv" is not loaded. Install and enable it to use "SQLSRV" driver.at SYSTEMPATH/Database/Database.php:177...

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

To improve the error message.

paulbalandan · 2024-08-30T01:13:33Z

 throw new InvalidArgumentException('You have not selected a database type to connect to.');
 }

+ assert($this->checkDbExtension($params['DBDriver']));


Do we need the assert here if the method throws by itself?

My intention is not to slow down CI4 at all by executing the check every time in production environment.
When zend.assertions is -1, PHP does not generate code for assert().
First, this check (error message) is only for PHP beginners. Once the extension is enabled, the check will be not needed.
And this error often happens on development environments.
On shared hosting servers, they probably know what DBMS is supported, and PHP extensions for supported DBs are installed.

Because we can name any classname.

feat: add function to check PHP DB extension
59aca8e
To improve the error message.

kenjis mentioned this pull request Aug 30, 2024
refactor: [db:create] add command line message on detect extension sqlite3 not loaded #9051
Closed
5 tasks

paulbalandan reviewed Aug 30, 2024
View reviewed changes

fix: pass through custom drivers
a9925c7
Because we can name any classname.

paulbalandan approved these changes Aug 30, 2024
View reviewed changes

ddevsr added the refactor Pull requests that refactor code label Aug 30, 2024

michalsn approved these changes Aug 31, 2024
View reviewed changes

ddevsr approved these changes Sep 4, 2024
View reviewed changes

kenjis merged commit ffd1b68 into codeigniter4:developSep 5, 2024

kenjis deleted the check-db-ext branch September 5, 2024 01:23