[4.6] fix: Time::createFromTimestamp() change for PHP 8.4

[kenjis]

Needs #9107

Description
Follow-up #8544

• Time::createFromTimestamp() (without timezone specified) should return Time with the timezone UTC, because DateTime(Immutable)::createFromTimestamp() in PHP 8.4 returns an instance with the timezone +00:00.
• update the method signature for PHP 8.4.
• replaceself with static.

PHP 8.4 introduces new DateTime(Immutable)::createFromTimestamp() method.
https://php.watch/versions/8.4/datetime-createFromTimestamp

bash-3.2$ php -vPHP 8.4.0-dev (cli) (built: Aug 5 2024 00:57:29) (NTS)Copyright (c) The PHP GroupZend Engine v4.4.0-dev, Copyright (c) Zend Technologies with Zend OPcache v8.4.0-dev, Copyright (c), by Zend Technologies

bash-3.2$ php -aInteractive shellphp > $d = DateTimeImmutable::createFromTimeStamp(0);php > var_dump($d);object(DateTimeImmutable)#1 (3) { ["date"]=> string(26) "1970-01-01 00:00:00.000000" ["timezone_type"]=> int(1) ["timezone"]=> string(6) "+00:00"}

Carbon and Chronos have changed the behaviors.

createFromTimestamp UTC by default
Timezone for createFromTimestamp was previously date_default_timezone_get() in Carbon 2.
In Carbon 3, it's now "UTC" so to be consistent with DateTime behavior when doing new DateTime('@123').
https://carbon.nesbot.com/docs/#api-carbon-3

Chronos::createFromTimestamp() handles timezones differently. If $timezone is not explicitly passed then the instance has timezone set to +00:00 unlike earlier where the currently set default timezone was used. This behavior change normalizes behavior with changes in PHP 8.4 which adds a new DateTimeInterface::createFromTimestamp() method.
https://github.com/cakephp/chronos/releases/tag/3.1.0

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

I thought this was due to float, but the following test passes. Why?

$timestamp = 1489762800.654321;
$time = \DateTimeImmutable::createFromTimestamp($timestamp);
$this->assertSame('2017-03-17 15:00:00.654321', $time->format('Y-m-d H:i:s.u'));

[paulbalandan]

The u format expresses the time in microseconds which is a millionth of a second. So, the expressed time is six decimal digits.

[kenjis]

I meant the following test passes. Why 654300 and 654321?

$timestamp = 1489762800.654321;
$time1 = Time::createFromTimestamp($timestamp);
$time2 = \DateTimeImmutable::createFromTimestamp($timestamp);
$this->assertSame('2017-03-17 15:00:00.654300', $time1->format('Y-m-d H:i:s.u'));
$this->assertSame('2017-03-17 15:00:00.654321', $time2->format('Y-m-d H:i:s.u'));

[michalsn]

It probably has something to do with the default precision (which is 14 by default).

In the Time::createFromTimestamp method, we use:

$time = newstatic('@' . $timestamp, 'UTC', $locale);

Which will "cut" the ending and make it: .6543. We can either set ini_set('precision', 16) at the framework level which is not ideal or use sprintf here:

$time = newstatic(sprintf('@%.6f', $timestamp), 'UTC', $locale);

[kenjis]

sprintf('@%.6f', $timestamp) works. Thank you!