Uh oh!
There was an error while loading. Please reload this page.
fix: TimeTrait::createFromTimestamp() method signature for PHP 8.4 - #9134
Closed
kenjis wants to merge 5 commits into
Closed
fix: TimeTrait::createFromTimestamp() method signature for PHP 8.4#9134kenjis wants to merge 5 commits into
kenjis wants to merge 5 commits into
Conversation
PHP Fatal error: Declaration of CodeIgniter\I18n\TimeTrait::createFromTimestamp(int $timestamp, $timezone = null, ?string $locale = null) must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static in /home/runner/work/CodeIgniter4/CodeIgniter4/system/I18n/TimeTrait.php on line 268
kenjis
commented
Aug 21, 2024
MemberAuthor
If we don't support PHP 8.4 in v4.5.x, we don't need this PR. |
kenjis
marked this pull request as draft
August 21, 2024 08:23
kenjis
commented
Aug 26, 2024
MemberAuthor
We do not support PHP 8.4 in v4.5.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #9116
Related #9105
Checklist: