Uh oh!
There was an error while loading. Please reload this page.
feat: add email/smtp plain auth method - #9462
Conversation
Hi there, ip-qi! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
1e680cb to
cfd2a60CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
a41e011 to
23b58b3Compare
michalsn
left a comment
There was a problem hiding this comment.
Thank you for the updates.
The changelog is now merged, so you can rebase and add an entry there (https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/changelogs/v4.7.0.rst), under the section: "Enhancements -> Libraries". You can check previous changelogs to see what convention we use.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
2e48e51 to
beb8700CompareUh oh!
There was an error while loading. Please reload this page.
7d43afb to
27fc469CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ction return types -comment: add depreceation comment for failedSMTPLogin email error message -refactor: improve authorization validation flow and email error response messages -added $SMTPAuthMethod in Config\Email file with default value of login
27fc469 to
f3b64edCompareUh oh!
There was an error while loading. Please reload this page.
apply suggestion for declaring string type of $SMTPAuthMethod Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
Apply Suggestion for description of SMTPAuthMethod Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Uh oh!
There was an error while loading. Please reload this page.
Apply suggestions for changelog Co-authored-by: Michal Sniatala <michal@sniatala.pl>
michalsn
commented
Mar 3, 2025
@ip-qi Thank you and congratulations on your first contribution to the project! |
ip-qi
commented
Mar 3, 2025
@michalsn You are most welcome! I really appreciate the help, collaboration, and direction from both you and @paulbalandan. |
$SMTPAuthMethod = 'LOGIN' <- which is by default set to LOGIN to avoid breaking existing email setups.
This can be overriden within Config\Email to utilize 'PLAIN' AUTH method
NOTE: 'LOGIN' method could not be tested currently from my part so if possible someone test it please, i have manually tested 'PLAIN' authentication method and it is working as expected.
Explain what you have changed, and why.
Checklist: