Skip to content

refactor: remove finfo_close has no effect since PHP 8.1 - #9684

Merged
paulbalandan merged 1 commit into
codeigniter4:4.7from
ddevsr:patch-4
Aug 19, 2025
Merged

refactor: remove finfo_close has no effect since PHP 8.1#9684
paulbalandan merged 1 commit into
codeigniter4:4.7from
ddevsr:patch-4

Conversation

@ddevsr

@ddevsrddevsr commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Description
Based php/php-src#18396 and related to #9664

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsrddevsr added enhancement PRs that improve existing functionalities 4.7 refactor Pull requests that refactor code and removed enhancement PRs that improve existing functionalities labels Aug 14, 2025
michalsn
michalsn reviewed Aug 14, 2025
View reviewed changes

@michalsnmichalsn left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use unset() instead?

@ddevsrddevsr mentioned this pull request Aug 14, 2025
Closed
17 tasks
@ddevsr

ddevsr commented Aug 19, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Can we use unset() instead?

@michalsn Is needed unset($finfo)? i think no

@ddevsr

ddevsr commented Aug 19, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Read from https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion, all function in that RFC no need call again since we required minimum PHP 8.1

@ddevsr
refactor: remove finfo_close has no effect since PHP 8.0
cee6dd5
refactor: remove `finfo_close` has no effect since PHP 8.0
@ddevsrddevsr changed the title refactor: finfo_close automatically freed in PHP 8.5refactor: remove finfo_close has no effect since PHP 8.1Aug 19, 2025
@paulbalandan
paulbalandan merged commit ae08d14 into codeigniter4:4.7Aug 19, 2025
49 checks passed
@ddevsr
ddevsr deleted the patch-4 branch September 3, 2025 08:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsnmichalsnmichalsn approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr@michalsn@paulbalandan