fileinfo: Deprecate finfo_close()

[TimWolla]

Does this need an RFC or can we do this by simple agreement? Requesting reviews from Girgias and the RMs 😄

---

This is for consistency with other *_close() functions that have become obsolete when migrating from resources to objects.

[DanielEScherzer]

I added this to https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_finfo_close already

[TimWolla]

Thanks, I've linked this PR in the RFC as the implementation.

[Girgias]

I think merging the test changes already is fine.

But having it in the bulk RFC is probably the "proper" way to do it, even if I would agree just deprecating it should be fine.

[TimWolla]

I think merging the test changes already is fine.

#18405.

[jorgsowa]

Suggested change

	#[\Deprecated(since: '8.5', message: 'as finfo objects are freed automatically')]
	#[\Deprecated(since: 'PHP 8.5', message: 'as finfo objects are freed automatically')]

Isn't it better to be explicit about the version? There may be case that the plain version number may be confused with other software, i.e. MySQL has close version number.

[TimWolla]

This is a discussion for another place. The “bare version” format is what is currently used by PHP core. See: 29f98e7